From e215422b897d0ecdda97aa6d2c3a7c2853844c11 Mon Sep 17 00:00:00 2001 From: Lars Dieckow Date: Tue, 22 Oct 2013 17:53:27 +0200 Subject: [PATCH] MT#4609 extend checks when editing the own admin user to prevent locking oneself out --- lib/NGCP/Panel/Controller/Administrator.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/NGCP/Panel/Controller/Administrator.pm b/lib/NGCP/Panel/Controller/Administrator.pm index 6d806ad82e..357ad5f8c2 100644 --- a/lib/NGCP/Panel/Controller/Administrator.pm +++ b/lib/NGCP/Panel/Controller/Administrator.pm @@ -171,11 +171,10 @@ sub edit :Chained('base') :PathPart('edit') :Args(0) { ); if ($posted && $form->validated) { try { - # don't allow to take away own master rights, otherwise he'll not be + # don't allow to take away own master rights/write permission, otherwise he'll not be # able to manage any more admins if($c->stash->{administrator}->id == $c->user->id) { - delete $form->values->{is_master}; - delete $form->values->{is_active}; + delete $form->values->{$_} for qw(is_master is_active read_only); } if($c->user->is_superuser) {