diff --git a/lib/NGCP/Panel/Role/API/Subscribers.pm b/lib/NGCP/Panel/Role/API/Subscribers.pm index ddb1cc86b5..823e3beb9b 100644 --- a/lib/NGCP/Panel/Role/API/Subscribers.pm +++ b/lib/NGCP/Panel/Role/API/Subscribers.pm @@ -489,7 +489,7 @@ sub update_item { NGCP::Panel::Utils::Subscriber::update_subscriber_numbers( c => $c, schema => $schema, - exists $resource->{e164} ? (primary_number => $resource->{e164}) : (), + primary_number => $resource->{e164}, alias_numbers => $alias_numbers, reseller_id => $customer->contact->reseller_id, subscriber_id => $subscriber->id, diff --git a/lib/NGCP/Panel/Utils/Subscriber.pm b/lib/NGCP/Panel/Utils/Subscriber.pm index c055e7a068..21f2fbbb39 100644 --- a/lib/NGCP/Panel/Utils/Subscriber.pm +++ b/lib/NGCP/Panel/Utils/Subscriber.pm @@ -288,9 +288,7 @@ sub prepare_resource { $resource->{administrative} = $item ? $item->provisioning_voip_subscriber->admin : 0; } - if (exists $resource->{primary_number}) { - $resource->{e164} = delete $resource->{primary_number}; - } + $resource->{e164} = delete $resource->{primary_number}; $resource->{status} //= 'active'; $resource->{administrative} //= 0; $resource->{is_pbx_pilot} //= 0; @@ -1545,7 +1543,7 @@ sub update_subscriber_numbers { $alias->{e164}->{is_devid} = delete $alias->{is_devid}; } - if (defined $current_primary_number && $current_primary_number == $cli) { + if ($current_primary_number == $cli) { die "alias '" . $c->qs($cli) . "' is already defined as the primary number"; }