From d7cb06c21540820f377cc1d814a08cd6634d68d6 Mon Sep 17 00:00:00 2001
From: Gerhard Jungwirth <gjungwirth@sipwise.com>
Date: Tue, 14 Aug 2018 12:25:50 +0200
Subject: [PATCH] TT#38811 fix changed subscriber form

alias_numbers are in a different format than expected by the form.

Change-Id: Id3146e0538e3a02aa520c663a641f1eabb0eee06
---
 lib/NGCP/Panel/Role/API/Subscribers.pm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lib/NGCP/Panel/Role/API/Subscribers.pm b/lib/NGCP/Panel/Role/API/Subscribers.pm
index 11d227c81e..ef07736aca 100644
--- a/lib/NGCP/Panel/Role/API/Subscribers.pm
+++ b/lib/NGCP/Panel/Role/API/Subscribers.pm
@@ -349,13 +349,12 @@ sub prepare_resource {
             $self->error($c, HTTP_UNPROCESSABLE_ENTITY, 'Invalid alias_number parameter, must be an array.');
             return;
         }
-        $resource->{alias_numbers} = [ map {{ e164 => $_ }} @{ $resource->{alias_numbers} // [] } ];
         foreach my $alias_number (@{$resource->{alias_numbers}}){
-            if( ref $alias_number->{e164} ne "HASH"){
+            if( ref $alias_number ne "HASH"){
                 $self->error($c, HTTP_UNPROCESSABLE_ENTITY, 'Invalid alias_number parameter, must be an array of the hashes.');
                 return;
             } else {
-                delete $alias_number->{e164}->{number_id};
+                delete $alias_number->{number_id};
             }
         }
     }
@@ -367,6 +366,9 @@ sub prepare_resource {
         form => $form,
     );
 
+    # this format is expected by NGCP::Panel::Utils::Subscriber::create_subscriber
+    $resource->{alias_numbers} = [ map {{ e164 => $_ }} @{ $resource->{alias_numbers} // [] } ];
+
     unless($domain) {
         $domain = $c->model('DB')->resultset('domains')->search({'me.id' => $resource->{domain_id}});
         if($c->user->roles eq "admin") {