TT#56376 selenium: improvements to delete_domain()

Common.pm:
- add garbage text search to delete_domain function, should prevent
stale_element_exception.
- changed a few element ids, should be better for future tests.

Change-Id: I8e9b0bbd7438f14670685ef7c09609c01b2c2375

t/lib/Selenium/Collection/Common.pm

@@ -15,8 +15,8 @@ sub create_domain {
     return unless $name;
 
     diag('Go to domains page');
-    $self->driver->find_element('//*[@id="main-nav"]/li[5]/a')->click();
-    $self->driver->find_element('//*[@id="main-nav"]/li[5]/ul/li[6]/a')->click();
+    $self->driver->find_element('//*[@id="main-nav"]//*[contains(text(),"Settings")]')->click();
+    $self->driver->find_element("Domains", 'link_text')->click();
 
     diag('Try to add a domain');
     $self->driver->find_element('//*[@id="content"]/div/div[1]/span[2]/a')->click();
@@ -31,10 +31,12 @@ sub delete_domain {
     return unless $name;
 
     diag('Go to domains page');
-    $self->driver->find_element('//*[@id="main-nav"]/li[5]/a')->click();
-    $self->driver->find_element('//*[@id="main-nav"]/li[5]/ul/li[6]/a')->click();
+    $self->driver->find_element('//*[@id="main-nav"]//*[contains(text(),"Settings")]')->click();
+    $self->driver->find_element("Domains", 'link_text')->click();
 
     diag('Try to delete a domain');
+    $self->driver->fill_element('//*[@id="Domain_table_filter"]/label/input', 'xpath', 'thisshouldnotexist');
+    ok($self->driver->find_element_by_css('#Domain_table tr > td.dataTables_empty', 'css'), 'Garbage text was not found');
     $self->driver->fill_element('//*[@id="Domain_table_filter"]/label/input', 'xpath', $name);
     ok($self->driver->wait_for_text('//*[@id="Domain_table"]/tbody/tr[1]/td[3]', $name), "Domain found");
     $self->driver->move_action(element => $self->driver->find_element('//*[@id="Domain_table"]/tbody/tr[1]/td[3]'));