From ca97df400d84b429ed01d1455ccc1edb607d360a Mon Sep 17 00:00:00 2001 From: Andreas Granig Date: Thu, 14 Feb 2019 10:47:13 +0100 Subject: [PATCH] TT#52628 Fix serving autoprov firmwares for unknown macs We need to detach in chain base, otherwise chain tail will access undefined dev variable from stash and will produce a 500 server error. Change-Id: I9ac5d18b365efd2390cb2800ec5adadd4992e989 --- lib/NGCP/Panel/Controller/Device.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/NGCP/Panel/Controller/Device.pm b/lib/NGCP/Panel/Controller/Device.pm index 75d6ab90f4..ada4d73820 100644 --- a/lib/NGCP/Panel/Controller/Device.pm +++ b/lib/NGCP/Panel/Controller/Device.pm @@ -1850,6 +1850,7 @@ sub dev_field_firmware_base :Chained('/') :PathPart('device/autoprov/firmware') $c->response->body("404 - device not found"); } $c->response->status(404); + $c->detach(); return; } $id =~ s/^([^\=]+)\=0$/$1/; @@ -1866,6 +1867,7 @@ sub dev_field_firmware_base :Chained('/') :PathPart('device/autoprov/firmware') $c->response->body("404 - device not found"); } $c->response->status(404); + $c->detach(); return; } @@ -1907,6 +1909,7 @@ sub dev_field_firmware_version_base :Chained('dev_field_firmware_base') :PathPar $c->response->body("404 - firmware not found"); } $c->response->status(404); + $c->detach(); return; }