TT#45484 Allow api controllers to control errors and return code

Change-Id: I4b0c00210f482169437431c8a07f1ae27965ccf0

lib/NGCP/Panel/Controller/API/AdminsItem.pm

@@ -49,7 +49,7 @@ sub delete_item {
         return $self->hal_from_item($c, $item); });
     
     $item->delete;
-    return;
+    return 1;
 }
 
 #we don't use update_item for the admins now, as we dont allo PUT and PATCH

lib/NGCP/Panel/Controller/API/BannedIpsItem.pm

@@ -19,6 +19,7 @@ sub delete_item {
     my($self, $c, $item, $old_resource, $resource, $form) = @_;
     my $ip = $item;
     NGCP::Panel::Utils::Security::ip_unban($c, $ip);
+    return 1;
 }
 
 1;

lib/NGCP/Panel/Controller/API/BannedUsersItem.pm

@@ -19,6 +19,7 @@ sub delete_item {
     my($self, $c, $item, $old_resource, $resource, $form) = @_;
     my $user = $item;
     NGCP::Panel::Utils::Security::user_unban($c, $user);
+    return 1;
 }
 
 1;

lib/NGCP/Panel/Controller/API/CallRecordingsItem.pm

@@ -18,7 +18,7 @@ sub allowed_methods{
 sub delete_item {
     my ($self, $c, $item) = @_;
     NGCP::Panel::Utils::Subscriber::delete_callrecording( c => $c, recording => $item );
-    return;
+    return 1;
 }
 
 1;

lib/NGCP/Panel/Controller/API/RewriteRuleSetsItem.pm

@@ -31,7 +31,7 @@ sub delete_item {
         $guard->commit;
         NGCP::Panel::Utils::Rewrite::sip_dialplan_reload($c);
     }
-    return;
+    return 1;
 }
 
 sub update_item_model {

lib/NGCP/Panel/Controller/API/RewriteRulesItem.pm

@@ -23,12 +23,12 @@ sub delete_item {
         } catch($e) {
             $c->log->error("Failed to delete rewriterule with id '".$item->id."': $e");
             $self->error($c, HTTP_INTERNAL_SERVER_ERROR, "Internal Server Error");
-            die;
+            return;
         }
         $guard->commit;
         NGCP::Panel::Utils::Rewrite::sip_dialplan_reload($c);
     }
-    return;
+    return 1;
 }
 
 sub update_item_model {

lib/NGCP/Panel/Role/EntitiesItem.pm

@@ -353,6 +353,8 @@ sub delete {  ## no critic (ProhibitBuiltinHomonyms)
         #here we left space for information that checking failed and we decided not to delete item
         if ($self->delete_item($c, $item)) {
             $self->add_journal_item_hal($c, { hal => $hal });
+        } else {
+            return;
         }
 
         $self->complete_transaction($c);