TT#29909 fix remaining "use warnings" perlcritic errors

Change-Id: I6f0d1537c8de161b969d6afac8c2a2d3fecb6c31

lib/NGCP/Panel/Utils/DeviceBootstrap.pm

@@ -2,6 +2,8 @@ package NGCP::Panel::Utils::DeviceBootstrap;
 
 
 use strict;
+use warnings;
+
 use Data::Dumper;
 use NGCP::Panel::Utils::DeviceBootstrap::VendorRPC;
 use NGCP::Panel::Utils::DeviceBootstrap::Panasonic;

lib/NGCP/Panel/Utils/DeviceBootstrap/Polycom.pm

@@ -1,8 +1,10 @@
 package NGCP::Panel::Utils::DeviceBootstrap::Polycom;
 
 use strict;
+use warnings;
+
 use URI::Escape;
-use XML::Mini::Document;;
+use XML::Mini::Document;
 use Data::Dumper;
 use Moo;
 use Types::Standard qw(Str);

lib/NGCP/Panel/Utils/GD/Simple.pm

@@ -1,5 +1,8 @@
 package NGCP::Panel::Utils::GD::Simple;
 
+## no critic (RequireUseWarnings, RequirePodSections)
+# disable perlcritic because it's upstream code
+
 =head1 NAME
 
 NGCP::Panel::GD::Simple - Simplified interface to GD library,

lib/NGCP/Panel/View/JSON.pm

@@ -1,6 +1,8 @@
 package NGCP::Panel::View::JSON;
 
 use strict;
+use warnings;
+
 use parent 'Catalyst::View::JSON';
 
 =head1 NAME

lib/NGCP/Panel/View/TT.pm

@@ -1,6 +1,8 @@
 package NGCP::Panel::View::TT;
 
 use strict;
+use warnings;
+
 use parent 'Catalyst::View::TT';
 
 __PACKAGE__->config(

sandbox/api_auth.pl

@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use LWP::UserAgent;
 
 my $ua = LWP::UserAgent->new();

sandbox/api_fix_pbx_devices_profile_names.pl

@@ -1,6 +1,7 @@
-#!/usr/bin/perl -w 
+#!/usr/bin/perl
 use lib qw(/root/VMHost/ngcp-panel/t/lib);
 use strict;
+use warnings;
 
 use Test::Collection;
 use Data::Dumper;

sandbox/banlist.pl

@@ -1,5 +1,6 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 use strict;
+use warnings;
 
 use XML::Mini::Document;
 use Data::Printer;

sandbox/callforwards.pl

@@ -1,6 +1,7 @@
 #!/usr/bin/perl
 
 use strict;
+use warnings;
 
 use Data::Dumper;
 use NGCP::Schema;

sandbox/callforwards_form_starter.pl

@@ -1,6 +1,7 @@
 #!/usr/bin/perl
 
 use strict;
+use warnings;
 
 use Data::Dumper;
 

sandbox/get_inflated_columns_all.pl

@@ -1,6 +1,7 @@
 #!/usr/bin/perl
 
 use strict;
+use warnings;
 
 use Data::Dumper;
 use NGCP::Schema;

sandbox/https_timeout.pl

@@ -1,6 +1,7 @@
 #!/usr/bin/perl
 
 use strict;
+use warnings;
 
 use MIME::Base64 qw/encode_base64/;
 use URI::Escape;

sandbox/moose_role.pl

@@ -1,8 +1,9 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 use lib '../lib';
 #use lib '/home/agranig/projects/HTML-FormHandler-0.40026/lib';
 
 use strict;
+use warnings;
 use Data::Printer;
 
 {

sandbox/repeatable.pl

@@ -1,5 +1,6 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 use strict;
+use warnings;
 
 {
 	package MyForm;

sandbox/repeatable_cfadv.pl

@@ -1,5 +1,6 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 use strict;
+use warnings;
 use lib '../lib';
 
 use NGCP::Panel::Form::SubscriberCFAdvanced;

sandbox/subscribers_emails.pl

@@ -1,6 +1,7 @@
 #!/usr/bin/perl
 
 use strict;
+use warnings;
 
 use Data::Dumper;
 use NGCP::Schema;

sandbox/test-bcrypt-cost.pl

@@ -1,5 +1,6 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 use strict;
+use warnings;
 use v5.14;
 
 use lib '../lib';

sandbox/unzip_keys.pl

@@ -1,5 +1,7 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 use strict;
+use warnings;
+
 use Data::Dumper;
 use File::Slurp qw/read_file/;
 use IO::Uncompress::Unzip qw/unzip/;

share/tools/api_dump.pl

@@ -1,5 +1,6 @@
 #!/usr/bin/perl
 use strict;
+use warnings;
 use LWP::UserAgent qw();
 use JSON qw();
 use DateTime qw();

share/tools/fix_external_id.pl

@@ -1,5 +1,6 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 use strict;
+use warnings;
 
 use DBI;
 use Data::Dumper;

share/tools/generate_invoices.pl

@@ -1,5 +1,6 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 use strict;
+use warnings;
 
 use Getopt::Long qw/GetOptionsFromString/;
 use DBI;

tools_bin/create_testusers.pl

@@ -1,5 +1,7 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 
+use strict;
+use warnings;
 use v5.14;
 use JSON qw();
 use LWP::UserAgent;