TT#20233 Consider empty display_name to update preferences

Change-Id: I92b232d7fbb61fb90fdb40ebf31e08c9adf211aa

lib/NGCP/Panel/Controller/Subscriber.pm

@@ -2532,28 +2532,15 @@ sub edit_master :Chained('master') :PathPart('edit') :Args(0) :Does(ACL) :ACLDet
                 if($is_admin) {
                     $prov_params->{admin} = $form->values->{administrative} // $prov_subscriber->admin;
                 }
-
+                NGCP::Panel::Utils::Subscriber::update_preferences(
-
+                    c => $c,
-                if($form->params->{display_name}) {
+                    prov_subscriber => $prov_subscriber,
-                    my $display_pref = NGCP::Panel::Utils::Preferences::get_usr_preference_rs(
+                    'preferences'   => {
-                            c => $c, attribute => 'display_name',
+                        display_name  => $form->params->{display_name},
-                            prov_subscriber => $prov_subscriber);
+                        cloud_pbx_ext => $form->params->{pbx_extension},
-                    if($display_pref->first) {
+                        #this call will delete the cloud_pbx_ext preference if form param is empty, but form validation shouldn't allow empty value
-                        $display_pref->first->update({ value => $form->params->{display_name} });
-                    } else {
-                        $display_pref->create({ value => $form->params->{display_name} });
-                    }
-                }
-                if(defined $form->params->{pbx_extension}) {
-                    my $pref = NGCP::Panel::Utils::Preferences::get_usr_preference_rs(
-                            c => $c, attribute => 'cloud_pbx_ext',
-                            prov_subscriber => $prov_subscriber);
-                    if($pref->first) {
-                        $pref->first->update({ value => $form->params->{pbx_extension} });
-                    } else {
-                        $pref->create({ value => $form->params->{pbx_extension} });
                     }
-                }
+                );
 
                 my $old_profile = $prov_subscriber->profile_id;
                 my ($profile_set, $profile);