diff --git a/lib/NGCP/Panel/Role/API/HeaderRuleActions.pm b/lib/NGCP/Panel/Role/API/HeaderRuleActions.pm index c317fbe914..24f5e076d2 100644 --- a/lib/NGCP/Panel/Role/API/HeaderRuleActions.pm +++ b/lib/NGCP/Panel/Role/API/HeaderRuleActions.pm @@ -79,12 +79,12 @@ sub check_resource { my ($self, $c, $item, $old_resource, $resource, $form, $process_extras) = @_; my $schema = $c->model('DB'); - unless (defined $resource->{rule_id}) { + unless ($resource->{rule_id}) { $self->error($c, HTTP_UNPROCESSABLE_ENTITY, "Required: 'rule_id'"); return; } - if (!defined $resource->{rwr_set_id} && (defined $resource->{rwr_dp} || defined $resource->{rwr_dp_id})) { + if (!$resource->{rwr_set_id} && (defined $resource->{rwr_dp} || defined $resource->{rwr_dp_id})) { $self->error($c, HTTP_UNPROCESSABLE_ENTITY, "Missing 'rwr_set_id' (when rwr_dp is set)."); return; } diff --git a/lib/NGCP/Panel/Role/API/HeaderRuleConditions.pm b/lib/NGCP/Panel/Role/API/HeaderRuleConditions.pm index 0436bd4132..52180c7bfd 100644 --- a/lib/NGCP/Panel/Role/API/HeaderRuleConditions.pm +++ b/lib/NGCP/Panel/Role/API/HeaderRuleConditions.pm @@ -99,12 +99,12 @@ sub check_resource { my ($self, $c, $item, $old_resource, $resource, $form, $process_extras) = @_; my $schema = $c->model('DB'); - unless (defined $resource->{rule_id}) { + unless ($resource->{rule_id}) { $self->error($c, HTTP_UNPROCESSABLE_ENTITY, "Required: 'rule_id'"); return; } - if (!defined $resource->{rwr_set_id} && (defined $resource->{rwr_dp} || defined $resource->{rwr_dp_id})) { + if (!$resource->{rwr_set_id} && (defined $resource->{rwr_dp} || defined $resource->{rwr_dp_id})) { $self->error($c, HTTP_UNPROCESSABLE_ENTITY, "Missing 'rwr_set_id' (when rwr_dp is set)."); return; } @@ -124,6 +124,7 @@ sub check_resource { $self->error($c, HTTP_UNPROCESSABLE_ENTITY, "Invalid 'rule_id'."); return; } + return 1 unless $resource->{rwr_set_id}; my $rwr_set = $schema->resultset('voip_rewrite_rule_sets')->find({