TT#48198 Remove differences before items array from pagination

Move strange reseller prefetch upper, that looks as not intended copy-paste
Now this query with prefetch will be used for pagination too.

Change-Id: Ie23d2a574e352754d57e1f67d081943aaef50aea

lib/NGCP/Panel/Controller/API/CustomerContacts.pm

@@ -70,10 +70,12 @@ sub GET :Allow {
     my $rows = $c->request->params->{rows} // 10;
     {
         my $contacts = $self->item_rs($c);
+        #todo - is it really necessary? move to item_rs?
+        $contacts = $contacts->search_rs({}, {prefetch => ['reseller']});
         (my $total_count, $contacts) = $self->paginate_order_collection($c, $contacts);
         my (@embedded, @links);
         my $form = $self->get_form($c);
-        for my $contact ($contacts->search({}, {prefetch => ['reseller']})->all) {
+        for my $contact ($contacts->all) {
             push @embedded, $self->hal_from_contact($c, $contact, $form);
             push @links, Data::HAL::Link->new(
                 relation => 'ngcp:'.$self->resource_name,

lib/NGCP/Panel/Controller/API/InvoiceTemplates.pm

@@ -69,10 +69,12 @@ sub GET :Allow {
     my $rows = $c->request->params->{rows} // 10;
     {
         my $items = $self->item_rs($c);
+        #todo - is it really necessary? move to item_rs?
+        $items = $items->search_rs({}, {prefetch => ['reseller']});
         (my $total_count, $items) = $self->paginate_order_collection($c, $items);
         my (@embedded, @links);
         my $form = $self->get_form($c);
-        for my $item ($items->search({}, {prefetch => ['reseller']})->all) {
+        for my $item ($items->all) {
             push @embedded, $self->hal_from_item($c, $item, $form);
             push @links, Data::HAL::Link->new(
                 relation => 'ngcp:'.$self->resource_name,

lib/NGCP/Panel/Controller/API/NcosLevels.pm

@@ -69,10 +69,12 @@ sub GET :Allow {
     my $rows = $c->request->params->{rows} // 10;
     {
         my $items = $self->item_rs($c);
+        #todo - is it really necessary? move to item_rs?
+        $items = $items->search_rs({}, {prefetch => ['reseller']});
         (my $total_count, $items) = $self->paginate_order_collection($c, $items);
         my (@embedded, @links);
         my $form = $self->get_form($c);
-        for my $item ($items->search({}, {prefetch => ['reseller']})->all) {
+        for my $item ($items->all) {
             push @embedded, $self->hal_from_item($c, $item, $form);
             push @links, Data::HAL::Link->new(
                 relation => 'ngcp:'.$self->resource_name,

lib/NGCP/Panel/Controller/API/SubscriberProfileSets.pm

@@ -69,10 +69,12 @@ sub GET :Allow {
     my $rows = $c->request->params->{rows} // 10;
     {
         my $items = $self->item_rs($c);
+        #todo - is it really necessary? move to item_rs?
+        $items = $items->search_rs({}, {prefetch => ['reseller']});
         (my $total_count, $items) = $self->paginate_order_collection($c, $items);
         my (@embedded, @links);
         my $form = $self->get_form($c);
-        for my $item ($items->search({}, {prefetch => ['reseller']})->all) {
+        for my $item ($items->all) {
             push @embedded, $self->hal_from_item($c, $item, $form);
             push @links, Data::HAL::Link->new(
                 relation => 'ngcp:'.$self->resource_name,

lib/NGCP/Panel/Controller/API/SystemContacts.pm

@@ -59,10 +59,12 @@ sub GET :Allow {
     my $rows = $c->request->params->{rows} // 10;
     {
         my $contacts = $self->item_rs($c);
+        #todo - is it really necessary? move to item_rs?
+        $contacts = $contacts->search_rs({}, {prefetch => ['reseller']});
         (my $total_count, $contacts) = $self->paginate_order_collection($c, $contacts);
         my (@embedded, @links);
         my $form = $self->get_form($c);
-        for my $contact ($contacts->search({}, {prefetch => ['reseller']})->all) {
+        for my $contact ($contacts->all) {
             push @embedded, $self->hal_from_contact($c, $contact, $form);
             push @links, Data::HAL::Link->new(
                 relation => 'ngcp:'.$self->resource_name,

lib/NGCP/Panel/Controller/API/Vouchers.pm

@@ -69,10 +69,12 @@ sub GET :Allow {
     my $rows = $c->request->params->{rows} // 10;
     {
         my $items = $self->item_rs($c);
+        #todo - is it really necessary? move to item_rs?
+        $items = $items->search_rs({}, {prefetch => ['reseller']});
         (my $total_count, $items) = $self->paginate_order_collection($c, $items);
         my (@embedded, @links);
         my $form = $self->get_form($c);
-        for my $item ($items->search({}, {prefetch => ['reseller']})->all) {
+        for my $item ($items->all) {
             push @embedded, $self->hal_from_item($c, $item, $form);
             push @links, Data::HAL::Link->new(
                 relation => 'ngcp:'.$self->resource_name,