MT#6693 Remove CF/prefs in case of profile edit

Make sure to clear preferences and CF mappings if they get
unselected in the profile during editing.

lib/NGCP/Panel/Controller/SubscriberProfile.pm

@@ -443,18 +443,47 @@ sub profile_edit :Chained('profile_base') :PathPart('edit') :Does(ACL) :ACLDetac
 
                 $profile->update($form->values);
 
+
+                my %old_attributes = map { $_ => 1 } 
+                    $profile->profile_attributes->get_column('attribute_id')->all;
+
                 # TODO: reuse attributes for efficiency reasons?
                 $profile->profile_attributes->delete;
               
                 # TODO: should we rather take the name and load the id from db,
                 # instead of trusting the id coming from user input?
                 foreach my $attr(keys %{ $attributes }) {
-                    next unless($attributes->{$attr});
+                    my $id = $attributes->{$attr};
+                    next unless($id);
+                    # mark as seen, so later we can unprovision the remaining ones,
+                    # which are the ones not set here
+                    delete $old_attributes{$id};
                     $profile->profile_attributes->create({
-                        attribute_id => $attributes->{$attr},
+                        attribute_id => $id,
                     });
                 }
 
+                # go over remaining attributes (those which were set before but are not set anymore)
+                # and clear them from usr-preferences
+                if(keys %old_attributes) {
+                    my $cfs = $c->model('DB')->resultset('voip_preferences')->search({
+                        id => { -in => [ keys %old_attributes ] },
+                        attribute => { -in => [qw/cfu cfb cft cfna/] },
+                    });
+                    my @subs = $c->model('DB')->resultset('provisioning_voip_subscribers')
+                        ->search({
+                            profile_id => $profile->id,
+                        })->all;
+                    foreach my $sub(@subs) {
+                        $sub->voip_usr_preferences->search({
+                            attribute_id => { -in => [ keys %old_attributes ] },
+                        })->delete;
+                        $sub->voip_cf_mappings->search({
+                            type => { -in => [ map { $_->attribute } $cfs->all ] },
+                        })->delete;
+                    }
+                }
+
             });
             $c->flash(messages => [{type => 'success', text => $c->loc('Subscriber profile successfully updated')}]);
         } catch($e) {