From 4c8db2b91a81a0d43f2252b11d9cd575b29294a0 Mon Sep 17 00:00:00 2001 From: Nico Schedel Date: Thu, 31 Oct 2019 10:13:58 +0100 Subject: [PATCH] TT#68016 selenium: more improvements to get_text_safe() FirefoxExtensions.pm: - exit function when path is not specified - is now able to use css and other paths as well. defaults to xpath Change-Id: I9c47e1ee9ec502c97af25099c09ef6d7a7f007eb (cherry picked from commit 9e245aa636e431b966988c9e081d454c9bd87f01) --- t/lib/Selenium/Remote/Driver/FirefoxExtensions.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/t/lib/Selenium/Remote/Driver/FirefoxExtensions.pm b/t/lib/Selenium/Remote/Driver/FirefoxExtensions.pm index 506e1f5de5..d6f37dc14b 100644 --- a/t/lib/Selenium/Remote/Driver/FirefoxExtensions.pm +++ b/t/lib/Selenium/Remote/Driver/FirefoxExtensions.pm @@ -163,9 +163,11 @@ sub wait_for_attribute { } sub get_text_safe { - my ($self, $path) = @_; + my ($self, $path, $type) = @_; + return unless $path; + $type //= "xpath"; try { - my $element = $self->find_element($path); + my $element = $self->find_element($path, $type); return $element->get_text(); } catch { return 'Element not found';