From 3647bc6c3a448756dd6cfbb38da4c28ebfa7dc6f Mon Sep 17 00:00:00 2001
From: Andreas Granig <agranig@sipwise.com>
Date: Mon, 30 Jun 2014 14:17:46 +0200
Subject: [PATCH] MT#7545 API: Fix removing old groups from subs.

---
 lib/NGCP/Panel/Role/API/Subscribers.pm | 42 +++++++++++++-------------
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/lib/NGCP/Panel/Role/API/Subscribers.pm b/lib/NGCP/Panel/Role/API/Subscribers.pm
index 5832106522..5027708761 100644
--- a/lib/NGCP/Panel/Role/API/Subscribers.pm
+++ b/lib/NGCP/Panel/Role/API/Subscribers.pm
@@ -640,27 +640,27 @@ sub update_item {
                 }),
             );
         }
-        foreach my $group_id(@old_groups) {
-            # remove subscriber from group if not there anymore
-            unless($group_id ~~ [ @new_groups ]) {
-                my $group = $schema->resultset('provisioning_voip_subscribers')->find($group_id);
-                NGCP::Panel::Utils::Subscriber::update_pbx_group_prefs(
-                    c => $c,
-                    schema => $schema,
-                    old_group_id => $group->voip_subscriber->id,
-                    new_group_id => undef,
-                    username => $subscriber->username,
-                    domain => $subscriber->domain->domain,
-                    group_rs => $schema->resultset('voip_subscribers')->search({
-                        contract_id => $customer->id,
-                        status => { '!=' => 'terminated' },
-                    }),
-                );
-                $subscriber->provisioning_voip_subscriber->voip_pbx_groups->search({
-                    group_id => $group_id,
-                    subscriber_id => $subscriber->provisioning_voip_subscriber->id,
-                })->delete;
-            }
+    }
+    foreach my $group_id(@old_groups) {
+        # remove subscriber from group if not there anymore
+        unless($group_id ~~ [ @new_groups ]) {
+            my $group = $schema->resultset('provisioning_voip_subscribers')->find($group_id);
+            NGCP::Panel::Utils::Subscriber::update_pbx_group_prefs(
+                c => $c,
+                schema => $schema,
+                old_group_id => $group->voip_subscriber->id,
+                new_group_id => undef,
+                username => $subscriber->username,
+                domain => $subscriber->domain->domain,
+                group_rs => $schema->resultset('voip_subscribers')->search({
+                    contract_id => $customer->id,
+                    status => { '!=' => 'terminated' },
+                }),
+            );
+            $subscriber->provisioning_voip_subscriber->voip_pbx_groups->search({
+                group_id => $group_id,
+                subscriber_id => $subscriber->provisioning_voip_subscriber->id,
+            })->delete;
         }
     }