TT#39949 Allow faxserversettings to subscriber roles

Change-Id: Ied032bffb79c732add80856453d0799d3541c6d6

lib/NGCP/Panel/Controller/API/FaxserverSettings.pm

@@ -71,7 +71,7 @@ sub relation{
 }
 
 __PACKAGE__->set_config({
-    allowed_roles => [qw/admin reseller/],
+    allowed_roles => [qw/admin reseller subscriber subscriberadmin/],
 });
 
 sub GET :Allow {

lib/NGCP/Panel/Controller/API/FaxserverSettingsItem.pm

@@ -40,8 +40,8 @@ sub journal_query_params {
 
 __PACKAGE__->set_config({
     allowed_roles => {
-        Default => [qw/admin reseller/],
-        Journal => [qw/admin reseller/],
+        Default => [qw/admin reseller subscriber subscriberadmin/],
+        Journal => [qw/admin reseller subscriber subscriberadmin/],
     }
 });
 

lib/NGCP/Panel/Role/API/FaxserverSettings.pm

@@ -12,6 +12,7 @@ use Data::HAL::Link qw();
 use HTTP::Status qw(:constants);
 use JSON::Types;
 use NGCP::Panel::Utils::Subscriber;
+use NGCP::Panel::Utils::API::Subscribers;
 
 sub get_form {
     my ($self, $c, $type) = @_;
@@ -96,8 +97,15 @@ sub _item_rs {
         }, {
             join => { 'contract' => 'contact' },
         });
+    } elsif($c->user->roles eq "subscriberadmin") {
+        $item_rs = $item_rs->search({
+            'me.contract_id' => $c->user->account_id,
+        });
+    } elsif($c->user->roles eq "subscriber") {
+        $item_rs = $item_rs->search_rs({
+            'me.uuid' => $c->user->uuid,
+        });
     }
-
     return $item_rs;
 }
 
@@ -110,6 +118,12 @@ sub item_by_id {
 sub update_item {
     my ($self, $c, $item, $old_resource, $resource, $form) = @_;
 
+    my $billing_subscriber = NGCP::Panel::Utils::API::Subscribers::get_active_subscriber($self, $c, $item->id);
+    unless($billing_subscriber) {
+        $c->log->error("invalid subscriber id $item->id for fax send");
+        $self->error($c, HTTP_UNPROCESSABLE_ENTITY, "Fax subscriber not found.");
+        return;
+    }
     delete $resource->{id};
     my $billing_subscriber_id = $item->id;
     my $prov_subs = $item->provisioning_voip_subscriber;

lib/NGCP/Panel/Utils/API/Subscribers.pm

@@ -20,9 +20,7 @@ sub get_active_subscriber{
         });
     } elsif($c->user->roles eq "subscriberadmin") {
         $sub_rs = $sub_rs->search({
-            'contract.id' => $c->user->account_id,
-        },{
-            join => { 'contract' },
+            'me.contract_id' => $c->user->account_id,
         });
     } elsif($c->user->roles eq "subscriber") {
         $sub_rs = $sub_rs->search({