From 05553d0406bc9577751d16e5cb677181ecfed240 Mon Sep 17 00:00:00 2001 From: Andreas Granig Date: Tue, 15 Oct 2013 10:54:47 +0200 Subject: [PATCH] MT#4413 Remove debugging messages. This even breaks domain creation for PBX. --- lib/NGCP/Panel/Controller/Customer.pm | 4 ---- lib/NGCP/Panel/Controller/Device.pm | 1 - lib/NGCP/Panel/Controller/Login.pm | 1 - lib/NGCP/Panel/Controller/Sound.pm | 1 - lib/NGCP/Panel/Controller/Subscriber.pm | 2 -- lib/NGCP/Panel/Field/SubscriberDestinationSet.pm | 1 - lib/NGCP/Panel/Field/SubscriberTimeSet.pm | 1 - lib/NGCP/Panel/Form/Customer/PbxFieldDevice.pm | 1 - lib/NGCP/Panel/Form/Domain/ResellerPbx.pm | 1 - lib/NGCP/Panel/Utils/Navigation.pm | 5 ----- lib/NGCP/Panel/Utils/Sounds.pm | 1 - 11 files changed, 19 deletions(-) diff --git a/lib/NGCP/Panel/Controller/Customer.pm b/lib/NGCP/Panel/Controller/Customer.pm index 95aa8d1786..7766942662 100644 --- a/lib/NGCP/Panel/Controller/Customer.pm +++ b/lib/NGCP/Panel/Controller/Customer.pm @@ -610,7 +610,6 @@ sub pbx_device_create :Chained('base') :PathPart('pbx/device/create') :Args(0) { my @lines = $form->field('line')->fields; foreach my $line(@lines) { - say ">>>>>>>>>> handle line, subscriber_id=".$line->field('subscriber_id').", account_id=".$c->stash->{contract}->id; my $prov_subscriber = $schema->resultset('provisioning_voip_subscribers')->find({ id => $line->field('subscriber_id')->value, account_id => $c->stash->{contract}->id, @@ -694,7 +693,6 @@ sub pbx_device_edit :Chained('pbx_device_base') :PathPart('edit') :Args(0) { },{ join => { 'config' => 'device' }, }); - say ">>>>>>>>>>>>>>>>>>> ceate NGCP::Panel::Form::Customer::PbxFieldDevice"; my $form = NGCP::Panel::Form::Customer::PbxFieldDeviceEdit->new(ctx => $c); my $params = { $c->stash->{pbx_device}->get_inflated_columns }; my @lines = (); @@ -707,7 +705,6 @@ sub pbx_device_edit :Chained('pbx_device_base') :PathPart('edit') :Args(0) { } $params->{line} = \@lines; $params = $params->merge($c->session->{created_objects}); - say ">>>>>>>>>>>>>>>>>>>>>>> process form"; $form->process( posted => $posted, params => $c->request->params, @@ -737,7 +734,6 @@ sub pbx_device_edit :Chained('pbx_device_base') :PathPart('edit') :Args(0) { $fdev->autoprov_field_device_lines->delete_all; my @lines = $form->field('line')->fields; foreach my $line(@lines) { - say ">>>>>>>>>> handle line, subscriber_id=".$line->field('subscriber_id').", account_id=".$c->stash->{contract}->id; my $prov_subscriber = $schema->resultset('provisioning_voip_subscribers')->find({ id => $line->field('subscriber_id')->value, account_id => $c->stash->{contract}->id, diff --git a/lib/NGCP/Panel/Controller/Device.pm b/lib/NGCP/Panel/Controller/Device.pm index e273c0bd89..0242ee94ec 100644 --- a/lib/NGCP/Panel/Controller/Device.pm +++ b/lib/NGCP/Panel/Controller/Device.pm @@ -240,7 +240,6 @@ sub devmod_edit :Chained('devmod_base') :PathPart('edit') :Args(0) :Does(ACL) :A foreach my $range($c->stash->{devmod}->autoprov_device_line_ranges->all) { push @{ $params->{linerange} }, { $range->get_inflated_columns }; } - use Data::Printer; p $params; $params->{reseller}{id} = delete $params->{reseller_id}; $params = $params->merge($c->session->{created_objects}); if($c->user->is_superuser) { diff --git a/lib/NGCP/Panel/Controller/Login.pm b/lib/NGCP/Panel/Controller/Login.pm index 88bb325baa..d04889fa6e 100644 --- a/lib/NGCP/Panel/Controller/Login.pm +++ b/lib/NGCP/Panel/Controller/Login.pm @@ -111,7 +111,6 @@ sub index :Path Form { $form->add_form_error('Invalid username/password'); } } else { - $c->log->debug(">>>>>>>>>>>>>>>>>>>>>>>> initial get in Login"); # initial get } diff --git a/lib/NGCP/Panel/Controller/Sound.pm b/lib/NGCP/Panel/Controller/Sound.pm index 1340f868fd..b955b3930e 100644 --- a/lib/NGCP/Panel/Controller/Sound.pm +++ b/lib/NGCP/Panel/Controller/Sound.pm @@ -345,7 +345,6 @@ sub handles_base :Chained('handles_list') :PathPart('') :CaptureArgs(1) { NGCP::Panel::Utils::Navigation::back_or($c, $c->stash->{handles_base_uri}); } my @tmph = $c->stash->{handles_rs}->all; - use Data::Printer; p @tmph; unless($c->stash->{handles_rs}->find({ 'handles.id' => $handle_id })) { $c->flash(messages => [{type => 'error', text => 'Sound handle id does not exist'}]); NGCP::Panel::Utils::Navigation::back_or($c, $c->stash->{handles_base_uri}); diff --git a/lib/NGCP/Panel/Controller/Subscriber.pm b/lib/NGCP/Panel/Controller/Subscriber.pm index fc820128ee..1326f5209b 100644 --- a/lib/NGCP/Panel/Controller/Subscriber.pm +++ b/lib/NGCP/Panel/Controller/Subscriber.pm @@ -39,8 +39,6 @@ use NGCP::Panel::Form::Faxserver::Destination; use NGCP::Panel::Utils::XMLDispatcher; use UUID; -use Data::Printer; - =head1 NAME NGCP::Panel::Controller::Subscriber - Catalyst Controller diff --git a/lib/NGCP/Panel/Field/SubscriberDestinationSet.pm b/lib/NGCP/Panel/Field/SubscriberDestinationSet.pm index 1ba3e40191..774e5c2029 100644 --- a/lib/NGCP/Panel/Field/SubscriberDestinationSet.pm +++ b/lib/NGCP/Panel/Field/SubscriberDestinationSet.pm @@ -1,6 +1,5 @@ package NGCP::Panel::Field::SubscriberDestinationSet; use Sipwise::Base; -use Data::Printer; extends 'HTML::FormHandler::Field::Select'; sub build_options { diff --git a/lib/NGCP/Panel/Field/SubscriberTimeSet.pm b/lib/NGCP/Panel/Field/SubscriberTimeSet.pm index b686016d79..8713bf4eb9 100644 --- a/lib/NGCP/Panel/Field/SubscriberTimeSet.pm +++ b/lib/NGCP/Panel/Field/SubscriberTimeSet.pm @@ -1,6 +1,5 @@ package NGCP::Panel::Field::SubscriberTimeSet; use Sipwise::Base; -use Data::Printer; extends 'HTML::FormHandler::Field::Select'; sub build_options { diff --git a/lib/NGCP/Panel/Form/Customer/PbxFieldDevice.pm b/lib/NGCP/Panel/Form/Customer/PbxFieldDevice.pm index 9459116f8c..eedc4b8e2a 100644 --- a/lib/NGCP/Panel/Form/Customer/PbxFieldDevice.pm +++ b/lib/NGCP/Panel/Form/Customer/PbxFieldDevice.pm @@ -21,7 +21,6 @@ has_field 'profile_id' => ( ); sub build_profiles { my ($self) = @_; - print ">>>>>>>>>>>>>> build_profiles\n"; my $c = $self->form->ctx; my $profile_rs = $c->stash->{autoprov_profile_rs}; my @options = (); diff --git a/lib/NGCP/Panel/Form/Domain/ResellerPbx.pm b/lib/NGCP/Panel/Form/Domain/ResellerPbx.pm index 6b71d98ef2..e4f3108076 100644 --- a/lib/NGCP/Panel/Form/Domain/ResellerPbx.pm +++ b/lib/NGCP/Panel/Form/Domain/ResellerPbx.pm @@ -19,7 +19,6 @@ sub build_rwr_sets { push @options, { label => '', value => undef }; if(defined $c) { my $sets = $c->stash->{reseller}->voip_rewrite_rule_sets; - use Data::Printer; p $sets->all; foreach my $s($sets->all) { push @options, { label => $s->name, value => $s->id }; } diff --git a/lib/NGCP/Panel/Utils/Navigation.pm b/lib/NGCP/Panel/Utils/Navigation.pm index 00bb31bbb1..aaa0713948 100644 --- a/lib/NGCP/Panel/Utils/Navigation.pm +++ b/lib/NGCP/Panel/Utils/Navigation.pm @@ -9,8 +9,6 @@ sub check_redirect_chain { # TODO: check for missing fields my $c = $params{c}; - $c->log->debug(">>>>>>>>>>>> check_redirect_chain"); - return if($c->req->uri->path =~ /ajax/); $c->session->{redirect_targets} = [] @@ -22,14 +20,11 @@ sub check_redirect_chain { $back_uri->query_param_delete('back'); delete $c->request->params->{back}; if(@{ $c->session->{redirect_targets} }) { - $c->log->debug(">>>>>>>>>>>> adding $back_uri to list of redirect targets"); unless(${ $c->session->{redirect_targets} }[0]->path eq $back_uri->path) { - $c->log->debug(">>>>>>>>>>>> $back_uri not on top of redirect targets, do add"); unshift @{ $c->session->{redirect_targets} }, $back_uri } # in case you press F5 with a back-uri in the url } else { - $c->log->debug(">>>>>>>>>>>> initialize redirect targets with $back_uri"); $c->session->{redirect_targets} = [ $back_uri ]; } $c->stash(close_target => $back_uri); diff --git a/lib/NGCP/Panel/Utils/Sounds.pm b/lib/NGCP/Panel/Utils/Sounds.pm index 7062869514..98b6fdf2ff 100644 --- a/lib/NGCP/Panel/Utils/Sounds.pm +++ b/lib/NGCP/Panel/Utils/Sounds.pm @@ -55,7 +55,6 @@ sub stash_soundset_list { my $sets_rs = $c->model('DB')->resultset('voip_sound_sets'); if($contract) { - say ">>>>>>>>>>>>>>> we've a contract, limit rs"; $sets_rs = $sets_rs->search({ 'me.contract_id' => $contract->id }); }