diff --git a/lib/NGCP/Panel/Controller/API/Interceptions.pm b/lib/NGCP/Panel/Controller/API/Interceptions.pm index c83b08e45f..1ea4847bab 100644 --- a/lib/NGCP/Panel/Controller/API/Interceptions.pm +++ b/lib/NGCP/Panel/Controller/API/Interceptions.pm @@ -182,19 +182,10 @@ sub POST :Allow { my $num_rs = $c->model('DB')->resultset('voip_numbers')->search( \[ 'concat(cc,ac,sn) = ?', [ {} => $resource->{number} ]] ); - if(not $num_rs->first) { + unless($num_rs->first) { $c->log->error("invalid number '$$resource{number}'"); $self->error($c, HTTP_UNPROCESSABLE_ENTITY, "Number does not exist"); last; - } else { - my $intercept_num_rs = $c->model('InterceptDB')->resultset('voip_numbers')->search( - \[ 'concat(cc,ac,sn) = ?', [ {} => $resource->{number} ]] - ); - if(not $intercept_num_rs->first) { - $c->log->error("invalid local number '$$resource{number}'"); - $self->error($c, HTTP_UNPROCESSABLE_ENTITY, "Number does not exist locally"); - last; - } } # use the long way, since with ossbss provisioning, the reseller_id # is not set in this case diff --git a/lib/NGCP/Panel/Role/API/Interceptions.pm b/lib/NGCP/Panel/Role/API/Interceptions.pm index 943d9a8e6f..0f2838f534 100644 --- a/lib/NGCP/Panel/Role/API/Interceptions.pm +++ b/lib/NGCP/Panel/Role/API/Interceptions.pm @@ -185,21 +185,11 @@ sub subresnum_from_number { my $num_rs = $c->model('DB')->resultset('voip_numbers')->search( \[ 'concat(cc,ac,sn) = ?', [ {} => $number ]] ); - if (not $num_rs->first) { + unless($num_rs->first) { $c->log->error("invalid number '$number'"); $self->error($c, HTTP_UNPROCESSABLE_ENTITY, "Number does not exist"); return; - } else { - my $intercept_num_rs = $c->model('InterceptDB')->resultset('voip_numbers')->search( - \[ 'concat(cc,ac,sn) = ?', [ {} => $number ]] - ); - if(not $intercept_num_rs->first) { - $c->log->error("invalid local number '$number'"); - $self->error($c, HTTP_UNPROCESSABLE_ENTITY, "Number does not exist locally"); - return; - } } - my $sub = $num_rs->first->subscriber; unless($sub) { $c->log->error("invalid number '$number', not assigned to any subscriber");