CallForward: Fix race condition problem with destinations being
populated before sourceset specific store has been created
Change-Id: I37e86e21102bce433235ac7050e8a27103a66779
What has been done:
- CallForward: Add "Own Phone" only, if no mappings exist for online
grid/state
- Fixed duplicate rendering of "own phone" if more than one cft
destinationset
- Fixed issue with mapping not being deleted when last destination
in grid was deleted
- Get the timeout from 'cft_ringtimeout' field instead of hardcoding
Change-Id: I0f64ee70c2ff12578223bfb033c9c87a71578a41
What has been done:
- "CallForward: Prevent rendering of the cft-destinations, if
mappings of cft and cfu exists together"
- Implemented a new check based on findings in: "CallForward: Check
in online grid/state that all cfu destination sets are called"
Change-Id: I3c2493a1449f7d324ce5d9e3ad880f5a0189eb79
- CallForward: Ensure the consistency of destination type during
deletion of destination "own phone"
- CallForward: Remove "Own Phone" if only cfu mapping exists
- CallForward: Remove "Own Phone" from busy and offline grid/state
Change-Id: I76eb9c634977ecac6d06788c67c963a2ce23822b
What has been done:
- #21450 CallForward: Fix reference problem with DestinationSets
which are changed globally over all SourceSets
- Fix issue with last destination removal in grid not resulting in
any writing to API (remains undeleted)
Change-Id: Ieb1fd6d05a050985b63dca18fabd92df2b9d1d87
What has been done:
- Close call panel
- End call (call.end(...))
- Cleanup local media (stream.stop())
- Cleanup remote media (stream.stop())
What is remaining from #20679:
- Add remote media stream to view model. Will solve as part of #20678.
Change-Id: I4b6f1f09ce53048918918f8c9aee1003c6d54738
Call: Show ended state of the call panel if caller aborts the call
- Show ended reason
- Only show close button (that closes the panel)
- Include css styles from hherzog's previous commit
Call: Implement decline button functionality
- Add remote media stream to view model
(will complete the rest as part of the task specific branch)
Change-Id: I50a1beeb57e0d74f0a82e22a2414ff4e9a6764ca
What has been done:
- Add "loading dots" animation for easy reuse
- Quick login window fix, to prevent closing when pressing ESC
- Remove rtc/ from .gitignore
- Show buttons for accepting the call
- Show decline button
- Show callers number
- Change color of the title
- Show label with text "Incoming audio/video call from ..."
Testing:
- Dev helper buttons can be found in patchset 5
Change-Id: I1e61abaabc788c9104178ab834533d4bef7517ec
What subtasks have been done:
- 20689: CallForward: Merge latest changes
- 20628: CallForward: Update destinationsets in all affected
grids/states
- 20631: CallForward: Remove superfluous destinations from duplicate
destinationset names
- 20688: CallForward: Discussion about the overall approach and
common understanding
Change-Id: Id1b1c69c8c943ffee777ed44abd2282c66f3e1ad
- sourceset tabs and related vm data values generated dynamically from
/api/cfsourcesets/ response
- updating sourcest name is now peristent
Change-Id: I579d9aff76b55cd0386c06f79672775b56333508
What has been done
1. Handle read and write rendering of all non-number destination
types, parsing sip-uri values from API to human readable types
2. Implement ability to add new destinations, also non-number types
3. Move "first ring" section to grid
4. Implement persistent reordering of destinations in grid, handling
both changes in termination status, priority order and
destinationset
5. Implement color indication of what destinations are terminated
(inactive/active) and not
6. Implement logic for handling Ajax PATCH request based on
destinationset
7. Some cleanup/refactoring, including change names for CallForward
store and models, clean up models, defaultValue added where needed
8. Render combinations of destination types and timeouts correctly
9. Implement cft/cfu rules. Currently you can't reposition it
10. Implement dynamic handling of labels in grid
Change-Id: I9f9252412d5ae921b8a4160a51b0acec8e8ea179
What has been done:
1. Implement successful write of destinations on store.sync(), using
beforesync event and custom ajax requests based on id of
destinationsets
B. Investigate PATCH method for updating items with use of curl
(will use this to base building of model in options["update"] on)
A. Make sure we are able to fire beforesync event
D. Add all necessary values to store for "add new destination"
button controller logic ("announcement_id", "destination",
"priority":, "simple_destination": "timeout" at least)
D1. If store.last is undefined, create a new destinationset
D2. Else if store.last is undefined, use store.last to get values for
new model
E. Create the "meat" for this cfStoreBeforeSync function
1G. Make sure removing destination works with the API properly
3A. Sourceset grid write data to API
3B. Sourceset write after adding source to empty grid
6. Disable ability to change titleset name for now, as we don't
have specs for how to handle this. Currently, changing the name of
the sourceset would mean that it would disappear in next reload,
and as we can't rely on localStorage for persistence of
sourceset_1 (List A), for example, we have no way of handling this
unless we change the logic here. I've proposed to handle this as
part of #17651, documented my concerns in ticket, and will discuss
in next sync-up
7. Cleanup and last changes and testing
Change-Id: Ic5eed663c032f38b5cf5c34effd86af32550ddde
What has been done:
1. Fix "CB only" bug with notification box with 'showmessage'
event always moving a little to the right for eache subsequent
success message (showmessage state true) called inside
store.sync() method
Change-Id: I28716f0054331cf9bf124abb00f08825d9950ca7
What has been done:
1. Update endpoints mapping, as callforwards has sources and times,
but no sourceset or timeset names. Need to perform an ajax
request in controller to get sourceset name for current cf type
for subscriber
+--------------+---------------+------+-------------------------+
| Submodule | Grid | CRUD | Endpoint |
+--------------+---------------+------+-------------------------+
| Alw/Aft/Comp | Timeset | RU | /api/cftimesets/ |
| Alw/Aft/Comp | Sourceset | RU | /api/cfsourcesets/ |
| Alw/Aft/Comp | Onl/Offl/Busy | CRUD | /api/cfmappings/ |
| Alw/Aft/Comp | Onl/Offl/Busy | CR | /api/cfsourcesets/ |
| Alw/Aft/Comp | Onl/Offl/Busy | CR | /api/cftimesets/ |
| Alw/Aft/Comp | Onl/Offl/Busy | CRUD | /api/cfdestinationsets/ |
+--------------+---------------+------+-------------------------+
(timeset/sourceset in onl/off/busy CRUD depends on UI implementation)
2. Implement main store, proxy and controller for destination grids
3a. implement into view for displaying data based on requested data
3b. BUG fix. Duplicate destinations when loading several submodules
4. CANCEL button text does not get reverted back to ADD NEW
DESTINATION after adding new from empty list, fix
5. Make timeout field editable
6. For busy and offline, don't display "first ring" section
7a. Read and display sourceset and timeset API data
7b. BUG fix. List A grid is not showing
8. Fix "Voicemail" rendering
9. BUG fix. emptyText not showing for CallForwardMainGrid.js grids
10. Added box-shadow for core-container and cards
Change-Id: I1112969673296150e20a3add427fce81473d7060
Previous implementatation was still using dummy data.
With this changes the integration of JWT iin the client is completed.
Change-Id: I4dde4fc209ec878d87e6477d70cf7a5b02fb9b34
What has been done:
1. When not connected to API, the toggle icon labels have wrong
color, should be reverse. Works when API is connected. Investigate
2. Implement ability to edit the reminder even if it's inactive
3. Grab inactive/active status from API instead of creating dummy
value in model
4. Remove seconds in the dropdown and input
5. Add save button and logic
6. Creation of default reminder in case does not exist for the
user
Change-Id: Id224109af714532f576b870a3624099f8a6ee972
What has been done:
1. Groups should also have Primary/Alias and Seats
a. Implement in view, model and .json
b. Implement in gridfilter
What is remaining(?):
2. Button text wrong some times - Not able to reproduce
Change-Id: Ia3e10f4f736857ae155be4c8569ea2130a67ac73
What was done:
1. Tooltip for toggle should say "Allow everything except..."/"Block
everything except..." depending on current value
2. Remove theme roller module from menu
3. Also fix tooltip for reminder module toggle button
Change-Id: Ia2435f6296d026afca4c7f1543b7f2eaa9e9cb72
What has been done:
1. identify in API the endpoints required to perform crud operations
for each of the submodules
1a. draw out all submodule endpoints
1b. verify endpoints with use of curl
1c. sync with Carlo on his feedback about data structuring
2. Fix bug with "List B" panel appearing by on "Always" when
"Everybody" selected
Change-Id: I7248d682dcb58cb4c23d449c31f2ea45c91f4e42
What has been done:
1. Fix cancel button in contacts not hidden after creating a new team
2. Implement consistent button ordering
a. CONVERSATIONS
- top bar: new fax - new sms - new call
- card bottom icons: addressbook - sms - chat - call - play
b. CALL FORWARD
- sourceset grid: change title - add new source
- change title active: cancel (needs to be added) - save
c. CALL BLOCKING
- card bottom icons: delete - toggle enable
d. PBX
- card bottom icons: cancel - delete - edit/save
- devices edit box bottom icons: cancel - delete - save
Change-Id: Iaf6375a61e9aaa36ec8ce1766a774a0fe4e7abeb
What has been done:
1. Tooltip for new messages/chat are NaN. Fix
2. Fix issue with new messages disappearing after interval 1 min
Change-Id: Ic0aaf1789f16b144fc9b3f8a67d7581c50029751
Carlo
Robert Axelsen
Hans-Peter Herzog