Trickle ICE candidate updates were not sent through
to kamailio/rtpengine. This was happening because
there was not ICE configuration.
Change-Id: I2a3ae1ab92ac9d6e766bd46915930fd553a6ff26
(cherry picked from commit ed162e8e56)
(cherry picked from commit 4733b2c363)
Migrating from ^8.10.0 to 9.14.0 had breaking changes.
* We moved to a flat configuration and changed the amended the script to run lint.
* We upgraded all eslint relevant libraries/plugins.
* We opened another ticket to review all the console.log/debug/info present in the repo.
Change-Id: Ie1e2c1ef49fc09cddbd9cc639505a1a65917bd35
(cherry picked from commit e935071c95)
(cherry picked from commit 7f207e4462)
The PBX seat page was crashing because v2 calls always return
unauthorized. An investigation is ongoing to determine whether
NCOS seat should be accessed by subscriber. In the meantime,
errors are handled gracefully so the user can continue using
the app.
Change-Id: Ie4ce6c7970815b448f406bb5e64aeefda348aeed
(cherry picked from commit f34d8e153d)
(cherry picked from commit 6c2102466e)
- Verify and correct route access for admin-only CSC pages
- Update route guard logic to support:
* User role (admin / non-admin)
* Exact match on user profile attribute
* Presence of one or more profile attributes
* Required licenses (all must exist)
* Exact platfom feature
* Exact capability match
- Ensure route guards match menu visibility restrictions
- Document route guards and menu visibility logic
- Note: for fax settings, we use the extra variable
`isFaxServerSettingsActive` to determine whether the toggle
in the fax server menu should be on or off.
Change-Id: Id60a0e8b2145701ed4ae52d0859da46172076a89
(cherry picked from commit 2b46170467)
(cherry picked from commit 1a3b881c51)
Removed `&` from symbols to avoid invalid
characters in generated passwords
Change-Id: Iea37ad73e22df4d35b3834e713308a9b0605c252
(cherry picked from commit 2c548413a4)
(cherry picked from commit fd0f8d8c9c)
Listed here the changes:
- change properties accessed directly
from state with computed properties
that handles null cases
- Fix typos for subcriberListState
and subcriberListError
- Improve route watcher in
CscPagePbxDeviceDetails
- add a method to load only thumbnails
instead of full set of data for
the device profiles to improve
performance.
- removed 1000 rows for loadProfiles()
as it was too slow. We expect max 150
devices so it was set to 300 rows.
Note, more refactoring will be needed.
Change-Id: Iefe0328052174f0bb93f8cdbae59f77257592592
(cherry picked from commit d8c1f097cc)
(cherry picked from commit 7d6446a2e0)
Two switch buttons added to group details as for seats.
These buttons update play_announce_before_call_setup and play_announce_before_cf preferences.
Change-Id: I230b9a8d62b34a2e013a326ad4d50403b82d824a
(cherry picked from commit 6e70eb898b)
(cherry picked from commit 435d76b47b)
CSC-UI has been changed so that, during a blind transfer, the
Referred-By header is customized with local identity URI.
Without this customisation, jssip puts blindly the subscriber username
which is not always what kamailio proxy expects.
Having correct Referred-By header is important because kamailio proxy
uses this header in order to identify the transferor in a blind transfer call.
In particular, kamailio proxy checks if Referred-By matches custom header
P-Xfer-Firstcall-Callee-To, in this case B is recogized as transferor.
Change-Id: If149b34c16a5dc13116f8fea9a6d8046498753cd
(cherry picked from commit ad870c279e)
(cherry picked from commit f5fb9750c7)
App was crashing when user was refreshing
page on page /pbx-configuration/device/${id}
This happens because the logic to load all
necessary resources is a bit tangled. This
commit attempts to tidy up things without
inserting breaking changes.
Change-Id: I868678fcc6ed181697a5f3825d41940429785375
(cherry picked from commit e314c96c3c)
(cherry picked from commit 0318ccab00)
Revert original code and just add missing
header.
Change-Id: If109b4ecc3810aad7cae5b8dc1b0dd87a7d6e325
(cherry picked from commit 3daeb267bb)
(cherry picked from commit 1f523513e1)
/api/faxes endpoint was returning a 422 error
Uprocessable content. This commit
amends the payload to match what is in the
APIv1 documentation (old docs)
Change-Id: Ib8d9c0ec41e1e1a18bbe503db711b55e5f66e050
(cherry picked from commit 47d4627980)
(cherry picked from commit c91d1bfc82)
This commit fixes the following bugs:
* On refresh The PBX Seat Page crashes because the
seat id in the state goes back to null.
* PBX Seats and Groups pages' reactivity is not
working, in fact the components are not refreshed
upon manually changing the group or seat id in the URL.
* When user changes a destination that belonged
to admin user the app was getting stuck in an
infinite loop now we show the permission error.
* When user deletes a CF previously set by the admin,
or a mapping containing the above, the app was crashing.
We now delete the mapping and show a warning informing
the user if the associated destination set belongs
to admin.
* When seat user creates a new CF all CF previously
created by admin were disappearing because only
destinations filtered by csc users were retrieved
after the creation fo a new mapping instead of all
the available destinations.
* Time set created in admin were visualised as "...".
We now show the string "Custom time set" and show
a formatted summary of the details on click.
* Not all timesets were shown in call forward page
because of the missing parameter "all: true" in
the getList config. getList or pagination in csc
needs proper reviewing.
Change-Id: I06faa0a1fd0db003cb7ed81328147897386830ff
(cherry picked from commit 12043c549d)
(cherry picked from commit 5e98e0cf61)
Due to some changes on api v2, we cannot pass a parameter that doesn't exist to api.
In csc, we put the lang parameter in each call but it returns an error when using api v2.
So in the case we use api v2 we just removed this parameter.
Change-Id: Ib9e5decc67178d65626a285688e41b88b16e0b03
(cherry picked from commit 51bc01af96)
(cherry picked from commit 44d1346a91)
Add translations for the error message shown when license is invalid
and fix a small bug in the router guard, in fact we were checking
the licenses list against the attribute which are different values.
Change-Id: Ic595f731cd770f932e30fe9b649d68bcc3af7119
(cherry picked from commit f301d02b3f)
(cherry picked from commit 7002e660ce)
In the last version mr12.5 we increased the security standards for the subscriber's password.
Now it is mandatory to have:
* password length min 12 chars
* must have at least 3 digits
* must have at least 3 lowercase letters
* must have at least 3 uppercase letters
* must have at least 3 special chars
In this review we adapt the random password generator in the CSC.
Change-Id: I8f257e34f7df8c99ef776ea9262fa18c32aef4da
(cherry picked from commit abf1d52fe7)
(cherry picked from commit 186458d581)
We have introduced the concept of licenses which can be active
or inactive (all active licenses are stored in the array "licenses"
-GET 'api/platforminfo'). This means that a service (e.g. fax)
can be activated, but the license to use it could be active or
inactive. If the latter is true, the user is not allowed to
use the service in fact the backend returns a 403 - Invalid
license when the relevant endpoints are called.
* Before this commit we were retrieving the fax services as
part of the login phase, but with the new licenses logic the
existing flow was broken by a 403 for those users with inactive
fax license and it was impossible to login into the platform.
With this commit we amend getUserData() to wrap the call to
retrieve the fax settings in a statement that checks if the
fax licence is active.
* We edit the "Invalid license" message returned by the backend
with a more user-friendly text. The text is showed in a
small banner on top of the page every time the user opens
a page that is not supposed to access because the relevant
license is inactive.
* We remove some unused code in CscLayoutMain.vue
* v-if moved before class to silence warning in AuiMobileAppBadges
Change-Id: Ie7831e0024475c3a5aa8acf3874e6eda442fc9a2
(cherry picked from commit 98eee9c1ff)
With the creation of the Customer Preferences Page we add the possibility for the subscriber's administrator to view and edit some of the preferences that are applied customer's wide.
We also refactored $errMsg, the function that handles validation error messages globally.
The reviewed function displays the error text based on the errorMessages methods in src/validators/index.js
Change-Id: Ic9a1b2eab9b71255026447a690d3426097cbaf93
When testing the bugfix mentioned in the ticket I found the below
bugs and proceeded with the fixes:
- cscCfGroupConditionDate: added try/catch to handle better errors.
Before the fix the component was gettign stuck on loading when
the backend was returning an error
- refactored post() in common.js to reflect sipwise js policy
- actions.js: fixed bug to pass correct timeSetId in the cfmapping
PATCH requests. Before the fix we were passing an object with all
the data of the new timeset rather than the id only and the backend
was complaining.
Change-Id: I7bfabaf7a1a2aea8c6034de0d8f76e2f90633cdb
sip username is created removing whitespaces and special chars from
the name input. This logic was handled by a lodash method. This commit
replaces the mentioned method with a custom function that mirrors the
logic we use in ngcp-admin to handle the pbx group creation.
The new method is less aggressive in fact it allows the use of
underscores and doesn't dash numbers. As part of the change we also
expose sip username as read-only field in the edit pbxGroupDetails
page.
Change-Id: I086b3a7011e47d8f542ac92f42bd923c38630331
- Changing list view to 8 rows with 3 columns.
- Preferences/Edit are now open in a separate page.
- Adding the new 4 preferences ( - Admin Name/ Disable web GUI/ User config priority over-provisioning/FW upgrade disable) together with the existing parameters.
Change-Id: Iae92c3313c592f7662587f52d0d4c9293ba41a97
Add a new "force CLI" checkbox to the add pbx seat form.
If the checkbox is ticked, "?create_primary_acli=false" is
added to the request URL params when creating a subscriber.
Removes customer_id params from createSubscriber() as it
seems to be a leftover from old code.
Change-Id: I58e287030bc740659415f888d8ed42f5ab6894d1
- remove some spaces and some code in comment
- change icon for upload
- adding an error for the number when it is duplicated in add/edit pages
Change-Id: I3f1ca01e70a1b3bcf068bdea3c5cc98668f74c9f
With this improvement the customer administrator can configure
the call forwards of subscribers that belong to it.
The setting can be done in the CSC Seat page inside the
PBX Configurations.
Change-Id: I3dd4c7ba7e34725705da69bdf28fae93a379aee0
Debora Crescenzo
Nouhaila Idrissi Zouggari
Hugo Zigha
Alessio Garzi
Marco Capetta
CORP\franci11