ngcp-csc-ui

Author SHA1 Message Date

Author	SHA1	Message	Date
Debora Crescenzo	3c120efff0	MT#64726 Refactor customer preferences actions - Convert all actions from .then()/.catch() chains to async/await - Extract savePreference() helper to centralise error handling and state commits, avoiding repetition across every action - Extract updateBooleanPreference() helper. It covers the following scenarios: * new value is false: remove PATCH property in DB * new value is true: add PATCH property in DB * new value is true AND the value already exist in the customer preferences: replace PATCH to amend property in DB (added to avoid regression introduced by previous code, which saved a property as false instead of removing it)s - Add proper add/set/remove logic to updateBlockInList, updateBlockOutList and updateBlockOutOverridePin: previously all three always called setCustomerPreference regardless of whether the preference existed or was empty - Split logic to add, remove and edit customer preferences Change-Id: Ie419de31631b9ef1b06653446dfbe1a33a10c225 (cherry picked from commit `58e7a88272`) (cherry picked from commit `0511581933`)	3 months ago
Nouhaila Idrissi Zouggari	abf978ad11	MT#61209 Upgrade to eslint 9.14.0 and add JS Policy's rules Migrating from ^8.10.0 to 9.14.0 had breaking changes. * We moved to a flat configuration and changed the amended the script to run lint. * We upgraded all eslint relevant libraries/plugins. * We opened another ticket to review all the console.log/debug/info present in the repo. Change-Id: Ie1e2c1ef49fc09cddbd9cc639505a1a65917bd35 (cherry picked from commit `e935071c95`) (cherry picked from commit `7f207e4462`)	7 months ago
Nouhaila Idrissi Zouggari	0cb6554966	MT#58743 Create a new Pbx Configuration -> Customer Preferences page With the creation of the Customer Preferences Page we add the possibility for the subscriber's administrator to view and edit some of the preferences that are applied customer's wide. We also refactored $errMsg, the function that handles validation error messages globally. The reviewed function displays the error text based on the errorMessages methods in src/validators/index.js Change-Id: Ic9a1b2eab9b71255026447a690d3426097cbaf93	2 years ago

Debora Crescenzo

MT#64726 Refactor customer preferences actions

- Convert all actions from .then()/.catch() chains to async/await
- Extract savePreference() helper to centralise error handling and
  state commits, avoiding repetition across every action
- Extract updateBooleanPreference() helper. It covers the following
  scenarios:
  * new value is false: remove PATCH property in DB
  * new value is true: add PATCH property in DB
  * new value is true AND the value already exist in the
    customer preferences: replace PATCH to amend property in DB
    (added to avoid regression introduced by previous code, which
    saved a property as false instead of removing it)s
- Add proper add/set/remove logic to updateBlockInList,
  updateBlockOutList and updateBlockOutOverridePin: previously all
  three always called setCustomerPreference regardless of whether the
  preference existed or was empty
- Split logic to add, remove and edit customer preferences

Change-Id: Ie419de31631b9ef1b06653446dfbe1a33a10c225
(cherry picked from commit 58e7a88272)
(cherry picked from commit 0511581933)

Nouhaila Idrissi Zouggari

abf978ad11

MT#61209 Upgrade to eslint 9.14.0 and add JS Policy's rules

Migrating from ^8.10.0 to 9.14.0 had breaking changes.
* We moved to a flat configuration and changed the amended the script to run lint.
* We upgraded all eslint relevant libraries/plugins.
* We opened another ticket to review all the console.log/debug/info present in the repo.

Change-Id: Ie1e2c1ef49fc09cddbd9cc639505a1a65917bd35
(cherry picked from commit e935071c95)
(cherry picked from commit 7f207e4462)

Nouhaila Idrissi Zouggari

0cb6554966

MT#58743 Create a new Pbx Configuration -> Customer Preferences page

With the creation of the Customer Preferences Page we add the possibility for the subscriber's administrator to view and edit some of the preferences that are applied customer's wide.

We also refactored $errMsg, the function that handles validation error messages globally.

The reviewed function displays the error text based on the errorMessages methods in src/validators/index.js

Change-Id: Ic9a1b2eab9b71255026447a690d3426097cbaf93

3 Commits (3c120efff0f374456f55238d4360b378b83311c4)