Remove the use of apiv2 for the customer phonebook
requests as teh endpoint is not available on mr12.5.x.
NGCP-Flow: mr12.5
Change-Id: Icebc58dac2a49f015a05b0f9d74e90c498ce4a9b
(cherry picked from commit 336456d196)
removeCustomerPhonebook was called with wrong argument.
NGCP-Flow: mr12.5
Change-Id: Ic55e2038b7556e1fd4bd75bb0f763268616fc6c5
(cherry picked from commit 722c30df44)
apiGet and apiPost assign the full options
object to the variable path
rather then options.path
In this commit we fix the bug.
Change-Id: I2379c4038a7fb70183ad2c6a25252413895122ad
(cherry picked from commit 38c2f37c1a)
(cherry picked from commit 3a337bb599)
- Convert all actions from .then()/.catch() chains to async/await
- Extract savePreference() helper to centralise error handling and
state commits, avoiding repetition across every action
- Extract updateBooleanPreference() helper. It covers the following
scenarios:
* new value is false: remove PATCH property in DB
* new value is true: add PATCH property in DB
* new value is true AND the value already exist in the
customer preferences: replace PATCH to amend property in DB
(added to avoid regression introduced by previous code, which
saved a property as false instead of removing it)s
- Add proper add/set/remove logic to updateBlockInList,
updateBlockOutList and updateBlockOutOverridePin: previously all
three always called setCustomerPreference regardless of whether the
preference existed or was empty
- Split logic to add, remove and edit customer preferences
Change-Id: Ie419de31631b9ef1b06653446dfbe1a33a10c225
(cherry picked from commit 58e7a88272)
(cherry picked from commit 0511581933)
* Implemented priority flow as sort -> normalize to 0..n-1
across fetch/create/edit/remove
* On creation handles priority incrementally
* On edit, arranges and normalizes (if needed) priority values
* Enforced the same move rules in store action (moveDestination)
to block invalid reorders.
* Removes references to LocalSubscriber
* Fixes unit tests
Change-Id: Ib64cc30ea75141692085ec38df5c528565389469
(cherry picked from commit 38d6e2089c)
(cherry picked from commit f0d78c695f)
The CF to Local Subscriber feature has been removed
in ticket MT#59011 but never deleted from CSC.
Change-Id: I1ed32c4db3e4ee2e0be8ab2218efe0ec48c3a098
(cherry picked from commit 8c51d8f041)
(cherry picked from commit 89d30653fd)
Add the query param ?create_primary_acli=false
to PATCH /api/numbers/{id} as default
behaviour.
Change-Id: Ib05602ed7850a19c4a984576fd3645ec158c4b0d
(cherry picked from commit 7cb3addfb9)
(cherry picked from commit f3ef723269)
Our nightly tests flagged the fact that
the feature was unstable and unrealiable.
Changes:
* Extract subscriber phonebook api and state
* Change direct use of http in the sub-phonebook
method to use the relevant method in common.js
* Simplify logic to PATCH single properties
with a unique PUT in the Phonebook entry form
* Amend getList, handleResponseError and
put to allow use with API v2 endpoints
* Amend translations and methods to replace
"phonebook" with "phonebook entry" where
necessary
Change-Id: I189d45fe426a1ded400a251d7efdfa72f76f9061
(cherry picked from commit ff40864da0)
(cherry picked from commit 8eb8cfb10d)
- Keep callNumberInput getter returning full input for display purposes
- Use callNumberNormalized getter to strip domain before making calls
- Add callNumberNormalized to component's mapped getters
- Update startCall validation to use normalized number
Change-Id: I4172a4f426bf7f827e3ff717a901b8a64f4264d1
(cherry picked from commit afd3e09d55)
(cherry picked from commit 85061c3081)
This reverts commit b70ea928dd.
NGCP-Flow: mr12.5
Reason for revert: The new Quasar is struggling to resolve assets path's and crashes the app.
Change-Id: Id4d53d9f660c02c77642c0e5feb455caa0b56a81
(cherry picked from commit 69c8b370f8)
The custom announcements were not showing in
the CF menu under the PBXGroup section
because the action to load the announcements
was missing from the mounting hook.
Change-Id: I5813f2ce4471aa5a51ebc08ed3cdc08bde16b931
(cherry picked from commit acd9d84724)
(cherry picked from commit af96841727)
Trickle ICE candidate updates were not sent through
to kamailio/rtpengine. This was happening because
there was not ICE configuration.
Change-Id: I2a3ae1ab92ac9d6e766bd46915930fd553a6ff26
(cherry picked from commit ed162e8e56)
(cherry picked from commit 4733b2c363)
This update introduced many breaking changes.
Listed here the most important ones:
* quasar.conf.js file has been renamed
quasar.config.js.
* Quasar v4 replaced the old /src/index.template.html
with a new /index.html at the root of the project.
The special comment <!-- quasar:entry-point -->
is used to inject scripts/styles automatically.
* Use setupMiddlewares instead of onBeforeSetupMiddleware.
* proxy is now an array of proxy config objects.
* Dropped support for Vuex. We can still use Vuex as any
Vue plugin, but we have to manage everything (installing the
store, no store parameter in boot files, etc.).
We'll migrate to Pinia asap.
* Updated postcssrc according to docs
Change-Id: I585a3e2d17f666d9ca2773fa446d644f0fc201a2
(cherry picked from commit 72d36d22ab)
(cherry picked from commit b70ea928dd)
* Run yarn outdated and run through the list
to upgrade all libs but @quasar/app-webpack
and related libs. this will be done in a
separate commit.
* Remove parseuri because it is not used anywhere
in fact the project has a custom SIP URI parsing
implementation in sip-uri-parse.js.
* Remove jwt-decode because it is not used in fact
JWT decoding is manually implemented using native
browser functions.
* Updating to glob@11 where the glob.sync() method
is no longer accessible, but requires to be
imported directly from globModule.
* Remove eventsource:
- No Direct Usage: I could not find any direct imports,
requires, or uses of the eventsource package or
EventSource APIs in the codebase.
- Security Updates: The package was updated on
January 11, 2023, from version 1.1.1 to 2.0.2 as
part of a security updates (MT#56339).
- No Indirect Dependencies: The yarn why eventsource
command confirmed that no other packages depend on
eventsource.
- No Build Process Integration: I didn't find any
references to eventsource in the build config files
or webpack configurations.
- No SSE Implementation: While we handle media streams
for calls, in my understanding they use WebRTC or
similar technologies, not Server-Sent Events which,
in my understanding, is what eventsource is designed
for.
* Remove eslint-plugin-standard as it's not longer needed
by standard and eslint-config-standard.
* Upgrading eslint-plugin-vue required adding
vue-eslint-parser as a peer dependency and
required some changes to since new warnings.
Change-Id: I8f582275ae344f0ede7520136deba30c4d94ffd7
(cherry picked from commit bc75777bae)
(cherry picked from commit e896edfb38)
Migrating from ^8.10.0 to 9.14.0 had breaking changes.
* We moved to a flat configuration and changed the amended the script to run lint.
* We upgraded all eslint relevant libraries/plugins.
* We opened another ticket to review all the console.log/debug/info present in the repo.
Change-Id: Ie1e2c1ef49fc09cddbd9cc639505a1a65917bd35
(cherry picked from commit e935071c95)
(cherry picked from commit 7f207e4462)
* Adds new messages for CE users to replace the
"No Calls, Voicemails or Faxes found" greeting
and "Calls, Faxes, VoiceMails" submenu item with
"No Calls or Voicemails found" and "Calls, VoiceMails"
respectively
* Adds translations for both the "No Calls or Voicemails found"
and "Calls, VoiceMails" messages
* Fixes typo in the word occurred on en.json
* Fixes some French and Spanish translation errors
* Fixes the call Cost formatting under CscCallItem.vue
Change-Id: I0da1dbf78ea1a609a0e1861fa1c14ee41a41d563
(cherry picked from commit 4d92ef013e)
(cherry picked from commit 93bd12d00f)
The issue was caused by a conditional(v-if=!menuMinimized) inside the <q-toolbar>.
menuMinimized property controls whether the side menu is collapsed
or expanded and affects multiple components.
When it changes (on hover or pin toggle), the layout width updates,
which can trigger the ResizeObserver.
Using v-if was recreating/destroying the element each time,
causing unnecessary layout recalculations.
The solution is to replace it with v-show="!menuPinned" which keeps
the element in the DOM (only toggles display), preventing extra
ResizeObserver triggers and making transitions smoother.
Change-Id: I2e544bb0451cc6a17a4bbeaf482ce678173adcd4
(cherry picked from commit 69e43c898e)
(cherry picked from commit a9e8b47641)
This commit disables subscriber phonebook in CE platforms
as the header manipulation and phonebook are only pro/carrier
features.
Change-Id: Icb5ceec69f675fbac61e9daf81698c81d0c8c28d
(cherry picked from commit 31fa24a8c9)
(cherry picked from commit 67073ac0be)
Fixed an issue where the component tried to access the `id` property
of `this.groupSelected` when it was undefined. This happened because
the state gets cleared on refresh, and the component didn't have a
check to reload the necessary resources.
- Added check to ensure resources are reloaded if state is cleared
- Prevent accessing `id` of undefined in the component
Change-Id: Ib6b669df87d255cf174254b32fa1c451d0901f73
(cherry picked from commit 4e72e67697)
(cherry picked from commit 512bc6d4a7)
The PBX seat page was crashing because v2 calls always return
unauthorized. An investigation is ongoing to determine whether
NCOS seat should be accessed by subscriber. In the meantime,
errors are handled gracefully so the user can continue using
the app.
Change-Id: Ie4ce6c7970815b448f406bb5e64aeefda348aeed
(cherry picked from commit f34d8e153d)
(cherry picked from commit 6c2102466e)
In CscPageCallRecording a watch function was directly
modifying the Vuex state, which is not allowed in
strict mode. This change ensures that each recording
object is cloned before modification, preventing
unintended mutations of store data.
Change-Id: Ie564da2ce31bd61772a05450be21a9a0717632ef
(cherry picked from commit abc25dc49c)
(cherry picked from commit 8782f9219d)
- Verify and correct route access for admin-only CSC pages
- Update route guard logic to support:
* User role (admin / non-admin)
* Exact match on user profile attribute
* Presence of one or more profile attributes
* Required licenses (all must exist)
* Exact platfom feature
* Exact capability match
- Ensure route guards match menu visibility restrictions
- Document route guards and menu visibility logic
- Note: for fax settings, we use the extra variable
`isFaxServerSettingsActive` to determine whether the toggle
in the fax server menu should be on or off.
Change-Id: Id60a0e8b2145701ed4ae52d0859da46172076a89
(cherry picked from commit 2b46170467)
(cherry picked from commit 1a3b881c51)
Previously, the arrays for weekdays and months didn’t match
the values used in admin-ui (Sunday=1, Saturday=7, January=1,
December=12). This commit updates the calculation function
to match admin-ui conventions, ensuring consistency since
the data originates from the admin panel and is read-only here.
Change-Id: I121c18ffb901beaece19124865b88259ffcb2d3f
(cherry picked from commit 2afefb8048)
(cherry picked from commit 4f52bf95e5)
This reverts commit 694d697ac7.
NGCP-Flow: mr12.5
Reason for revert: Feature available from 13.5.X
Change-Id: Ide7b1998b3d4b0295acfc1c1a80d556358abbd26
(cherry picked from commit 9ed5ccf1ae)
Updated access rules for ADMIN subscribers:
- "Fax Settings > Mail to Fax" is now always visible.
* Admin users: The "ACTIVE" toggle can be changed,
and content is editable.
* Non-Admin users: The "ACTIVE" toggle cannot be changed,
and content is editable.
- "PBX Configuration > Seats > ID > Fax Settings > Mail to Fax" is
now always visible
* Admin users: The "ACTIVE" toggle can now be changed,
and content is editable.
* Non-Admin users: menu not visible
Change-Id: I1f30be27fde8a20092d8321e128f5d27dceec734
(cherry picked from commit bd086f4ca1)
(cherry picked from commit 694d697ac7)
After improving the handling of long words with
commit 0340bd7e3c
The csc_Call bar was misplaced a few pixels.
This commit aligns it to the menu column
to avoid any overlapping.
Change-Id: Ic8f8c6bbfa11bb3190c93612562dfc6b4a4b0055
(cherry picked from commit b503fe95cc)
(cherry picked from commit eadd174b4d)
Removed `&` from symbols to avoid invalid
characters in generated passwords
Change-Id: Iea37ad73e22df4d35b3834e713308a9b0605c252
(cherry picked from commit 2c548413a4)
(cherry picked from commit fd0f8d8c9c)
When the German translation is on, long words
are not readable without moving the side bar.
This commit increases the size of the side
menu and reduces the indent of sub-menus
Change-Id: Idb09587fe58907347f2461d6adc9a2a2706125b7
(cherry picked from commit 0340bd7e3c)
(cherry picked from commit 29d046063b)
Listed here the changes:
- change properties accessed directly
from state with computed properties
that handles null cases
- Fix typos for subcriberListState
and subcriberListError
- Improve route watcher in
CscPagePbxDeviceDetails
- add a method to load only thumbnails
instead of full set of data for
the device profiles to improve
performance.
- removed 1000 rows for loadProfiles()
as it was too slow. We expect max 150
devices so it was set to 300 rows.
Note, more refactoring will be needed.
Change-Id: Iefe0328052174f0bb93f8cdbae59f77257592592
(cherry picked from commit d8c1f097cc)
(cherry picked from commit 7d6446a2e0)
The Send Fax icon was displayed in the PBX Configuration
even when the functionality was not enabled in the fax settings.
This was caused by the ability to activate
the feature at the seat or group level.
The logic has been corrected, and the Send Fax functionality
now appears only when it is properly enabled for the user.
Change-Id: I02358f12eaf1a5543d2c6552e21d4452c56acdc6
(cherry picked from commit dcfecc4327)
(cherry picked from commit 7580d1d13a)
Two switch buttons added to group details as for seats.
These buttons update play_announce_before_call_setup and play_announce_before_cf preferences.
Change-Id: I230b9a8d62b34a2e013a326ad4d50403b82d824a
(cherry picked from commit 6e70eb898b)
(cherry picked from commit 435d76b47b)
If a pilot admin subscriber tries to change
the After Ring timeout for CFU set on one
of the seats, the CF config crashes
and change is not applied. This happens
because we are not passing the
subscriber_id of the Seat. In fact the
change in the CF is applied to the logged
in user instead. In this commit we pass
the subscriber_id attribute down the three
and improve the error handling.
Change-Id: I27b34a095263d18ca8d00b98bc3a528b4ee35f42
(cherry picked from commit f80f5974a0)
(cherry picked from commit 572c632717)
Change "Weiterleitung" to "Rufumleitung" which make more sense in our system.
Change-Id: Ia0d35efa94d395531e2e690fec647852b6c4c2ca
(cherry picked from commit ec610a9596)
(cherry picked from commit ae865da727)
CSC-UI has been changed so that, during a blind transfer, the
Referred-By header is customized with local identity URI.
Without this customisation, jssip puts blindly the subscriber username
which is not always what kamailio proxy expects.
Having correct Referred-By header is important because kamailio proxy
uses this header in order to identify the transferor in a blind transfer call.
In particular, kamailio proxy checks if Referred-By matches custom header
P-Xfer-Firstcall-Callee-To, in this case B is recogized as transferor.
Change-Id: If149b34c16a5dc13116f8fea9a6d8046498753cd
(cherry picked from commit ad870c279e)
(cherry picked from commit f5fb9750c7)
App was crashing when user was refreshing
page on page /pbx-configuration/device/${id}
This happens because the logic to load all
necessary resources is a bit tangled. This
commit attempts to tidy up things without
inserting breaking changes.
Change-Id: I868678fcc6ed181697a5f3825d41940429785375
(cherry picked from commit e314c96c3c)
(cherry picked from commit 0318ccab00)
Using AI to quickly translate keys
to Italian.
Change-Id: I2a0352d06850a32dd8e13c21f7b6e3e111bd2c12
(cherry picked from commit 34bcb13de3)
(cherry picked from commit f25a5d5eb2)
Change "if available" to "Always" which make more sense in our system.
Change-Id: I5f5d7a91d18127abd4e8bc389de69feca0a43075
(cherry picked from commit 1bff29a08f)
(cherry picked from commit 16888de24b)
UI modified to clearly show the "After Ring
Timeout" as unique parameter that is
editable in one place only.
Change-Id: Ieadc2c255ad8977664c2288269cef6c1a8da5b72
(cherry picked from commit 6bd7d4710c)
(cherry picked from commit fd66c44307)
Allow subscriber administrator to configure the devices
admin password from CSC.
Change-Id: I2919f749704e421ebc22eb82de3e9ed956dd5b40
(cherry picked from commit 30d4b44aea)
(cherry picked from commit 58eb0a61c6)
- The ban error is now handled, and an error message is displayed
when a user is banned.
- The translation of the error message has been added.
Change-Id: I3fc4c8d18136f4954b2cb9ccd7b896688e0f20de
(cherry picked from commit d0308acabe)
(cherry picked from commit 98dffb177b)
Debora Crescenzo
Giancarlo Errigo Mattos
nidrissi-zouggari
Hugo Zigha
Alessio Garzi
Nico Schedel