From c75e215574e1764713987f393f76ee1674e1af9c Mon Sep 17 00:00:00 2001
From: raxelsen <raxelsen@sipwise.com>
Date: Mon, 29 Oct 2018 16:41:35 +0100
Subject: [PATCH] TT#46176 CallForward destination input validation

Change-Id: Icdd8dd3aeccaa3056bd9a2598918f1b6b3bce7d6
---
 src/components/form/CscCallInput.vue          |  7 ++-
 .../CallForward/CscAddDestinationForm.vue     | 60 ++++++-------------
 .../pages/SpeedDial/CscSpeedDialAddForm.vue   | 16 +++--
 3 files changed, 35 insertions(+), 48 deletions(-)

diff --git a/src/components/form/CscCallInput.vue b/src/components/form/CscCallInput.vue
index 0877dedc..a50840fe 100644
--- a/src/components/form/CscCallInput.vue
+++ b/src/components/form/CscCallInput.vue
@@ -16,6 +16,7 @@
             @input="input"
             @blur="blur"
             :error="$v.inputValue.$error"
+            :before="beforeButtons"
         />
     </q-field>
 </template>
@@ -34,7 +35,8 @@
     export default {
         name: 'csc-call-input',
         props: {
-            label: String
+            label: String,
+            before: Array
         },
         data () {
             return {
@@ -69,6 +71,9 @@
                 else if (!this.$v.inputValue.userInfo) {
                     return this.$t('validationErrors.inputValidNumber');
                 }
+            },
+            beforeButtons() {
+                return this.before ? this.before : [];
             }
         },
         methods: {
diff --git a/src/components/pages/CallForward/CscAddDestinationForm.vue b/src/components/pages/CallForward/CscAddDestinationForm.vue
index c76706f4..dbcaad76 100644
--- a/src/components/pages/CallForward/CscAddDestinationForm.vue
+++ b/src/components/pages/CallForward/CscAddDestinationForm.vue
@@ -28,24 +28,13 @@
             </q-popover>
         </q-btn>
         <div v-if="isFormEnabled">
-            <q-field
-                :error-label="destinationInputError"
-            >
-                <q-input
-                    dark
-                    :before="beforeIconDestination"
-                    :float-label="$t('pages.callForward.destination')"
-                    type="text"
-                    v-model="destinationForm.destination"
-                    @keyup.enter="addDestination()"
-                    :clearable="isFormTypeNumber"
-                    :autofocus="isFormTypeNumber"
-                    :disable="!isFormTypeNumber || addDestinationIsRequesting"
-                    @input="$v.destinationForm.destination.$touch"
-                    @blur="$v.destinationForm.destination.$touch"
-                    :error="$v.destinationForm.destination.$error"
-                />
-            </q-field>
+            <csc-call-input
+                :label="$t('pages.callForward.destination')"
+                v-model="destinationForm.destination"
+                @submit="addDestination"
+                @error="error"
+                :before="beforeIconDestination"
+            />
             <q-field
                 :error-label="timeoutInputError"
             >
@@ -74,7 +63,7 @@
                 icon="check"
                 color="primary"
                 @click="addDestination()"
-                :disable="$v.destinationForm.destination.$error || $v.destinationForm.timeout.$error"
+                :disable="$v.destinationForm.timeout.$error || destinationError"
             >
                 {{ $t('buttons.save') }}
             </q-btn>
@@ -84,6 +73,7 @@
 
 <script>
     import _ from 'lodash'
+    import CscCallInput from '../../form/CscCallInput'
     import {
         startLoading,
         showGlobalError
@@ -94,7 +84,6 @@
     } from 'vuex'
     import {
         required,
-        maxLength,
         minValue,
         numeric
     } from 'vuelidate/lib/validators'
@@ -126,10 +115,12 @@
                 destinationForm: {
                     destination: '',
                     timeout: 300
-                }
+                },
+                destinationError: false
             }
         },
         components: {
+            CscCallInput,
             QSelect,
             QPopover,
             QField,
@@ -142,10 +133,6 @@
         },
         validations: {
             destinationForm: {
-                destination: {
-                    required,
-                    maxLength: maxLength(64)
-                },
                 timeout: {
                     required,
                     minValue: minValue(1),
@@ -163,19 +150,6 @@
                 'hasSendFaxFeature',
                 'hasFaxCapability'
             ]),
-            destinationInputError() {
-                if (!this.$v.destinationForm.destination.maxLength) {
-                    return this.$t('validationErrors.maxLength', {
-                        field: this.$t('pages.callForward.destination'),
-                        maxLength: this.$v.destinationForm.destination.$params.maxLength.max
-                    });
-                }
-                else if (!this.$v.destinationForm.destination.required) {
-                    return this.$t('validationErrors.fieldRequired', {
-                        field: this.$t('pages.callForward.destination')
-                    });
-                }
-            },
             timeoutInputError() {
                 if (!this.$v.destinationForm.timeout.required) {
                     return this.$t('validationErrors.fieldRequired', {
@@ -194,9 +168,6 @@
                     });
                 }
             },
-            isFormTypeNumber() {
-                return this.formType === 'number';
-            },
             isFormEnabled() {
                 return this.activeForm === this.groupName && this.formEnabled;
             },
@@ -252,8 +223,8 @@
                 this.$store.commit('callForward/resetDestinationState');
             },
             addDestination() {
-                if (this.$v.destinationForm.destination.$error ||
-                    this.$v.destinationForm.timeout.$error) {
+                if (this.$v.destinationForm.timeout.$error ||
+                    this.destinationError) {
                         showGlobalError(this.$t('validationErrors.generic'));
                 }
                 else {
@@ -266,6 +237,9 @@
                         sourcesetId: this.sourcesetId
                     });
                 }
+            },
+            error(state) {
+                this.destinationError = state;
             }
         }
     }
diff --git a/src/components/pages/SpeedDial/CscSpeedDialAddForm.vue b/src/components/pages/SpeedDial/CscSpeedDialAddForm.vue
index 4730ff06..30123de2 100644
--- a/src/components/pages/SpeedDial/CscSpeedDialAddForm.vue
+++ b/src/components/pages/SpeedDial/CscSpeedDialAddForm.vue
@@ -71,6 +71,9 @@
     import 'quasar-extras/animate/bounceInRight.css'
     import 'quasar-extras/animate/bounceOutRight.css'
     import CscCallInput from '../../form/CscCallInput'
+    import {
+        showGlobalError
+    } from '../../../helpers/ui'
     import {
         QCard,
         QCardTitle,
@@ -137,10 +140,15 @@
                 this.formEnabled = false;
             },
             save() {
-                this.$emit('save', {
-                    destination: this.destination,
-                    slot: this.slot
-                });
+                if (this.destinationError) {
+                    showGlobalError(this.$t('validationErrors.generic'));
+                }
+                else {
+                    this.$emit('save', {
+                        destination: this.destination,
+                        slot: this.slot
+                    });
+                }
             },
             reset() {
                 this.destination = '';