TT#68300 Fix main() function return and program exit

Make main() return a normal value, and let the call site act on it,
which in most cases implies doing an exit. This unifies the behavior
and gets rid of dead-code.

Change-Id: Id83284a95423b0d0e866d99f83bf546989054d76

bin/ngcp-api-ping

@@ -42,22 +42,17 @@ sub main {
     my $uri = '/api/domains/';
     $client->set_verbose($opts->{verbose});
     my $res = $client->request("GET", $uri);
-    my $rc = 0;
+
     if (defined $res->as_hash->{total_count}) {
         print "API is up\n";
+        return 0;
     } else {
         print "API is down\n";
-        $rc = 1;
+        return 1;
     }
-
-    exit $rc;
-
-    return;
 }
 
-main();
-
-exit 0;
+exit main();
 
 __END__
 

bin/ngcp-create-customer

@@ -53,14 +53,10 @@ sub main {
     my $res = $client->request("POST", $uri, \%data);
     print $res->result."\n";
 
-    exit !$res->is_success;
-
-    return;
+    return !$res->is_success;
 }
 
-main();
-
-exit 0;
+exit main();
 
 __END__
 

bin/ngcp-create-domain

@@ -60,14 +60,10 @@ sub main {
     my $res = $client->request("POST", $uri, \%data);
     print $res->result."\n";
 
-    exit !$res->is_success;
-
-    return;
+    return !$res->is_success;
 }
 
-main();
-
-exit 0;
+exit main();
 
 __END__
 

bin/ngcp-create-subscriber

@@ -71,14 +71,10 @@ sub main {
     my $res = $client->request("POST", $uri, \%data);
     print $res->result."\n";
 
-    exit !$res->is_success;
-
-    return;
+    return !$res->is_success;
 }
 
-main();
-
-exit 0;
+exit main();
 
 __END__
 

bin/ngcp-credit-warning

@@ -168,12 +168,10 @@ sub main {
             print $EVAL_ERROR if $EVAL_ERROR;
         }
     }
-    return;
+    return 0;
 }
 
-main();
-
-exit 0;
+exit main();
 
 __END__
 

bin/ngcp-delete-domain

@@ -67,14 +67,10 @@ sub main {
     my $res = $client->request("DELETE", $uri, \%data);
     print $res->result."\n";
 
-    exit !$res->is_success;
-
-    return;
+    return !$res->is_success;
 }
 
-main();
-
-exit 0;
+exit main();
 
 __END__
 

bin/ngcp-get-customer

@@ -48,14 +48,10 @@ sub main {
     $res->is_success ? print $res->decoded_content."\n"
                      : print $res->result."\n";
 
-    exit !$res->is_success;
-
-    return;
+    return !$res->is_success;
 }
 
-main();
-
-exit 0;
+exit main();
 
 __END__
 

bin/ngcp-sound-set

@@ -48,14 +48,10 @@ sub main {
     $res->is_success ? print $res->content."\n"
                      : print $res->result."\n";
 
-    exit !$res->is_success;
-
-    return;
+    return !$res->is_success;
 }
 
-main();
-
-exit 0;
+exit main();
 
 __END__
 

bin/ngcp-terminate-customer

@@ -49,14 +49,10 @@ sub main {
     my $res = $client->request("PATCH", $uri, $data);
     print $res->result."\n";
 
-    exit !$res->is_success;
-
-    return;
+    return !$res->is_success;
 }
 
-main();
-
-exit 0;
+exit main();
 
 __END__
 

bin/ngcp-terminate-subscriber

@@ -65,14 +65,10 @@ sub main {
     my $res = $client->request("PATCH", $uri, $data);
     print $res->result."\n";
 
-    exit !$res->is_success;
-
-    return;
+    return !$res->is_success;
 }
 
-main();
-
-exit 0;
+exit main();
 
 __END__