From b1c9f2b2ef7bcafaea4603e938b5c3a61fa4eb36 Mon Sep 17 00:00:00 2001
From: Richard Fuchs <rfuchs@sipwise.com>
Date: Thu, 16 Aug 2018 08:34:42 -0400
Subject: [PATCH] TT#42673 verify redis reply types before processing them

Change-Id: Ib1839dfc7e47f70e2cee9db580b4ed183507949a
---
 medredis.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/medredis.c b/medredis.c
index 08728fb..ef1dcfb 100644
--- a/medredis.c
+++ b/medredis.c
@@ -53,6 +53,19 @@ static med_entry_t *medredis_reply_to_entry(redisReply *reply) {
             reply->elements);
         return NULL;
     }
+    // verify types
+    for (int i = 0; i < (int) reply->elements; i++) {
+        if (reply->element[i]->type != REDIS_REPLY_STRING) {
+            L_ERROR("Received Redis reply type %i instead of %i (string) for element %i\n",
+                    reply->element[i]->type, REDIS_REPLY_STRING, i);
+            return NULL;
+        }
+        if (reply->element[i]->str == NULL) {
+            L_ERROR("Received NULL string from Redis for element %i\n",
+                    i);
+            return NULL;
+        }
+    }
     entry = (med_entry_t*)malloc(sizeof(med_entry_t));
     memset(entry, 0, sizeof(med_entry_t));