From afc24cbc514e89c47c8685bf048a30e4a9ac474f Mon Sep 17 00:00:00 2001
From: Kirill Solomko <ksolomko@sipwise.com>
Date: Thu, 23 Jun 2022 18:41:56 +0200
Subject: [PATCH] TT#182200 skip intermediate cdr records without valid src dst

* If there are multiple call leg acc records for a call, ones
  that do not contain valid src + dst leg data (either JSON or th
  old format), these acc records are skipped and intermediate cdrs
  are created for the remaining records that contain valid src and dst
  leg data

Change-Id: Ia7e8446fe4953d1391f99ea1530990e3d385c056
(cherry picked from commit b0e94168f73d88126e8b90822a29d928186d3fcc)
---
 cdr.c | 46 ++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 44 insertions(+), 2 deletions(-)

diff --git a/cdr.c b/cdr.c
index ac10fef..2daf067 100644
--- a/cdr.c
+++ b/cdr.c
@@ -1288,6 +1288,39 @@ static int cdr_parse_dstleg_list(char *dstleg, cdr_entry_t *cdr)
     return 0;
 }
 
+static int validate_src_dst_leg(med_entry_t *e)
+{
+    if (!e->src_leg[0])
+    {
+        L_DEBUG("Missing src_leg");
+        return -1;
+    }
+
+    if (!e->dst_leg[0])
+    {
+        L_DEBUG("Missing dst_leg");
+        return -1;
+    }
+
+    json_object *json_src_leg = json_tokener_parse(e->src_leg);
+    if (!(json_src_leg && json_object_is_type(json_src_leg, json_type_object)) &&
+        strchr(e->src_leg, MED_SEP) == NULL)
+    {
+        L_DEBUG("Invalid src_leg");
+        return -1;
+    }
+
+    json_object *json_dst_leg = json_tokener_parse(e->dst_leg);
+    if (!(json_dst_leg && json_object_is_type(json_dst_leg, json_type_object)) &&
+        strchr(e->dst_leg, MED_SEP) == NULL)
+    {
+        L_DEBUG("Invalid dst_leg");
+        return -1;
+    }
+
+    return 0;
+}
+
 static int cdr_parse_srcleg(char *srcleg, cdr_entry_t *cdr)
 {
     json_object *json = json_tokener_parse(srcleg);
@@ -1390,7 +1423,7 @@ static cdr_entry_t *alloc_cdrs(uint64_t cdr_count) {
 static int cdr_create_cdrs(med_entry_t *records, uint64_t count,
         cdr_entry_t **cdrs, uint64_t *cdr_count, uint64_t *alloc_size, uint8_t *trash, int do_intermediate)
 {
-    uint64_t i = 0, cdr_index = 0;
+    uint64_t i = 0, cdr_index = 0, created = 0;
     uint64_t invites = 0;
     int timed_out = 0;
 
@@ -1479,6 +1512,13 @@ static int cdr_create_cdrs(med_entry_t *records, uint64_t count,
                 if (!tmp_unix_endtime) {
                     if (do_intermediate && !timed_out) {
                         L_DEBUG("CDR %lu is an intermediate record\n", cdr_index);
+
+                        if (validate_src_dst_leg(e))
+                        {
+                            L_DEBUG("Skip intermediate CDR index %lu without valid src_leg and dst_leg for call-id '%s'\n", cdr_index, e->callid);
+                            continue;
+                        }
+
                         cdr->intermediate = 1;
                     }
                     else {
@@ -1488,6 +1528,8 @@ static int cdr_create_cdrs(med_entry_t *records, uint64_t count,
                 }
             }
 
+            ++created; // TODO: move to the end when everything is successful ?
+
             g_string_assign(cdr->call_id, e->callid);
             cdr->start_time = e->unix_timestamp;
             cdr->duration = (tmp_unix_endtime >= e->unix_timestamp) ? tmp_unix_endtime - e->unix_timestamp : 0;
@@ -1529,7 +1571,7 @@ static int cdr_create_cdrs(med_entry_t *records, uint64_t count,
             return -1;
     }
 
-    *cdr_count = cdr_index;
+    *cdr_count = created;
 
     /*L_DEBUG("Created %llu CDRs:", *cdr_count);*/