From f35b5207443cfc47e599e6df1be0594e70ab95e5 Mon Sep 17 00:00:00 2001
From: Michael Prokop <mprokop@sipwise.com>
Date: Wed, 24 Nov 2021 11:25:19 +0100
Subject: [PATCH] TT#151550 github workflow: be a bit more verbose + run on
 ubuntu-latest with PPA

Using apt-get with `-qq` displays only the following message
on package installation problems:

| E: Unable to correct problems, you have held broken packages.

Whereas with `-q`, we get the actual underlying problem, being:

| The following packages have unmet dependencies:
|  builddeps:. : Depends: debhelper-compat (= 13)
| E: Unable to correct problems, you have held broken packages.

Furthermore, ubuntu-20.04 doesn't provide debhelper-compat (= 13),
therefore our workflows fail with:

| The following packages have unmet dependencies:
|  builddeps:. : Depends: debhelper-compat (= 13)
| E: Unable to correct problems, you have held broken packages.

So enable the ubuntu-cloud-archive/yoga-staging PPA,
which provides a backport of debhelper v13:
https://launchpad.net/~ubuntu-cloud-archive/+archive/ubuntu/yoga-staging/+packages
and fixes our failing coverity builds on github.

While at it, let's switch from ubuntu-20.04 to ubuntu-latest, which
currently still points to ubuntu-20.04, but should reduce
our maintenance efforts.

Change-Id: Ifffd3e4b446ed916501acd26b160f2b48fb405a7
---
 .github/workflows/clang-analyze.yml | 8 +++++---
 .github/workflows/coverity.yml      | 8 +++++---
 .github/workflows/cppcheck.yml      | 4 ++--
 .github/workflows/sanitizers.yml    | 6 ++++--
 4 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/clang-analyze.yml b/.github/workflows/clang-analyze.yml
index 46eacfc..ae55589 100644
--- a/.github/workflows/clang-analyze.yml
+++ b/.github/workflows/clang-analyze.yml
@@ -6,7 +6,7 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
 
     steps:
       - name: Checkout source
@@ -14,8 +14,10 @@ jobs:
 
       - name: Get build dependencies
         run: |
-          sudo apt-get install -qq -y --no-install-recommends clang-tools
-          sudo apt-get build-dep -qq -y .
+          # note: debhelper v13 isn't available from ubuntu-20.04 yet, we need a backport
+          sudo apt-add-repository -y ppa:ubuntu-cloud-archive/yoga-staging
+          sudo apt-get install -q -y --no-install-recommends clang-tools
+          sudo apt-get build-dep -q -y .
 
       - name: Analyze
         run: |
diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
index e8018ad..dac1047 100644
--- a/.github/workflows/coverity.yml
+++ b/.github/workflows/coverity.yml
@@ -9,7 +9,7 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
 
     env:
       COVERITY_SCAN_TOKEN: ${{ secrets.COVERITY_SCAN_TOKEN }}
@@ -22,8 +22,10 @@ jobs:
 
       - name: Get build dependencies
         run: |
-          sudo apt-get install -qq -y --no-install-recommends git ca-certificates curl
-          sudo apt-get build-dep -qq -y .
+          # note: debhelper v13 isn't available from ubuntu-20.04 yet, we need a backport
+          sudo apt-add-repository -y ppa:ubuntu-cloud-archive/yoga-staging
+          sudo apt-get install -q -y --no-install-recommends git ca-certificates curl
+          sudo apt-get build-dep -q -y .
 
       - name: Get coverity scan
         run: |
diff --git a/.github/workflows/cppcheck.yml b/.github/workflows/cppcheck.yml
index 4d9ea36..15ac1c5 100644
--- a/.github/workflows/cppcheck.yml
+++ b/.github/workflows/cppcheck.yml
@@ -6,14 +6,14 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
 
     steps:
       - name: Checkout source
         uses: actions/checkout@v2
 
       - name: Get tool
-        run: sudo apt-get install -qq -y --no-install-recommends cppcheck
+        run: sudo apt-get install -q -y --no-install-recommends cppcheck
 
       - name: Analyze
         run: cppcheck -q --enable=all src
diff --git a/.github/workflows/sanitizers.yml b/.github/workflows/sanitizers.yml
index e0dc2b0..371a0ee 100644
--- a/.github/workflows/sanitizers.yml
+++ b/.github/workflows/sanitizers.yml
@@ -6,7 +6,7 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
 
     env:
       FLAGS: "-fsanitize=address -fsanitize=leak -fsanitize=undefined"
@@ -17,7 +17,9 @@ jobs:
 
       - name: Get build dependencies
         run: |
-          sudo apt-get build-dep -qq -y .
+          # note: debhelper v13 isn't available from ubuntu-20.04 yet, we need a backport
+          sudo apt-add-repository -y ppa:ubuntu-cloud-archive/yoga-staging
+          sudo apt-get build-dep -q -y .
 
       - name: Build with sanitizers enabled
         run: |