From d9b6095307bde4349e1fbc6840fbe59698615c33 Mon Sep 17 00:00:00 2001 From: Victor Seva Date: Wed, 12 Jun 2024 10:28:58 +0200 Subject: [PATCH] MT#60281 tls: remove confusing error on startup Change-Id: I0367f8df4c7ecc946057a0bb5787b5762547177f --- debian/patches/series | 1 + ...sing-error-message-when-trying-to-pr.patch | 41 +++++++++++++++++++ 2 files changed, 42 insertions(+) create mode 100644 debian/patches/sipwise/tls-remove-confusing-error-message-when-trying-to-pr.patch diff --git a/debian/patches/series b/debian/patches/series index 3d1626d13..6b3381de0 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -49,6 +49,7 @@ sipwise/dialog-support-profile_get_size-for-all-profiles.patch sipwise/presence_vqr.patch sipwise/dialog-dlg_get_ttag.patch sipwise/app_lua_sr-support-second-str-for-cfgutils-lock.patch +sipwise/tls-remove-confusing-error-message-when-trying-to-pr.patch ### active development # ### Don't just put stuff in any order diff --git a/debian/patches/sipwise/tls-remove-confusing-error-message-when-trying-to-pr.patch b/debian/patches/sipwise/tls-remove-confusing-error-message-when-trying-to-pr.patch new file mode 100644 index 000000000..00d534c21 --- /dev/null +++ b/debian/patches/sipwise/tls-remove-confusing-error-message-when-trying-to-pr.patch @@ -0,0 +1,41 @@ +From: Victor Seva +Date: Wed, 12 Jun 2024 10:13:56 +0200 +Subject: tls: remove confusing error message when trying to print socket for + server + +> CRITICAL: [core/ip_addr.c:232]: ip_addr2sbuf(): unknown address family 0 +> NOTICE: tls [tls_domain.c:1176]: ksr_tls_fix_domain(): registered server_name callback handler for socket [:0], server_name='' ... +--- + src/modules/tls/tls_domain.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/src/modules/tls/tls_domain.c b/src/modules/tls/tls_domain.c +index e056a70..810a7e9 100644 +--- a/src/modules/tls/tls_domain.c ++++ b/src/modules/tls/tls_domain.c +@@ -1155,14 +1155,14 @@ static int ksr_tls_fix_domain(tls_domain_t *d, tls_domain_t *def) + d->ctx[i], tls_server_name_cb)) { + LM_ERR("register server_name callback handler for socket " + "[%s:%d], server_name='%s' failed for proc %d\n", +- ip_addr2a(&d->ip), d->port, ++ (d->ip.af > 0) ? ip_addr2a(&d->ip) : "0.0.0.0", d->port, + (d->server_name.s) ? d->server_name.s : "", i); + return -1; + } + if(!SSL_CTX_set_tlsext_servername_arg(d->ctx[i], d)) { + LM_ERR("register server_name callback handler data for socket " + "[%s:%d], server_name='%s' failed for proc %d\n", +- ip_addr2a(&d->ip), d->port, ++ (d->ip.af > 0) ? ip_addr2a(&d->ip) : "0.0.0.0", d->port, + (d->server_name.s) ? d->server_name.s : "", i); + return -1; + } +@@ -1175,7 +1175,7 @@ static int ksr_tls_fix_domain(tls_domain_t *d, tls_domain_t *def) + && (d->server_name.len > 0 || (d->type & TLS_DOMAIN_DEF))) { + LM_NOTICE("registered server_name callback handler for socket " + "[%s:%d], server_name='%s' ...\n", +- ip_addr2a(&d->ip), d->port, ++ (d->ip.af > 0) ? ip_addr2a(&d->ip) : "0.0.0.0", d->port, + (d->server_name.s) ? d->server_name.s : ""); + } + #endif