From b57ca79993f8f750f9336c17049dc56783dad629 Mon Sep 17 00:00:00 2001 From: Alessio Garzi Date: Thu, 21 Aug 2025 11:09:36 +0200 Subject: [PATCH] MT#63332 Remove qw(all) from Sipwise::API usage Importing all functions is useless because Sipwise::API does not define an import routine. This was tolerated on Debian 12, but starting from Debian 13 (Perl v5.40.1) it produces a warning. The warning is harmless, but using qw(all) is incorrect. All scripts under bin/ have been patched to remove qw(all). Change-Id: I98f9f63a250c86b1e55f8368724bd4a19bb969ba (cherry picked from commit 2e728bbc506bdfd3322cfd4ccaa9149d8b9c402e) --- bin/clean_registrations.pl | 2 +- bin/create_emergencymapping.pl | 2 +- bin/create_header_manipulation.pl | 2 +- bin/create_lnp.pl | 2 +- bin/create_ncos.pl | 2 +- bin/create_peers.pl | 2 +- bin/create_registrations.pl | 2 +- bin/create_rewrite_rules.pl | 2 +- bin/create_soundsets.pl | 2 +- bin/create_subscribers.pl | 2 +- bin/delete_domains.pl | 2 +- bin/set_preferences.pl | 2 +- bin/set_subscribers_callforward.pl | 2 +- bin/set_subscribers_callforward_advanced.pl | 2 +- bin/set_subscribers_location_map.pl | 2 +- bin/set_subscribers_speeddial.pl | 2 +- bin/set_subscribers_trusted_sources.pl | 2 +- bin/update_peer_host.pl | 2 +- bin/update_perm_reg.pl | 2 +- 19 files changed, 19 insertions(+), 19 deletions(-) diff --git a/bin/clean_registrations.pl b/bin/clean_registrations.pl index f2e68d4f..d3b5cb1f 100755 --- a/bin/clean_registrations.pl +++ b/bin/clean_registrations.pl @@ -29,7 +29,7 @@ use Capture::Tiny qw(capture); use YAML::XS; use List::MoreUtils qw(uniq); use DBI qw(:sql_types); -use Sipwise::API qw(all); +use Sipwise::API; my $CONSTANTS = YAML::XS::LoadFile('/etc/ngcp-config/constants.yml'); my $config = Config::Tiny->read('/etc/default/ngcp-api'); diff --git a/bin/create_emergencymapping.pl b/bin/create_emergencymapping.pl index f6377363..1e744cd9 100755 --- a/bin/create_emergencymapping.pl +++ b/bin/create_emergencymapping.pl @@ -26,7 +26,7 @@ use English; use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; use YAML::XS qw(DumpFile LoadFile); my $config = Config::Tiny->read('/etc/default/ngcp-api'); diff --git a/bin/create_header_manipulation.pl b/bin/create_header_manipulation.pl index 971d7553..8f8238e3 100755 --- a/bin/create_header_manipulation.pl +++ b/bin/create_header_manipulation.pl @@ -25,7 +25,7 @@ use English; use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; use YAML::XS qw(DumpFile LoadFile); my $config = Config::Tiny->read('/etc/default/ngcp-api'); diff --git a/bin/create_lnp.pl b/bin/create_lnp.pl index f243ec40..7af8b0e6 100755 --- a/bin/create_lnp.pl +++ b/bin/create_lnp.pl @@ -26,7 +26,7 @@ use YAML::XS qw(); use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; use Data::Dumper; my $config = Config::Tiny->read('/etc/default/ngcp-api'); diff --git a/bin/create_ncos.pl b/bin/create_ncos.pl index c4328c36..2657e73a 100755 --- a/bin/create_ncos.pl +++ b/bin/create_ncos.pl @@ -26,7 +26,7 @@ use YAML::XS; use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; use Data::Dumper; my $config = Config::Tiny->read('/etc/default/ngcp-api'); diff --git a/bin/create_peers.pl b/bin/create_peers.pl index 7f755ae9..f0c08295 100755 --- a/bin/create_peers.pl +++ b/bin/create_peers.pl @@ -26,7 +26,7 @@ use English; use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; use YAML::XS qw(DumpFile LoadFile); my $config = Config::Tiny->read('/etc/default/ngcp-api'); diff --git a/bin/create_registrations.pl b/bin/create_registrations.pl index ce72eb78..add3f07a 100755 --- a/bin/create_registrations.pl +++ b/bin/create_registrations.pl @@ -25,7 +25,7 @@ use English; use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; use YAML::XS qw(DumpFile LoadFile); my $config = Config::Tiny->read('/etc/default/ngcp-api'); diff --git a/bin/create_rewrite_rules.pl b/bin/create_rewrite_rules.pl index 16e1fa2c..c4fddd71 100755 --- a/bin/create_rewrite_rules.pl +++ b/bin/create_rewrite_rules.pl @@ -25,7 +25,7 @@ use English; use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; use YAML::XS; my $config = Config::Tiny->read('/etc/default/ngcp-api'); diff --git a/bin/create_soundsets.pl b/bin/create_soundsets.pl index 78d5a722..26623b93 100755 --- a/bin/create_soundsets.pl +++ b/bin/create_soundsets.pl @@ -25,7 +25,7 @@ use English; use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; use YAML::XS qw(DumpFile LoadFile); use File::Basename qw{ basename }; diff --git a/bin/create_subscribers.pl b/bin/create_subscribers.pl index 94d37088..51213e58 100755 --- a/bin/create_subscribers.pl +++ b/bin/create_subscribers.pl @@ -27,7 +27,7 @@ use YAML::XS qw(DumpFile LoadFile); use Getopt::Long; use List::Util qw(none); use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; my $config = Config::Tiny->read('/etc/default/ngcp-api'); my $opts; diff --git a/bin/delete_domains.pl b/bin/delete_domains.pl index dd9b3642..4a581ef6 100755 --- a/bin/delete_domains.pl +++ b/bin/delete_domains.pl @@ -27,7 +27,7 @@ use YAML::XS qw(DumpFile LoadFile); use Getopt::Long; use List::Util qw(none); use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; my $config = Config::Tiny->read('/etc/default/ngcp-api'); my $opts; diff --git a/bin/set_preferences.pl b/bin/set_preferences.pl index 54c64636..56a29985 100755 --- a/bin/set_preferences.pl +++ b/bin/set_preferences.pl @@ -26,7 +26,7 @@ use JSON qw(); use Getopt::Long; use List::Util qw(none); use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; use Storable 'dclone'; use Data::Dumper; diff --git a/bin/set_subscribers_callforward.pl b/bin/set_subscribers_callforward.pl index dcc69c1c..3c1f491e 100755 --- a/bin/set_subscribers_callforward.pl +++ b/bin/set_subscribers_callforward.pl @@ -26,7 +26,7 @@ use YAML::XS; use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; use Data::Dumper; my $config = Config::Tiny->read('/etc/default/ngcp-api'); diff --git a/bin/set_subscribers_callforward_advanced.pl b/bin/set_subscribers_callforward_advanced.pl index abca40de..9ce1c052 100755 --- a/bin/set_subscribers_callforward_advanced.pl +++ b/bin/set_subscribers_callforward_advanced.pl @@ -26,7 +26,7 @@ use YAML::XS; use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; use Data::Dumper; use JSON qw(); diff --git a/bin/set_subscribers_location_map.pl b/bin/set_subscribers_location_map.pl index 10e2de48..670b8cc4 100755 --- a/bin/set_subscribers_location_map.pl +++ b/bin/set_subscribers_location_map.pl @@ -26,7 +26,7 @@ use YAML::XS; use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; use Data::Dumper; my $config = Config::Tiny->read('/etc/default/ngcp-api'); diff --git a/bin/set_subscribers_speeddial.pl b/bin/set_subscribers_speeddial.pl index 95240956..854b5ce2 100755 --- a/bin/set_subscribers_speeddial.pl +++ b/bin/set_subscribers_speeddial.pl @@ -26,7 +26,7 @@ use YAML::XS; use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; use Data::Dumper; my $config = Config::Tiny->read('/etc/default/ngcp-api'); diff --git a/bin/set_subscribers_trusted_sources.pl b/bin/set_subscribers_trusted_sources.pl index f3015415..c4918375 100755 --- a/bin/set_subscribers_trusted_sources.pl +++ b/bin/set_subscribers_trusted_sources.pl @@ -26,7 +26,7 @@ use YAML::XS; use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; use Data::Dumper; use JSON qw(); diff --git a/bin/update_peer_host.pl b/bin/update_peer_host.pl index e422a95c..e66d66a4 100755 --- a/bin/update_peer_host.pl +++ b/bin/update_peer_host.pl @@ -25,7 +25,7 @@ use English; use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; my $config = Config::Tiny->read('/etc/default/ngcp-api'); my $opts; diff --git a/bin/update_perm_reg.pl b/bin/update_perm_reg.pl index d33650c2..a335b2e7 100755 --- a/bin/update_perm_reg.pl +++ b/bin/update_perm_reg.pl @@ -25,7 +25,7 @@ use English; use Getopt::Long; use Cwd 'abs_path'; use Config::Tiny; -use Sipwise::API qw(all); +use Sipwise::API; my $config = Config::Tiny->read('/etc/default/ngcp-api'); my $opts;