From 770dbb780149925a69327dc9f49ed0af7c060fb6 Mon Sep 17 00:00:00 2001
From: Marco Capetta <mcapetta@sipwise.com>
Date: Mon, 26 Jul 2021 15:22:58 +0200
Subject: [PATCH] TT#116101 scenarios/invite_sdp_filter: fix sdp in 200OK reply

Even if the video support is disabed by the callee, a codec has to be
provided in the reply. Addin coded 34 equel to the one received in the
initial INVITE.

The missing codec was causing SEMS to add an empty line after the
sdp m= line causing rtpengine to return:
error: Failed to parse SDP

Change-Id: I80227c9dd9a34a21b278d9b069d5af88eb504655
---
 scenarios/invite_sdp_filter/sipp_scenario00_test.yml.tt2  | 3 +--
 scenarios/invite_sdp_filter/sipp_scenario01_test.yml.tt2  | 4 +---
 scenarios/invite_sdp_filter/sipp_scenario_responder00.xml | 2 +-
 scenarios/invite_sdp_filter/sipp_scenario_responder01.xml | 2 +-
 4 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/scenarios/invite_sdp_filter/sipp_scenario00_test.yml.tt2 b/scenarios/invite_sdp_filter/sipp_scenario00_test.yml.tt2
index 3bff5fb3..4d7725e5 100644
--- a/scenarios/invite_sdp_filter/sipp_scenario00_test.yml.tt2
+++ b/scenarios/invite_sdp_filter/sipp_scenario00_test.yml.tt2
@@ -46,8 +46,7 @@ messages:
   - 'a=rtpmap:8 PCMA/8000'
   - 'a=sendrecv'
   - 'a=ptime:50'
-  - 'm=video 0 RTP/AVPF'
-  - 'a=sendrecv'
+  - 'm=video 0 RTP/AVPF 34'
 - - 'SIP/2.0 200 OK'
   - 'Record-Route: <sip:127.0.0.1:5062;lr=on;ftag=[^;]+;vsf=[^;]+;rtpprx=yes>'
   - 'Record-Route: <sip:127.0.0.1;r2=on;lr=on;ftag=[^;]+;ngcplb=yes;nat=yes;socket=udp:[% server_ip %]:5060>'
diff --git a/scenarios/invite_sdp_filter/sipp_scenario01_test.yml.tt2 b/scenarios/invite_sdp_filter/sipp_scenario01_test.yml.tt2
index e87f3f5a..72268fdc 100644
--- a/scenarios/invite_sdp_filter/sipp_scenario01_test.yml.tt2
+++ b/scenarios/invite_sdp_filter/sipp_scenario01_test.yml.tt2
@@ -46,9 +46,7 @@ messages:
   - 'a=rtpmap:8 PCMA/8000'
   - 'a=sendrecv'
   - 'a=ptime:50'
-  - 'm=video 0 RTP/AVPF'
-  - ' '
-  - 'a=sendrecv'
+  - 'm=video 0 RTP/AVPF 34'
 - - 'SIP/2.0 200 OK'
   - 'Record-Route: <sip:127.0.0.1:5062;lr=on;ftag=[^;]+;vsf=[^;]+;rtpprx=yes>'
   - 'Record-Route: <sip:127.0.0.1;r2=on;lr=on;ftag=[^;]+;ngcplb=yes;nat=yes;socket=udp:[% server_ip %]:5060>'
diff --git a/scenarios/invite_sdp_filter/sipp_scenario_responder00.xml b/scenarios/invite_sdp_filter/sipp_scenario_responder00.xml
index e9517fa4..a4c34496 100644
--- a/scenarios/invite_sdp_filter/sipp_scenario_responder00.xml
+++ b/scenarios/invite_sdp_filter/sipp_scenario_responder00.xml
@@ -45,7 +45,7 @@
       m=audio [media_port] RTP/AVP 8
       a=rtpmap:8 PCMA/8000
       a=ptime:50
-      m=video 0 RTP/AVPF
+      m=video 0 RTP/AVPF 34
 
     ]]>
   </send>
diff --git a/scenarios/invite_sdp_filter/sipp_scenario_responder01.xml b/scenarios/invite_sdp_filter/sipp_scenario_responder01.xml
index 6dbb6474..11e2a2b1 100644
--- a/scenarios/invite_sdp_filter/sipp_scenario_responder01.xml
+++ b/scenarios/invite_sdp_filter/sipp_scenario_responder01.xml
@@ -45,7 +45,7 @@
       m=audio [media_port] RTP/AVP 8
       a=rtpmap:8 PCMA/8000
       a=ptime:50
-      m=video 0 RTP/AVPF
+      m=video 0 RTP/AVPF 34
 
     ]]>
   </send>