Commit work in progress of fixing the implementation of content mixing in Jitsi VideoBridge.

src/net/java/sip/communicator/impl/protocol/jabber/OperationSetTelephonyConferencingJabberImpl.java

@@ -150,11 +150,8 @@ private List<MediaPacketExtension> getMedia(
             MediaAwareCallPeer<?,?,?> callPeer,
             boolean remote)
     {
-        MediaPacketExtension ext = null;
-        CallPeerMediaHandler<?> mediaHandler =
-            callPeer.getMediaHandler();
-        List<MediaPacketExtension> ret =
-            new ArrayList<MediaPacketExtension>();
+        CallPeerMediaHandler<?> mediaHandler = callPeer.getMediaHandler();
+        List<MediaPacketExtension> ret = new ArrayList<MediaPacketExtension>();
         long i = 1;
 
         for(MediaType mediaType : MediaType.values())
@@ -163,23 +160,26 @@ private List<MediaPacketExtension> getMedia(
 
             if (stream != null)
             {
-                long srcId = remote
-                            ? stream.getRemoteSourceID()
-                                    : stream.getLocalSourceID();
+                MediaPacketExtension ext
+                    = new MediaPacketExtension(Long.toString(i));
+                long srcId
+                    = remote
+                        ? stream.getRemoteSourceID()
+                        : stream.getLocalSourceID();
 
                 if (srcId != -1)
-                {
-                    ext = new MediaPacketExtension(Long.toString(i));
                     ext.setSrcID(Long.toString(srcId));
-                    ext.setType(mediaType.toString());
-                    MediaDirection direction = stream.getDirection();
-
-                    if (direction == null)
-                        direction = MediaDirection.INACTIVE;
-                    ext.setStatus(direction.toString());
-                    ret.add(ext);
-                    i++;
-                }
+
+                ext.setType(mediaType.toString());
+
+                MediaDirection direction = stream.getDirection();
+
+                if (direction == null)
+                    direction = MediaDirection.INACTIVE;
+
+                ext.setStatus(direction.toString());
+                ret.add(ext);
+                i++;
             }
         }
 

src/net/java/sip/communicator/impl/protocol/jabber/extensions/coin/MediaPacketExtension.java

@@ -93,6 +93,7 @@ public class MediaPacketExtension
     public MediaPacketExtension(String id)
     {
         super(NAMESPACE, ELEMENT_NAME);
+
         setAttribute(ID_ATTR_NAME, id);
     }
 

src/net/java/sip/communicator/impl/protocol/sip/OperationSetTelephonyConferencingSipImpl.java

@@ -469,6 +469,7 @@ private void getMediaXML(
 
                 if (direction == null)
                     direction = MediaDirection.INACTIVE;
+
                 // <status>
                 append(xml, "<", ELEMENT_STATUS, ">");
                 xml.append(direction.toString());

src/net/java/sip/communicator/service/protocol/media/AbstractOperationSetTelephonyConferencing.java

@@ -444,9 +444,11 @@ private String getEndpointMediaSrcId(Node endpoint, MediaType mediaType)
                     else if (ELEMENT_TYPE.equals(mediaChildName))
                     {
                         type = mediaChild.getTextContent();
-                        if ((srcId != null) && mediaTypeStr.equalsIgnoreCase(
-                                type))
+                        if ((srcId != null)
+                                && mediaTypeStr.equalsIgnoreCase(type))
+                        {
                             return srcId;
+                        }
                     }
                 }
             }