Removed comments, TODOs.

fix-message-formatting
Danny van Heumen 11 years ago
parent 2f7c4996eb
commit d51ea69014

@ -508,7 +508,7 @@ public List<String> getServerChatRoomList()
} }
list = listSignal.getValue(); list = listSignal.getValue();
this.channellist.set(list); this.channellist.set(list);
LOGGER.trace("Finished retrieve server chat room list."); LOGGER.trace("Finished retrieving server chat room list.");
} }
else else
{ {
@ -746,9 +746,6 @@ public void onFailure(final Exception e)
public void leave(final ChatRoomIrcImpl chatroom) public void leave(final ChatRoomIrcImpl chatroom)
{ {
LOGGER.trace("Leaving chat room '" + chatroom.getIdentifier() + "'."); LOGGER.trace("Leaving chat room '" + chatroom.getIdentifier() + "'.");
// You only actually join non-private chat rooms, so only these ones
// need to be left.
leave(chatroom.getIdentifier()); leave(chatroom.getIdentifier());
} }
@ -852,7 +849,8 @@ public void command(final Contact contact, final MessageIrcImpl message)
} }
/** /**
* Implementation of some commands. * Implementation of some commands. If the command is not recognized or
* implemented, it will be sent as if it were a normal message.
* *
* TODO Eventually replace this with a factory such that we can easily * TODO Eventually replace this with a factory such that we can easily
* extend with new commands. * extend with new commands.
@ -926,7 +924,7 @@ public void message(final ChatRoomIrcImpl chatroom, final String message)
throw new IllegalStateException("Not connected to an IRC server."); throw new IllegalStateException("Not connected to an IRC server.");
} }
final IRCApi irc = this.session.get(); final IRCApi irc = this.session.get();
String target = chatroom.getIdentifier(); final String target = chatroom.getIdentifier();
irc.message(target, message); irc.message(target, message);
} }
@ -1198,14 +1196,14 @@ public void onServerNumericMessage(final ServerNumericMessage msg)
final int endOfTargetIndex = msgText.indexOf(' '); final int endOfTargetIndex = msgText.indexOf(' ');
if (endOfTargetIndex == -1) if (endOfTargetIndex == -1)
{ {
LOGGER.trace("Expected source nick name in error message, " LOGGER.trace("Expected target nick in error message, but "
+ "but it cannot be found. Stop parsing."); + "it cannot be found. Stop parsing.");
break; break;
} }
final String targetNick = final String targetNick =
msgText.substring(0, endOfTargetIndex); msgText.substring(0, endOfTargetIndex);
final String msgTextError = // Send blank text string as the message, since we don't know
msgText.substring(endOfTargetIndex + 2); // what the actual message was.
MessageIrcImpl message = MessageIrcImpl message =
new MessageIrcImpl( new MessageIrcImpl(
"", "",
@ -1419,10 +1417,6 @@ public void onUserQuit(final QuitMessage msg)
// set this way) and it turns out the user is online? Can we send it // set this way) and it turns out the user is online? Can we send it
// a message then? (Or would Jitsi block this, because there is no // a message then? (Or would Jitsi block this, because there is no
// support for off-line messaging.) // support for off-line messaging.)
// TODO Also respond to private messages that are undeliverable
// because the user is not available anymore.
// 401 - <nick> :No such nick/channel
} }
} }

@ -11,7 +11,7 @@
import net.java.sip.communicator.service.protocol.*; import net.java.sip.communicator.service.protocol.*;
/** /**
* <tt>MessageDeliveredEvent</tt>s confirm successful delivery of an instant * <tt>MessageDeliveryFailedEvent</tt>s inform of failed delivery of an instant
* message. * message.
* *
* @author Emil Ivov * @author Emil Ivov

Loading…
Cancel
Save