From caf8386d6f354c06c8312e0ef089b8510a58f202 Mon Sep 17 00:00:00 2001
From: Lyubomir Marinov <lyubomir.marinov@jitsi.org>
Date: Mon, 9 Nov 2009 21:54:04 +0000
Subject: [PATCH] Fixes a couple of warnings, adds a javadoc comment.

---
 .../OperationSetBasicTelephonySipImpl.java    | 35 ++++++++++++-------
 1 file changed, 22 insertions(+), 13 deletions(-)

diff --git a/src/net/java/sip/communicator/impl/protocol/sip/OperationSetBasicTelephonySipImpl.java b/src/net/java/sip/communicator/impl/protocol/sip/OperationSetBasicTelephonySipImpl.java
index 38add8b14..fd6b58564 100644
--- a/src/net/java/sip/communicator/impl/protocol/sip/OperationSetBasicTelephonySipImpl.java
+++ b/src/net/java/sip/communicator/impl/protocol/sip/OperationSetBasicTelephonySipImpl.java
@@ -447,9 +447,11 @@ public boolean processResponse(ResponseEvent responseEvent)
 
         // errors
         default:
-            if ((responseStatusCode / 100 == 4)
-                || (responseStatusCode / 100 == 5)
-                || (responseStatusCode / 100 == 6))
+            int responseStatusCodeRange = responseStatusCode / 100;
+
+            if ((responseStatusCodeRange == 4)
+                || (responseStatusCodeRange == 5)
+                || (responseStatusCodeRange == 6))
             {
                 CallPeerSipImpl callPeer =
                     activeCallsRepository.findCallPeer(clientTransaction
@@ -804,8 +806,6 @@ public boolean processDialogTerminated(
         return true;
     }
 
-
-
     /**
      * Creates a new call and sends a RINGING response.
      *
@@ -1082,25 +1082,33 @@ private void processRefer(ServerTransaction serverTransaction,
              */
             private boolean done;
 
+            /**
+             * Notifies this <tt>CallChangeListener</tt> that a <tt>Call</tt>
+             * which it has been registered with has changed it state.
+             *
+             * @param evt a <tt>CallChangeEvent</tt> which specifies the
+             * <tt>Call</tt> which has changed its state
+             */
+            @Override
             public synchronized void callStateChanged(CallChangeEvent evt)
             {
                 if (!done
-                    && referToCallStateChanged(referToCallListenerSource,
-                        sendNotifyRequest, dialog, sipProvider, subscription))
+                        && referToCallStateChanged(
+                                referToCallListenerSource,
+                                sendNotifyRequest,
+                                dialog,
+                                sipProvider,
+                                subscription))
                 {
                     done = true;
                     if (referToCallListenerSource != null)
-                    {
                         referToCallListenerSource
                             .removeCallChangeListener(this);
-                    }
                 }
             }
         };
         if (referToCall != null)
-        {
             referToCall.addCallChangeListener(referToCallListener);
-        }
         referToCallListener.callStateChanged(null);
     }
 
@@ -1396,8 +1404,8 @@ public synchronized void answerCallPeer(CallPeer peer)
         throws OperationFailedException, ClassCastException
     {
         CallPeerSipImpl callPeer = (CallPeerSipImpl) peer;
-        callPeer.answer();
 
+        callPeer.answer();
     }
 
     /**
@@ -1407,6 +1415,7 @@ public synchronized void answerCallPeer(CallPeer peer)
      *
      * @return a string representation of this operation set.
      */
+    @Override
     public String toString()
     {
         return getClass().getSimpleName() + "-[dn="
@@ -1460,6 +1469,7 @@ public synchronized void shutdown()
      * @param mute <tt>true</tt> to mute the audio stream being sent to
      * <tt>peer</tt>; otherwise, <tt>false</tt>
      */
+    @Override
     public void setMute(CallPeer peer, boolean mute)
     {
         CallPeerSipImpl sipPeer = (CallPeerSipImpl) peer;
@@ -1680,4 +1690,3 @@ public ProtocolProviderServiceSipImpl getProtocolProvider()
         return protocolProvider;
     }
 }
-