From 8cc5375cd81dcf3a849af3db6bdf36ddf9596bd1 Mon Sep 17 00:00:00 2001 From: Danny van Heumen Date: Sun, 5 Jan 2014 21:07:39 +0100 Subject: [PATCH] Switched to LinkedList for channels. Switched to LinkedList data structure for channels, since I do not think the ArrayList offers any performance improvements and likely needs more memory. Besides, the specs don't specify any kind of intelligent lookup, so there is no need for random access performance or ordering searching. --- src/net/java/sip/communicator/impl/protocol/irc/IrcStack.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/net/java/sip/communicator/impl/protocol/irc/IrcStack.java b/src/net/java/sip/communicator/impl/protocol/irc/IrcStack.java index 86e9427d7..5bd7903d5 100644 --- a/src/net/java/sip/communicator/impl/protocol/irc/IrcStack.java +++ b/src/net/java/sip/communicator/impl/protocol/irc/IrcStack.java @@ -293,7 +293,7 @@ public List getServerChatRoomList() { if (this.channellist.instance == null) { - List list = new ArrayList(); + List list = new LinkedList(); synchronized (list) { try @@ -460,6 +460,7 @@ public void onFailure(Exception e) }); // Wait until async channel join operation has finished. joinSignal.wait(); + // TODO How to handle 471: Channel is full (reached set user limit)? if (isJoined(chatroom)) { // In case waiting ends with successful join