Stop playing of clips immediately if started is false. Stop looping clips immediately, not only

after the loop timeout. Sometimes the ring sound was played while the audio connection was already
set up.

src/net/java/sip/communicator/impl/neomedia/notify/PortAudioClipImpl.java

@@ -36,6 +36,8 @@ public class PortAudioClipImpl
     private boolean started = false;
 
     private final URL url;
+    
+    private Object syncObject = new Object();
 
     /**
      * Creates the audio clip and initialize the listener used from the
@@ -94,8 +96,14 @@ public void stop()
      */
     public void internalStop()
     {
-        if (url != null)
-            started = false;
+        synchronized (syncObject) 
+        {
+            if (url != null && started) 
+            {
+                started = false;
+                syncObject.notifyAll();
+            }
+        }
     }
 
     private class PlayThread
@@ -138,7 +146,7 @@ public void run()
                         return;
                     }
 
-                    while(audioStream.read(buffer) != -1)
+                    while(started && audioStream.read(buffer) != -1)
                         portAudioStream.write(buffer);
 
                     if(!isLooping())
@@ -149,7 +157,14 @@ public void run()
                     }
                     else
                     {
-                        Thread.sleep(getLoopInterval());
+                        synchronized(syncObject) {
+                            if (started) {
+                                try {
+                                    syncObject.wait(getLoopInterval());
+                                } catch (InterruptedException e) {
+                                }
+                            }
+                        }
                     }
                 }
             }
@@ -162,10 +177,6 @@ public void run()
             {
                 logger.error("Error reading from audio resource", e);
             }
-            catch (InterruptedException e)
-            {
-                logger.error("Cannot wait the interval between plays", e);
-            }
             catch (UnsupportedAudioFileException e)
             {
                 logger.error("Unknown file format", e);