From 20b787a7dc93eb665b655eafbac03d0beb847ca0 Mon Sep 17 00:00:00 2001
From: Danny van Heumen <danny@dannyvanheumen.nl>
Date: Sun, 6 Apr 2014 02:23:22 +0200
Subject: [PATCH] Some logging tweaks.

---
 .../impl/protocol/irc/IrcStack.java           | 26 ++++++++++---------
 1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/src/net/java/sip/communicator/impl/protocol/irc/IrcStack.java b/src/net/java/sip/communicator/impl/protocol/irc/IrcStack.java
index d372c80cd..1c9478ecd 100644
--- a/src/net/java/sip/communicator/impl/protocol/irc/IrcStack.java
+++ b/src/net/java/sip/communicator/impl/protocol/irc/IrcStack.java
@@ -584,11 +584,14 @@ public void onSuccess(IRCChannel channel)
                                         LocalUserChatRoomPresenceChangeEvent
                                             .LOCAL_USER_JOINED,
                                         null);
-                                LOGGER
-                                    .trace("Finished successful join callback "
-                                        + "for channel '"
-                                        + chatroom.getIdentifier()
-                                        + "'. Waking up original thread.");
+                                if (LOGGER.isTraceEnabled())
+                                {
+                                    LOGGER
+                                        .trace("Finished successful join "
+                                            + "callback for channel '"
+                                            + chatroom.getIdentifier()
+                                            + "'. Waking up original thread.");
+                                }
                                 // Notify waiting threads of finished
                                 // execution.
                                 joinSignal.setDone();
@@ -819,10 +822,6 @@ private static ChatRoomMemberRole convertMemberMode(char modeSymbol)
      * A listener for server-level messages (any messages that are related to
      * the server, the connection, that are not related to any chatroom in
      * particular) or that are personal message from user to local user.
-     * 
-     * TODO Support for auto-joined channels. (or just unannounced)
-     * - At least detectable via messages: 332 RPL_TOPIC, 353 RPL_NAMREPLY
-     * - Announced by onChannelJoin event in ServerListener
      */
     private class ServerListener
         extends VariousMessageListenerAdapter
@@ -857,7 +856,7 @@ public void onServerNumericMessage(ServerNumericMessage msg)
             Integer code = msg.getNumericCode();
             if (code == null)
             {
-                LOGGER.trace("No 'code' in numeric message event.");
+                LOGGER.debug("No 'code' in numeric message event.");
                 return;
             }
 
@@ -897,8 +896,11 @@ public void onServerNumericMessage(ServerNumericMessage msg)
                     + "' completed.");
                 break;
             default:
-                LOGGER.trace("This ServerNumericMessage (" + code
-                    + ") will not be handled by the ServerListener.");
+                if (LOGGER.isTraceEnabled())
+                {
+                    LOGGER.trace("This ServerNumericMessage (" + code
+                        + ") will not be handled by the ServerListener.");
+                }
                 break;
             }
         }