MT#62763 Fix shellcheck issues across all shell scripts
Run shellcheck v0.11.0 against all shell scripts and fix reported warnings.
Files modified:
- git/post-receive: SC2086, SC2034, SC2162
- pbuilder-hookdir/B20autopkgtest: SC2086
- pbuilder-hookdir/C10shell: SC2164, SC2086, SC2125
- puppet/apply.sh: SC2007, SC2155, SC2046
- scripts/jdg-build-and-provide-package: SC2086, SC2155, SC2230, SC2007,
SC2164, SC2162, SC2128, SC2034, SC1091, SC2125, SC2181, SC2016, SC2129
- scripts/jdg-debc: SC2086, SC2230
- scripts/jdg-generate-git-snapshot: SC2086
- scripts/jdg-generate-reprepro-codename: SC2059, SC2086
- scripts/jdg-generate-svn-snapshot: SC2086, SC2006, SC2129
- scripts/jdg-piuparts-wrapper: SC2086
- scripts/jdg-remove-reprepro-codename: SC2086
- scripts/jdg-repository-checker: SC2086, SC2181
- svn/trigger_jenkins: SC2128, SC2068
- tests/file-detection: SC1091
- tests/increase-version-number: SC1091
- tests/merge-conflict: SC1091
Key improvements:
- Replace word-splitting REPREPRO_OPTS with array-based run_reprepro() helper
- Use 'command -v' instead of 'which' (SC2230)
- Add proper quoting for variables (SC2086)
- Add cd error handling (SC2164)
- Separate local variable declarations from assignments (SC2155)
- Fix local variable re-declaration inside conditional block
- Use $(...) instead of backticks (SC2006)
- Group redirects for efficiency (SC2129)
- Add shellcheck source directives for sourced files (SC1091)
- Switch scripts/jdg-debc to /bin/bash
Thanks to Guillem Jover for feedback + several contributions like
changes within scripts/jdg-debc + improvements in svn/trigger_jenkins.
Development sponsored by Sipwise GmbH
Change-Id: I6e64dc57d33676830d3e21f875ed3c6381d508c2
Michael Prokop
fa87fc4c8a