The --keep-going option of file(1) might trigger false positives like: % file -b --keep-going hooks/pre-commit POSIX shell script text executable\012- awk or perl script text\012- a /bin/sh script, ASCII text executable while this is a shellscript where perl is used in a sub-process only. It (kind of) works fine when using file's `-i' option: % file -b --keep-going -i hooks/pre-commit text/x-shellscript; charset=us-ascii Sadly `-i` doesn't work for detecting perl scripts: % file helper/sync-db helper/sync-db: a /usr/bin/perl -CSD script, ASCII text executable % file -b --keep-going -i helper/sync-db text/plain; charset=us-ascii So instead drop the deep inspection of files via `--keep-going` to keep the behavior consistent across all tap scripts WRT file(1) options, except for the missing `-i` option inside perlcritic_tap. Development sponsored by Sipwise GmbH, recorded as TT#19714 in customers' ticket system.remotes/origin/HEAD
parent
c6c8c0246f
commit
5d02459e9a
Loading…
Reference in new issue