Update patch set 4

Browse Source

Patch Set 4: Code-Review+1

> Patch Set 4:
> 
> > Agreed, but don't we have the same problem by-design also in non-EC2 environments, like people booting outdated systems, installing NGCP CE on it and then only after reboot the kernel matches the system?
> 
> Yes, this is a problem but it can't be solved another way but reboot. So we can add such a check but if someone installs ngcp on the system with old kernel he will face the described error.

Sure, I'm just wondering why we add this to our ec2 wrapper but don't include it in installer instead.

> > (And by *always* rebooting means we make our pipeline intentionally slower)
> 
> Yes but the instance is already always rebooted after the configuration so this patchset changes nothing from this POV.

Unless I'm mistaken we're rebooting it twice now, nor?

> > BTW, did you test the code from this review? (Just checking/clarifying)
> 
> Sure. Otherwise mr8.2.1 and mr7.5.3 could not be built.

Ah excellent :)

Patch-set: 4
Reviewer: Gerrit User 1000000 <1000000@85315e57-5f03-49c3-83f8-201ae2313a75>
Label: Code-Review=+1

changes/70/37670/meta

Gerrit User 1000000 5 years ago committed by Gerrit Code Review

parent be3b9cf774

commit e453ee86fc

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File

Diff Content Not Available