From 456d120d0ee0f80851428c327a2a94456cf9a9cc Mon Sep 17 00:00:00 2001
From: Guillem Jover <gjover@sipwise.com>
Date: Thu, 7 Nov 2019 19:05:05 +0100
Subject: [PATCH] TT#69200 Do not use indirect method syntax

This has weird semantics and is generally frowned upon.

Change-Id: Ib1d43f13b935959508ce44b85999b615f7850b27
---
 lib/NGCP/BulkProcessor/Array.pm               | 2 +-
 lib/NGCP/BulkProcessor/SqlConnectors/CSVDB.pm | 4 ++--
 lib/NGCP/BulkProcessor/Utils.pm               | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/NGCP/BulkProcessor/Array.pm b/lib/NGCP/BulkProcessor/Array.pm
index 9b7cecd..8a34179 100644
--- a/lib/NGCP/BulkProcessor/Array.pm
+++ b/lib/NGCP/BulkProcessor/Array.pm
@@ -74,7 +74,7 @@ sub itemcount {
 sub grouparray {
 
   my ($array_ptr,$case_insensitive) = @_;
-  my $result = new NGCP::BulkProcessor::Table();
+  my $result = NGCP::BulkProcessor::Table->new();
   my $reducedarray = removeduplicates($array_ptr,$case_insensitive);
   my $sort_occurencecount_desc;
   if ($case_insensitive) {
diff --git a/lib/NGCP/BulkProcessor/SqlConnectors/CSVDB.pm b/lib/NGCP/BulkProcessor/SqlConnectors/CSVDB.pm
index ae76fcd..a1ed125 100644
--- a/lib/NGCP/BulkProcessor/SqlConnectors/CSVDB.pm
+++ b/lib/NGCP/BulkProcessor/SqlConnectors/CSVDB.pm
@@ -617,7 +617,7 @@ sub _convert_xlsbin2csv {
 
     xls2csvinfo('reading ' . $SourceFilename . ' as ' . $SourceCharset,getlogger(__PACKAGE__));
 
-    my $XLS = new IO::File;
+    my $XLS = IO::File->new();
     if (not $XLS->open('<' . $SourceFilename)) {
         fileerror('cannot open file ' . $SourceFilename . ': ' . $!,getlogger(__PACKAGE__));
         return 0;
@@ -754,7 +754,7 @@ sub _convert_xlsxbin2csv {
     xls2csvinfo('start converting ' . $SourceFilename . ' (worksheet ' . $worksheet . ') to ' . $DestFilename . ' ...',getlogger(__PACKAGE__));
 
 
-    my $XLS = new IO::File;
+    my $XLS = IO::File->new();
     if (not $XLS->open('<' . $SourceFilename)) {
         fileerror('cannot open file ' . $SourceFilename . ': ' . $!,getlogger(__PACKAGE__));
         return 0;
diff --git a/lib/NGCP/BulkProcessor/Utils.pm b/lib/NGCP/BulkProcessor/Utils.pm
index 12d15dc..a5f302d 100644
--- a/lib/NGCP/BulkProcessor/Utils.pm
+++ b/lib/NGCP/BulkProcessor/Utils.pm
@@ -397,7 +397,7 @@ sub wrap_text {
 
 sub create_guid {
 
-  my $ug = new Data::UUID;
+  my $ug = Data::UUID->new();
   my $uuid = $ug->create();
   return $ug->to_string( $uuid );