diff --git a/.perlcriticrc b/.perlcriticrc index a8105aa..d7186c9 100644 --- a/.perlcriticrc +++ b/.perlcriticrc @@ -1,5 +1,5 @@ verbose = %f line %l col %c\n [%s] %p (%e) = %m\n %r\n - # the ouput format, another nice one is 8, the [%s] is the severity + # the output format, another nice one is 8, the [%s] is the severity severity = 3 theme = security || (pbp && bugs) || cosmetic || sipwise @@ -26,7 +26,7 @@ functions = :builtins exclude_functions = print [-Modules::RequireExplicitInclusion] -# we dont want this +# we do not want this [BuiltinFunctions::ProhibitStringyEval] allow_includes = 0 diff --git a/lib/NGCP/BulkProcessor/DSPath.pm b/lib/NGCP/BulkProcessor/DSPath.pm index 1b7581d..8431f41 100644 --- a/lib/NGCP/BulkProcessor/DSPath.pm +++ b/lib/NGCP/BulkProcessor/DSPath.pm @@ -36,7 +36,7 @@ sub new { }, not_a_coderef_or_method => $callbacks->{not_a_coderef_or_method} // sub { my ($data, $key, $index, $value, $rest) = @_; - die "tried to retrieve from a non-existant coderef or method: $key in $data"; + die "tried to retrieve from a non-existent coderef or method: $key in $data"; } }, }; diff --git a/lib/NGCP/BulkProcessor/Logging.pm b/lib/NGCP/BulkProcessor/Logging.pm index ec27d65..49a787a 100644 --- a/lib/NGCP/BulkProcessor/Logging.pm +++ b/lib/NGCP/BulkProcessor/Logging.pm @@ -341,7 +341,7 @@ sub fieldnamesaquired { my ($db,$tablename,$logger) = @_; if (defined $logger) { - $logger->debug(_getsqlconnectorinstanceprefix($db) . 'fieldnames aquired and OK: [' . $db->connectidentifier() . '].' . $tablename); + $logger->debug(_getsqlconnectorinstanceprefix($db) . 'fieldnames acquired and OK: [' . $db->connectidentifier() . '].' . $tablename); } } @@ -350,7 +350,7 @@ sub primarykeycolsaquired { my ($db,$tablename,$keycols,$logger) = @_; if (defined $logger) { - $logger->debug(_getsqlconnectorinstanceprefix($db) . 'primary key columns aquired for [' . $db->connectidentifier() . '].' . $tablename . ': ' . ((defined $keycols and scalar @$keycols > 0) ? join(', ',@$keycols) : '')); + $logger->debug(_getsqlconnectorinstanceprefix($db) . 'primary key columns acquired for [' . $db->connectidentifier() . '].' . $tablename . ': ' . ((defined $keycols and scalar @$keycols > 0) ? join(', ',@$keycols) : '')); } } diff --git a/lib/NGCP/BulkProcessor/Projects/Massive/Generator/Preferences.pm b/lib/NGCP/BulkProcessor/Projects/Massive/Generator/Preferences.pm index 11ff01d..a8b63bc 100644 --- a/lib/NGCP/BulkProcessor/Projects/Massive/Generator/Preferences.pm +++ b/lib/NGCP/BulkProcessor/Projects/Massive/Generator/Preferences.pm @@ -102,7 +102,7 @@ sub set_allowed_ips_preferences { _info($context,"allowed ips group for subscriber $sip_username exists, ipnets deleted",1); } else { $allowed_ip_group_id = NGCP::BulkProcessor::Dao::Trunk::provisioning::voip_aig_sequence::increment($context->{db}); - _info($context,"new allowed ips group id for subscriber $sip_username aquired",1); + _info($context,"new allowed ips group id for subscriber $sip_username acquired",1); } my $allowed_ips_grp_ipnet_ids = NGCP::BulkProcessor::Dao::Trunk::provisioning::voip_allowed_ip_groups::insert_rows($context->{db},$allowed_ip_group_id,$allowed_ips); diff --git a/lib/NGCP/BulkProcessor/Projects/Massive/Generator/Provisioning.pm b/lib/NGCP/BulkProcessor/Projects/Massive/Generator/Provisioning.pm index d05b412..f49196f 100644 --- a/lib/NGCP/BulkProcessor/Projects/Massive/Generator/Provisioning.pm +++ b/lib/NGCP/BulkProcessor/Projects/Massive/Generator/Provisioning.pm @@ -217,7 +217,7 @@ sub _provision_subscriber { # _update_preferences($context); # _set_registrations($context); # _set_callforwards($context); - # #todo: additional prefs, AllowedIPs, NCOS, Callforwards. still thinking wether to integrate it + # #todo: additional prefs, AllowedIPs, NCOS, Callforwards. still thinking whether to integrate it # #in this main provisioning loop, or align it in separate run-modes, according to the files given. # } else { diff --git a/lib/NGCP/BulkProcessor/Projects/Massive/Generator/process.pl b/lib/NGCP/BulkProcessor/Projects/Massive/Generator/process.pl index b85f983..b6f582e 100755 --- a/lib/NGCP/BulkProcessor/Projects/Massive/Generator/process.pl +++ b/lib/NGCP/BulkProcessor/Projects/Massive/Generator/process.pl @@ -172,7 +172,7 @@ sub main() { } else { $result = 0; - scripterror("unknow task option '" . $task . "', must be one of " . join(', ',@TASK_OPTS),getlogger(getscriptpath())); + scripterror("unknown task option '" . $task . "', must be one of " . join(', ',@TASK_OPTS),getlogger(getscriptpath())); last; } } diff --git a/lib/NGCP/BulkProcessor/ServiceProxy.pm b/lib/NGCP/BulkProcessor/ServiceProxy.pm index dd0aa22..f06f6e1 100644 --- a/lib/NGCP/BulkProcessor/ServiceProxy.pm +++ b/lib/NGCP/BulkProcessor/ServiceProxy.pm @@ -474,7 +474,7 @@ sub wait { ##$self->{wait_tid} = undef; #} #} else { - # print "INGORE WAIT??????????\n"; + # print "IGNORE WAIT??????????\n"; } } diff --git a/lib/NGCP/BulkProcessor/SqlConnector.pm b/lib/NGCP/BulkProcessor/SqlConnector.pm index f8152c5..bdba25e 100644 --- a/lib/NGCP/BulkProcessor/SqlConnector.pm +++ b/lib/NGCP/BulkProcessor/SqlConnector.pm @@ -338,7 +338,7 @@ sub _db_disconnect { } - # further disconect code follows in child classes.... + # further disconnect code follows in child classes.... } @@ -660,8 +660,8 @@ sub db_get_all_arrayref { } -# get a reference to a hash containing a hashreference for each row, like DBI's -# fetchall_hashref() does. +# get a reference to a hash containing a hash reference for each row, like +# DBI's fetchall_hashref() does. sub db_get_all_hashref { my $self = shift; @@ -804,7 +804,7 @@ sub DESTROY { # of the entire current context, at the moment it starts. # due to this, if the thread is finished, perl gc will invoke destructors # on the thread's scope elements, that potentially contains connectors from - # the main tread. it will actually attempt destroy them (disconect, etc.) + # the main tread. it will actually attempt destroy them (disconnect, etc.) # this is a problem with destructors that change object state like this one # # to avoid this, we perform destruction tasks only if the destructing tid