* README: update to reflect support of these images vs enterprise and AIO
Signed-off-by: Simon L <szaimen@e.mail.de>
* address review by J0WI
Signed-off-by: Simon L <szaimen@e.mail.de>
---------
Signed-off-by: Simon L <szaimen@e.mail.de>
* Enable MariaDB binary log
This resolves a warning in the database server log:
[Warning] You need to use --log-bin to make --binlog-format work.
Pros:
* support for point-in-time recovery
* necessary for replication
Cons:
* slows down database operations ("slightly", per the manual)
* takes up disk space (mitigated by `--expire-logs-days=2`)
See also:
* <https://mariadb.com/kb/en/binary-log/>
* <https://mariadb.com/kb/en/full-list-of-mariadb-options-system-and-status-variables/>
Alternatives:
1. Do not add `--log-bin`. Remove `--binlog-format` instead. This causes the least amount of change for existing installations.
Signed-off-by: Adam Monsen <haircut@gmail.com>
* remove --expire-logs-days=2 mariadb flag
This better aligns with recommendations in the Nextcloud documentation.
Also: the flag isn't necessary. There are already set times for cleanup: The MySQL and MariaDB documentation both state that binary logs will be purged on startup and flush/rotation.
Signed-off-by: Adam Monsen <haircut@gmail.com>
---------
Signed-off-by: Adam Monsen <haircut@gmail.com>
* 🩹 fix deprecation warning:
Node.js 12 actions are deprecated.
For more information see:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Please update the following actions to use Node.js 16: actions/checkout@master
Using version v3, latest or master: actions/checkout#689
Signed-off-by: Thomas Merz <git@rhoenwurz.de>
* Update .github/workflows/update-sh.yml
Co-authored-by: J0WI <J0WI@users.noreply.github.com>
Signed-off-by: thomasmerz <thomasmerz@users.noreply.github.com>
Signed-off-by: Thomas Merz <git@rhoenwurz.de>
Signed-off-by: thomasmerz <thomasmerz@users.noreply.github.com>
Co-authored-by: J0WI <J0WI@users.noreply.github.com>
This should fix errors that the old code would've run into thanks to the update to Go 1.18, and should help prevent them in the future by pinning to a specific release of both Bashbrew and the related scripts.
Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
* enable mariadb auto upgrade
This fixes after-upgrade issues, for example:
[ERROR] Incorrect definition of table mysql.event: expected column 'definer' at position 3 to have type varchar(, found type char(141).
The upgrade only happens when necessary.
I also disabled the system database backup because I assume users create
and test their own backups.
Signed-off-by: Adam Monsen <haircut@gmail.com>
* use 1s instead of "yesplease"
Any nonzero value is valid for these environment variables.
Signed-off-by: Adam Monsen <haircut@gmail.com>
Signed-off-by: Adam Monsen <haircut@gmail.com>
Artur Neumann
Ben Siddans
okrc
Daniel
GitHub Workflow
John Molakvoæ
simonmicro
J0WI
Simon L
Adam Monsen
Remi Rampin
Varun Patil
thomasmerz
Tianon Gravi
Justin Lamp
MAbeeTT (Matías Pecchia)
Florian Friedrich