You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Russell Bryant dd50b9e8b5 Merged revisions 222878 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r222878 | russell | 2009-10-08 14:45:47 -0500 (Thu, 08 Oct 2009) | 44 lines Make filestream frame handling safer by isolating frames before returning them. This patch is related to a number of issues on the bug tracker that show crashes related to freeing frames that came from a filestream. A number of fixes have been made over time while trying to figure out these problems, but there re still people seeing the crash. (Note that some of these bug reports include information about other problems. I am specifically addressing the filestream frame crash here.) I'm still not clear on what the exact problem is. However, what is _very_ clear is that we have seen quite a few problems over time related to unexpected behavior when we try to use embedded frames as an optimization. In some cases, this optimization doesn't really provide much due to improvements made in other areas. In this case, the patch modifies filestream handling such that the embedded frame will not be returned. ast_frisolate() is used to ensure that we end up with a completely mallocd frame. In reality, though, we will not actually have to malloc every time. For filestreams, the frame will almost always be allocated and freed in the same thread. That means that the thread local frame cache will be used. So, going this route doesn't hurt. With this patch in place, some people have reported success in not seeing the crash anymore. (SWP-150) (AST-208) (ABE-1834) (issue #15609) Reported by: aragon Patches: filestream_frisolate-1.4.diff2.txt uploaded by russell (license 2) Tested by: aragon, russell (closes issue #15817) Reported by: zerohalo Tested by: zerohalo (closes issue #15845) Reported by: marhbere Review: https://reviewboard.asterisk.org/r/386/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222880 65c4cc65-6c06-0410-ace0-fbb531ad65f3		17 years ago
..
db1-ast	Merged revisions 209879 via svnmerge from	17 years ago
editline	…
stdtime	…
Makefile	Close up to the soft open file limit (same on Linux, but varies drastically on OS X).	17 years ago
abstract_jb.c	…
acl.c	Merge code associated with AST-2009-006	17 years ago
adsistub.c	…
aescrypt.c	…
aeskey.c	…
aesopt.h	…
aestab.c	…
alaw.c	Fix compile when certain G711 menuselect options are enabled.	17 years ago
app.c	Close up to the soft open file limit (same on Linux, but varies drastically on OS X).	17 years ago
ast_expr2.c	fixes a few redundant conditions	17 years ago
ast_expr2.fl	fixes a few redundant conditions	17 years ago
ast_expr2.h	…
ast_expr2.y	…
ast_expr2f.c	…
asterisk.c	Merged revisions 221776 via svnmerge from	17 years ago
asterisk.exports	Merged revisions 208083 via svnmerge from	17 years ago
astfd.c	Merged revisions 211274 via svnmerge from	17 years ago
astmm.c	…
astobj2.c	Recorded merge of revisions 222152 via svnmerge from	17 years ago
audiohook.c	…
autochan.c	…
autoservice.c	…
bridging.c	…
buildinfo.c	…
callerid.c	Merged revisions 206867 via svnmerge from	17 years ago
cdr.c	AST-2009-005	17 years ago
cel.c	Fix channel reference leak.	17 years ago
channel.c	Deadlock in channel masquerade handling	17 years ago
chanvars.c	…
cli.c	AST-2009-005	17 years ago
config.c	Merged revisions 219023 via svnmerge from	17 years ago
cryptostub.c	…
cygload.c	…
datastore.c	…
db.c	…
devicestate.c	Merged revisions 205409 via svnmerge from	17 years ago
dial.c	Merge the new Channel Event Logging (CEL) subsystem.	17 years ago
dns.c	Fix a few compilation problems found when building Asterisk against uClibc.	17 years ago
dnsmgr.c	AST-2009-005	17 years ago
dsp.c	AST-2009-005	17 years ago
ecdisa.h	…
enum.c	AST-2009-005	17 years ago
event.c	Fix ast_event_queue_and_cache() to actually do the cache() part.	17 years ago
features.c	Deadlock in channel masquerade handling	17 years ago
file.c	Merged revisions 222878 via svnmerge from	17 years ago
fixedjitterbuf.c	…
fixedjitterbuf.h	…
frame.c	Merged revisions 222878 via svnmerge from	17 years ago
fskmodem.c	…
fskmodem_float.c	…
fskmodem_int.c	…
global_datastores.c	…
hashtab.c	…
heap.c	…
http.c	Fix a trunk compilation warning.	17 years ago
image.c	…
indications.c	AST-2009-005	17 years ago
io.c	…
jitterbuf.c	…
loader.c	Make LOAD_ORDER actually work	17 years ago
logger.c	Initialize a variable that we check immediately upon startup.	17 years ago
manager.c	Eliminate unnecessary include of version.h in manager.c.	17 years ago
md5.c	…
netsock.c	fixes an ast_netsock_list memory leak.	17 years ago
pbx.c	Deadlock in channel masquerade handling	17 years ago
plc.c	…
poll.c	Various patches, to enable Asterisk to once again compile on Mac OS X.	17 years ago
privacy.c	…
rtp_engine.c	Merged revisions 221776 via svnmerge from	17 years ago
say.c	One more off-by-one in trunk	17 years ago
sched.c	…
security_events.c	Add an API for reporting security events, and a security event logging module.	17 years ago
sha1.c	…
slinfactory.c	…
srv.c	…
ssl.c	pthread_self returns a pthread_t which is not an unsigned int on all	17 years ago
strcompat.c	Merged revisions 208083 via svnmerge from	17 years ago
strings.c	…
stun.c	…
syslog.c	Add functions to map syslog facilities and priorities constants to strings.	17 years ago
taskprocessor.c	…
tcptls.c	fixes tcptls_session memory leak caused by ref count error	17 years ago
tdd.c	…
term.c	…
threadstorage.c	…
timing.c	AST-2009-005	17 years ago
translate.c	Merged revisions 208923 via svnmerge from	17 years ago
udptl.c	Allow non-compliant T.38 endpoints to be supportable via configuration option.	17 years ago
ulaw.c	Fix compile when certain G711 menuselect options are enabled.	17 years ago
utils.c	Merged revisions 216435 via svnmerge from	17 years ago
xml.c	Define our desires for POSIX and X/OPEN API features properly.	17 years ago
xmldoc.c	Add an empty line after each option when printing the	17 years ago