You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Matthew Jordan 365ae7523b res_http_websocket: Close websocket correctly and use careful fwrite ... When a client takes a long time to process information received from Asterisk, a write operation using fwrite may fail to write all information. This causes the underlying file stream to be in an unknown state, such that the socket must be disconnected. Unfortunately, there are two problems with this in Asterisk's existing websocket code: 1. Periodically, during the read loop, Asterisk must write to the connected websocket to respond to pings. As such, Asterisk maintains a reference to the session during the loop. When ast_http_websocket_write fails, it may cause the session to decrement its ref count, but this in and of itself does not break the read loop. The read loop's write, on the other hand, does not break the loop if it fails. This causes the socket to get in a 'stuck' state, preventing the client from reconnecting to the server. 2. More importantly, however, is that the fwrite in ast_http_websocket_write fails with a large volume of data when the client takes awhile to process the information. When it does fail, it fails writing only a portion of the bytes. With some debugging, it was shown that this was failing in a similar fashion to ASTERISK-12767. Switching this over to ast_careful_fwrite with a long enough timeout solved the problem. Note that this version of the patch, unlike r417310 in Asterisk 11, exposes configuration options beyond just chan_sip's sip.conf. Configuration options to configure the write timeout have also been added to pjsip.conf and ari.conf. #ASTERISK-23917 #close Reported by: Matt Jordan Review: https://reviewboard.asterisk.org/r/3624/ ........ Merged revisions 417310 from http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged revisions 417311 from http://svn.asterisk.org/svn/asterisk/branches/12 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@417317 65c4cc65-6c06-0410-ace0-fbb531ad65f3		12 years ago
..
acl.conf.sample	…
adsi.conf.sample	…
agents.conf.sample	Replace chan_agent with app_agent_pool.	13 years ago
alarmreceiver.conf.sample	Adds new formats to app_alarmreceiver, ALAW calls support and enhanced protection.	14 years ago
alsa.conf.sample	…
amd.conf.sample	…
app_mysql.conf.sample	…
app_skel.conf.sample	…
ari.conf.sample	res_http_websocket: Close websocket correctly and use careful fwrite	12 years ago
asterisk.adsi	…
asterisk.conf.sample	internal_timing: Remove the option and always make it enabled if a timing module is loaded.	12 years ago
calendar.conf.sample	…
ccss.conf.sample	…
cdr.conf.sample	…
cdr_adaptive_odbc.conf.sample	…
cdr_custom.conf.sample	…
cdr_manager.conf.sample	…
cdr_mysql.conf.sample	…
cdr_odbc.conf.sample	…
cdr_pgsql.conf.sample	…
cdr_sqlite3_custom.conf.sample	…
cdr_syslog.conf.sample	…
cdr_tds.conf.sample	…
cel.conf.sample	Update CEL sample config	13 years ago
cel_custom.conf.sample	…
cel_odbc.conf.sample	…
cel_pgsql.conf.sample	…
cel_sqlite3_custom.conf.sample	…
cel_tds.conf.sample	…
chan_dahdi.conf.sample	chan_dahdi: Adds support for major update to libss7.	12 years ago
chan_mobile.conf.sample	…
cli.conf.sample	…
cli_aliases.conf.sample	configs/cli_aliases.conf: Two new aliases, plus enhancements for context names.	12 years ago
cli_permissions.conf.sample	…
codecs.conf.sample	…
confbridge.conf.sample	ConfBridge: Correct prompt playback target	13 years ago
config_test.conf.sample	…
console.conf.sample	…
dbsep.conf.sample	…
dnsmgr.conf.sample	…
dsp.conf.sample	dsp.c User Configurable DTMF_HITS_TO_BEGIN and DTMF_MISSES_TO_END	14 years ago
dundi.conf.sample	…
enum.conf.sample	…
extconfig.conf.sample	chan_pjsip: Add alembic scripts for generating db tables for PJSIP	13 years ago
extensions.ael.sample	…
extensions.conf.sample	Add queue monitoring hints	14 years ago
extensions.lua.sample	Update extensions.lua.sample with naming conflict guidance.	12 years ago
extensions_minivm.conf.sample	…
features.conf.sample	configuration samples: Pull all parking related stuff out of features.conf	13 years ago
festival.conf.sample	…
followme.conf.sample	…
func_odbc.conf.sample	…
gtalk.conf.sample	…
h323.conf.sample	Add "autoframing" option to sip.conf.sample and h323.conf.sample.	13 years ago
hep.conf.sample	res_hep/res_hep_pjsip: Add a HEPv3 capture agent module and a logger for PJSIP	13 years ago
http.conf.sample	AST-2014-007: Fix DOS by consuming the number of allowed HTTP connections.	12 years ago
iax.conf.sample	chan_iax2: Block unnecessary control frames to/from the wire.	13 years ago
iaxprov.conf.sample	…
indications.conf.sample	indications.conf: add stutter tone; end properly	13 years ago
jabber.conf.sample	…
jingle.conf.sample	…
logger.conf.sample	verbosity: Fix performance of console verbose messages.	13 years ago
manager.conf.sample	manager: The eventfilter= option now takes an extended regex.	13 years ago
meetme.conf.sample	…
mgcp.conf.sample	…
minivm.conf.sample	…
misdn.conf.sample	Add named callgroups/pickupgroups	14 years ago
modules.conf.sample	…
motif.conf.sample	Add CLI configuration documentation	14 years ago
musiconhold.conf.sample	…
muted.conf.sample	…
ooh323.conf.sample	Introduce new config option 'aniasdni'. If yes then asterisk set dialed number as own id back to the caller	13 years ago
osp.conf.sample	…
oss.conf.sample	…
phone.conf.sample	…
phoneprov.conf.sample	…
pjsip.conf.sample	res_http_websocket: Close websocket correctly and use careful fwrite	12 years ago
pjsip_notify.conf.sample	res_pjsip_notify: Add documentation	13 years ago
queuerules.conf.sample	…
queues.conf.sample	queues.conf.sample Fix documented default for persistentmembers	13 years ago
res_config_mysql.conf.sample	…
res_config_sqlite.conf.sample	…
res_config_sqlite3.conf.sample	…
res_corosync.conf.sample	…
res_curl.conf.sample	…
res_fax.conf.sample	res_fax: Comment out default settings from res_fax.conf.	13 years ago
res_ldap.conf.sample	Add RFC 3327 Path header support to chan_sip	14 years ago
res_odbc.conf.sample	Fix documentation for default username in res_odbc	14 years ago
res_parking.conf.sample	configuration samples: Pull all parking related stuff out of features.conf	13 years ago
res_pgsql.conf.sample	…
res_pktccops.conf.sample	…
res_snmp.conf.sample	…
res_stun_monitor.conf.sample	…
rtp.conf.sample	Disable ICE support by default	14 years ago
say.conf.sample	…
sip.conf.sample	res_http_websocket: Close websocket correctly and use careful fwrite	12 years ago
sip_notify.conf.sample	…
skinny.conf.sample	Voicemail: Remove mailbox identifier format (box@context) assumptions in the system.	13 years ago
sla.conf.sample	astobj2-ify the SLA code	13 years ago
smdi.conf.sample	…
sorcery.conf.sample	Prevent duplicate sorcery wizards from being applied to sorcery object types.	13 years ago
ss7.timers.sample	chan_dahdi: Adds support for major update to libss7.	12 years ago
statsd.conf.sample	Example of how to use the Stasis message bus	13 years ago
telcordia-1.adsi	…
test_sorcery.conf.sample	Merge the sorcery data access layer API.	14 years ago
udptl.conf.sample	…
unistim.conf.sample	Introducing changes proposed to chan_unistim driver:	12 years ago
users.conf.sample	…
voicemail.conf.sample	configs/voicemail.conf.sample - Make mailcmd sample text more explicit	13 years ago
vpb.conf.sample	…
xmpp.conf.sample	Add CLI configuration documentation	14 years ago