You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Terry Wilson abc94089cd Merged revisions 293803 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.8 ........ r293803 | twilson | 2010-11-03 11:05:14 -0700 (Wed, 03 Nov 2010) | 25 lines Avoid valgrind warnings for ast_rtp_instance_get_xxx_address The documentation for ast_rtp_instance_get_(local/remote)_address stated that they returned 0 for success and -1 on failure. Instead, they returned 0 if the address structure passed in was already equivalent to the address instance local/remote address or 1 otherwise. 90% of the calls to these functions completely ignored the return address and passed in an uninitialized struct, which would make valgrind complain even though the operation was technically safe. This patch fixes the documentation and converts the get_xxx_address functions to void since all they really do is copy the address and cannot fail. Additionally two new functions (ast_rtp_instance_get_and_cmp_(local/remote)_address) are created for the 3 times where the return value was actually checked. The get_and_cmp_local_address function is currently unused, but exists for the sake of symmetry. The only functional change as a result of this change is that we will not do an ast_sockaddr_cmp() on (mostly uninitialized) addresses before doing the ast_sockaddr_copy() in the get_*_address functions. So, even though it is an API change, it shouldn't have a noticeable change in behavior. Review: https://reviewboard.asterisk.org/r/995/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293809 65c4cc65-6c06-0410-ace0-fbb531ad65f3		15 years ago
..
db1-ast	…
editline	Add gar to the check for AR for those silly OSes (Solaris) that don't have ar.	15 years ago
stdtime	Merged revisions 291791 via svnmerge from	15 years ago
Makefile	Support for GNU/kFreeBSD	15 years ago
abstract_jb.c	Fix jitterbuffer logging not creating logfiles.	15 years ago
acl.c	Merged revisions 291758 via svnmerge from	15 years ago
alaw.c	…
aoc.c	Generic Advice of Charge.	15 years ago
app.c	Whitespace cleanup	15 years ago
ast_expr2.c	Merged revisions 293197 via svnmerge from	15 years ago
ast_expr2.fl	…
ast_expr2.h	Merged revisions 293197 via svnmerge from	15 years ago
ast_expr2.y	Merged revisions 293197 via svnmerge from	15 years ago
ast_expr2f.c	Fix some doxygen warnings.	15 years ago
asterisk.c	Merged revisions 290864 via svnmerge from	15 years ago
asterisk.dynamics	Remove the old stub files, preferring the optional_api method.	15 years ago
asterisk.exports.in	Merged revisions 288640 via svnmerge from	15 years ago
astfd.c	…
astmm.c	…
astobj2.c	Improve some very confusing structure names in astobj2.c	15 years ago
audiohook.c	Merged revisions 279949 via svnmerge from	15 years ago
autochan.c	…
autoservice.c	Merged revisions 278167 via svnmerge from	15 years ago
bridging.c	pthread_join to assure the thread is really gone	15 years ago
buildinfo.c	…
callerid.c	ast_callerid restructuring	15 years ago
ccss.c	Merged revisions 282098 via svnmerge from	15 years ago
cdr.c	Merged revisions 287116 via svnmerge from	15 years ago
cel.c	Merged revisions 283230 via svnmerge from	15 years ago
channel.c	Merged revisions 292704 via svnmerge from	15 years ago
chanvars.c	…
cli.c	Merged revisions 291075 via svnmerge from	15 years ago
config.c	Merged revisions 283882 via svnmerge from	15 years ago
cygload.c	…
data.c	Kill some startup warnings and errors and make some messages more helpful in tracking down the source.	15 years ago
datastore.c	Merged revisions 273565 via svnmerge from	15 years ago
db.c	Merged revisions 286112 via svnmerge from	15 years ago
devicestate.c	Merged revisions 263639 via svnmerge from	15 years ago
dial.c	ast_callerid restructuring	15 years ago
dns.c	…
dnsmgr.c	Merged revisions 287895 via svnmerge from	15 years ago
dsp.c	Set threshold for silence detection defaults to 256	15 years ago
ecdisa.h	…
enum.c	…
event.c	Resolve an invalid memory read on an event.	15 years ago
features.c	Merged revisions 289340 via svnmerge from	15 years ago
file.c	Merged revisions 290576 via svnmerge from	15 years ago
fixedjitterbuf.c	Fix various typos reported by Lintian	15 years ago
fixedjitterbuf.h	…
frame.c	adds speex 16khz audio support	15 years ago
framehook.c	Merged revisions 287647 via svnmerge from	15 years ago
fskmodem.c	…
fskmodem_float.c	…
fskmodem_int.c	…
global_datastores.c	Add SRTP support for Asterisk	15 years ago
hashtab.c	…
heap.c	Fix handling of removing nodes from the middle of a heap.	15 years ago
http.c	Enable IPv6 for the built-in HTTP server.	15 years ago
image.c	…
indications.c	Add doxygen docs for indications.c	15 years ago
io.c	…
jitterbuf.c	…
loader.c	Merged revisions 284610 via svnmerge from	15 years ago
lock.c	Attempt to fix FreeBSD build problem.	15 years ago
logger.c	Merged revisions 287863 via svnmerge from	15 years ago
manager.c	Merged revisions 293611 via svnmerge from	15 years ago
md5.c	…
netsock.c	Support for GNU/kFreeBSD	15 years ago
netsock2.c	Merged revisions 292188 via svnmerge from	15 years ago
pbx.c	Merged revisions 290713 via svnmerge from	15 years ago
plc.c	…
poll.c	Merged revisions 285268 via svnmerge from	15 years ago
privacy.c	…
rtp_engine.c	Merged revisions 293803 via svnmerge from	15 years ago
say.c	Whitespace cleanup	15 years ago
sched.c	Merged revisions 281575 via svnmerge from	15 years ago
security_events.c	…
sha1.c	…
slinfactory.c	…
srv.c	Formatting changes	15 years ago
ssl.c	…
strcompat.c	Merged revisions 289104 via svnmerge from	15 years ago
strings.c	fixes segfault on logging	15 years ago
stun.c	Merged revisions 284597 via svnmerge from	15 years ago
syslog.c	…
taskprocessor.c	…
tcptls.c	Add IPv6 to Asterisk.	15 years ago
tdd.c	…
term.c	Merged revisions 269334 via svnmerge from	15 years ago
test.c	Kill some startup warnings and errors and make some messages more helpful in tracking down the source.	15 years ago
threadstorage.c	…
timing.c	…
translate.c	Merged revisions 282047 via svnmerge from	15 years ago
udptl.c	Allow IPv6 addresses for UDPTL streams.	15 years ago
ulaw.c	…
utils.c	Merged revisions 281085 via svnmerge from	15 years ago
xml.c	Asterisk data retrieval API.	15 years ago
xmldoc.c	Add method for finding XML doc files for systems that don't support GLOB_BRACE.	15 years ago