asterisk

History

Terry Wilson abc94089cd Merged revisions 293803 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........ r293803 \| twilson \| 2010-11-03 11:05:14 -0700 (Wed, 03 Nov 2010) \| 25 lines Avoid valgrind warnings for ast_rtp_instance_get_xxx_address The documentation for ast_rtp_instance_get_(local/remote)_address stated that they returned 0 for success and -1 on failure. Instead, they returned 0 if the address structure passed in was already equivalent to the address instance local/remote address or 1 otherwise. 90% of the calls to these functions completely ignored the return address and passed in an uninitialized struct, which would make valgrind complain even though the operation was technically safe. This patch fixes the documentation and converts the get_xxx_address functions to void since all they really do is copy the address and cannot fail. Additionally two new functions (ast_rtp_instance_get_and_cmp_(local/remote)_address) are created for the 3 times where the return value was actually checked. The get_and_cmp_local_address function is currently unused, but exists for the sake of symmetry. The only functional change as a result of this change is that we will not do an ast_sockaddr_cmp() on (mostly uninitialized) addresses before doing the ast_sockaddr_copy() in the get_*_address functions. So, even though it is an API change, it shouldn't have a noticeable change in behavior. Review: https://reviewboard.asterisk.org/r/995/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293809 65c4cc65-6c06-0410-ace0-fbb531ad65f3		15 years ago
..
asterisk	Merged revisions 293803 via svnmerge from	15 years ago
solaris-compat	fix the provided unsetenv for solaris to return an int like it's supposed to	19 years ago
asterisk.h	Revert attempt to standardize with _POSIX_C_SOURCE.	16 years ago
jitterbuf.h	incorporates r159808 from branches/1.4:	17 years ago