You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Steve Murphy e3700a13a4 This merges the masqpark branch into 1.4 ... These changes eliminate the need for (and use of) the KEEPALIVE return code in res_features.c; There are other places that use this result code for similar purposes at a higher level, these appear to be left alone in 1.4, but attacked in trunk. The reason these changes are being made in 1.4, is that parking ends a channel's life, in some situations, and the code in the bridge (and some other places), was not checking the result code properly, and dereferencing the channel pointer, which could lead to memory corruption and crashes. Calling the masq_park function eliminates this danger in higher levels. A series of previous commits have replaced some parking calls with masq_park, but this patch puts them ALL to rest, (except one, purposely left alone because a masquerade is done anyway), and gets rid of the code that tests the KEEPALIVE result, and the NOHANGUP_PEER result codes. While bug 13820 inspired this work, this patch does not solve all the problems mentioned there. I have tested this patch (again) to make sure I have not introduced regressions. Crashes that occurred when a parked party hung up while the parking party was listening to the numbers of the parking stall being assigned, is eliminated. These are the cases where parking code may be activated: 1. Feature one touch (eg. *3) 2. Feature blind xfer to parking lot (eg ##700) 3. Run Park() app from dialplan (eg sip xfer to 700) (eg. dahdi hookflash xfer to 700) 4. Run Park via manager. The interesting testing cases for parking are: I. A calls B, A parks B a. B hangs up while A is getting the numbers announced. b. B hangs up after A gets the announcement, but before the parking time expires c. B waits, time expires, A is redialed, A answers, B and A are connected, after which, B hangs up. d. C picks up B while still in parking lot. II. A calls B, B parks A a. A hangs up while B is getting the numbers announced. b. A hangs up after B gets the announcement, but before the parking time expires c. A waits, time expires, B is redialed, B answers, A and B are connected, after which, A hangs up. d. C picks up A while still in parking lot. Testing this throroughly involves acting all the permutations of I and II, in situations 1,2,3, and 4. Since I added a few more changes (ALL references to KEEPALIVE in the bridge code eliimated (I missed one earlier), I retested most of the above cases, and no crashes. H-extension weirdness. Current h-extension execution is not completely correct for several of the cases. For the case where A calls B, and A parks B, the 'h' exten is run on A's channel as soon as the park is accomplished. This is expected behavior. But when A calls B, and B parks A, this will be current behavior: After B parks A, B is hung up by the system, and the 'h' (hangup) exten gets run, but the channel mentioned will be a derivative of A's... Thus, if A is DAHDI/1, and B is DAHDI/2, the h-extension will be run on channel Parked/DAHDI/1-1<ZOMBIE>, and the start/answer/end info will be those relating to Channel A. And, in the case where A is reconnected to B after the park time expires, when both parties hang up after the joyful reunion, no h-exten will be run at all. In the case where C picks up A from the parking lot, when either A or C hang up, the h-exten will be run for the C channel. CDR's are a separate issue, and not addressed here. As to WHY this strange behavior occurs, the answer lies in the procedure followed to accomplish handing over the channel to the parking manager thread. This procedure is called masquerading. In the process, a duplicate copy of the channel is created, and most of the active data is given to the new copy. The original channel gets its name changed to XXX<ZOMBIE> and keeps the PBX information for the sake of the original thread (preserving its role as a call originator, if it had this role to begin with), while the new channel is without this info and becomes a call target (a "peer"). In this case, the parking lot manager thread is handed the new (masqueraded) channel. It will not run an h-exten on the channel if it hangs up while in the parking lot. The h exten will be run on the original channel instead, in the original thread, after the bridge completes. See bug 13820 for our intentions as to how to clean up the h exten behavior. Review: http://reviewboard.digium.com/r/29/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@166093 65c4cc65-6c06-0410-ace0-fbb531ad65f3		18 years ago
..
Makefile	remove this, it has been moved to the main Makefile	18 years ago
app_adsiprog.c	fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends	18 years ago
app_alarmreceiver.c	…
app_amd.c	From bugtracker: "fix totalAnalysisTime to handle periods of no channel activity"	19 years ago
app_authenticate.c	fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends	18 years ago
app_cdr.c	…
app_chanisavail.c	…
app_channelredirect.c	…
app_chanspy.c	Ensure that the chanspy datastore is fully initialized.	18 years ago
app_controlplayback.c	Make sure res is a positive value before performing the check to determine whether the user stopped it or not.	19 years ago
app_dahdibarge.c	(closes issue #13480)	18 years ago
app_dahdiras.c	build against the now-typedef-free dahdi/user.h	18 years ago
app_dahdiscan.c	(closes issue #13480)	18 years ago
app_db.c	…
app_dial.c	This merges the masqpark branch into 1.4	18 years ago
app_dictate.c	…
app_directed_pickup.c	Add 'down' as a valid state for directed call pickup. This creeps up when we receive session progress when dialing a device and not ringing.	18 years ago
app_directory.c	Fix some memory leaks found while looking at how realtime	18 years ago
app_disa.c	Allow DISA to handle extensions that start with #.	18 years ago
app_dumpchan.c	…
app_echo.c	…
app_exec.c	Fix a minor spelling error.	19 years ago
app_externalivr.c	Detect another way for a connection to have gone away.	19 years ago
app_festival.c	Fix double declaration of 'x' on the PPC platform.	18 years ago
app_flash.c	build against the now-typedef-free dahdi/user.h	18 years ago
app_followme.c	Do not crash if we are not passed in a followme id.	18 years ago
app_forkcdr.c	(closes issue #12910)	18 years ago
app_getcpeid.c	Adds DAHDI support alongside Zaptel. DAHDI usage favored, but all Zap stuff should continue working. Release announcement to follow.	18 years ago
app_hasnewvoicemail.c	Check to make sure a value has been given to the VMCOUNT dialplan function.	19 years ago
app_ices.c	make app_ices compile on OpenBSD.	18 years ago
app_image.c	…
app_ivrdemo.c	…
app_lookupblacklist.c	…
app_lookupcidname.c	…
app_macro.c	Reverse the fix from issue #6176 and add proper handling for that issue.	18 years ago
app_meetme.c	(closes issue #13480)	18 years ago
app_milliwatt.c	- Fix a typo in the argument to Playtones	18 years ago
app_mixmonitor.c	Add a trigger mode that triggers on both read and write. The actual function that returns the combined audio frame though will wait until both sides have fed in audio, or until one side stops (such as the case when you call Wait).	19 years ago
app_morsecode.c	Allow app_morsecode to build on PPC Linux by putting the value of the digit char in an int.	19 years ago
app_mp3.c	…
app_nbscat.c	…
app_osplookup.c	Fixed OSP module did not report source/devinfo IP in correct format.	19 years ago
app_page.c	Adds DAHDI support alongside Zaptel. DAHDI usage favored, but all Zap stuff should continue working. Release announcement to follow.	18 years ago
app_parkandannounce.c	(closes issue #12193)	18 years ago
app_playback.c	Ensure that help text terminates with a newline	19 years ago
app_privacy.c	…
app_queue.c	This merges the masqpark branch into 1.4	18 years ago
app_random.c	…
app_read.c	Adds DAHDI support alongside Zaptel. DAHDI usage favored, but all Zap stuff should continue working. Release announcement to follow.	18 years ago
app_readfile.c	…
app_realtime.c	Fix some memory leaks found while looking at how realtime	18 years ago
app_record.c	…
app_rpt.c	System call ioperm is non-portable, so check for its existence in autoconf.	18 years ago
app_sayunixtime.c	…
app_senddtmf.c	…
app_sendtext.c	Fix a bug where SENDTEXTSTATUS isn't set properly when it isn't	18 years ago
app_setcallerid.c	For consistency sake, ensure that the values that ${CALLINGPRES} returns are valid as an	19 years ago
app_setcdruserfield.c	…
app_settransfercapability.c	…
app_skel.c	Revert inadvertent changes to app_skel that occurred when	18 years ago
app_sms.c	fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends	18 years ago
app_softhangup.c	…
app_speech_utils.c	If we receive DTMF make sure that the state of the speech structure goes back to being not ready. (issue #LUMENVOX-8)	18 years ago
app_stack.c	Don't execute a gosub if the arguments is zero-len (not just NULL)	19 years ago
app_system.c	The System() and TrySystem() applications can take a substantial amount of	19 years ago
app_talkdetect.c	…
app_test.c	…
app_transfer.c	…
app_url.c	…
app_userevent.c	…
app_verbose.c	…
app_voicemail.c	Add mutexes around accesses to the IMAP library interface. This prevents	18 years ago
app_waitforring.c	…
app_waitforsilence.c	Check correct values in the return of ast_waitfor(); also, get rid of a	18 years ago
app_while.c	ast_waitfordigit() requires that the channel be up, for no good logical	18 years ago
app_zapateller.c	An empty string is an empty callerid ... so zap it. This closes issue #10502, which was pointed out by dswartz. Thank you, and may the swartz be with you	19 years ago
enter.h	…
leave.h	…
rpt_flow.pdf	…