You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Mark Michelson bd716c50fd Recorded merge of revisions 254452 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r254452 | mmichelson | 2010-03-25 10:59:56 -0500 (Thu, 25 Mar 2010) | 44 lines Several fixes regarding RFC2833 DTMF detection. Here is a copy and paste of the details from my request on reviewboard that dealt with these changes: Fix 1. The first change in place is to fix Mantis issue 15811, which deals with a situation where Asterisk will incorrectly interpret out of order RFC2833 frames as duplicate DTMF digits. For instance, we would receive a sequence like: seqno 1: DTMF 1 seqno 2: DTMF 1 seqno 3: DTMF 1 seqno 4: DTMF 1 seqno 6: DTMF 1 (end) seqno 5: DTMF 1 seqno 7: DTMF 1 (end) seqno 8: DTMF 1 (end) Prior to this patch when we received the frame with seqno 5, we would interpret this as a new DTMF 1. With this patch, we will check the seqno of the incoming digit and not process the frame if the seqno is lower than the last recorded seqno. Note that we do not record the seqno of the dropped DTMF frame for future processing. While the above situation is what was designed to be fixed, the patch is written in such a way that the following would also be fixed too: seqno 9: DTMF 1 seqno 10: DTMF 1 (end) seqno 11: DTMF 1 (end) seqno 13: DTMF 2 seqno 12: DTMF 1 (end) seqno 14: DTMF 2 seqno 15: DTMF 2 (end) seqno 16: DTMF 2 (end) seqno 17: DTMF 2 (end) In this second situation, the beginning of the DTMF 2 arrives before the final end frame of the DTMF 1. With the patch, seqno 12 is no processed and thus we properly interpret the DTMF. Fix 2. The second change in place is to fix an issue like the following: seqno 1: DTMF 1 seqno 2: DTMF 1 seqno 3: DTMF 1 (end) *packet lost* seqno 4: DTMF 1 (end) *packet lost* seqno 5: DTMF 1 (end) *packet lost* seqno 6: DTMF 2 When we receive seqno 6, we had code in place that was supposed to properly end the previously unended DTMF 1. The problem was that the code was essentially a no-op. The code would set up an end frame for the DTMF 1 but would immediately overwrite the frame with the begin for DTMF 2. I changed process_dtmf_rfc2833() so that instead of returning a single frame, it is given as an output parameter a list of frames. Each frame that needs to be returned is appended to this list. Fix 3. The final change is a minor one where an AST_CONTROL_SRCCHANGE frame could get lost. If we process a cisco DTMF or an RFC 3389 frame and no frame was returned, then we would return &ast_null_frame. The problem is that earlier in the function, we may have generated an AST_CONTROL_SRCCHANGE frame and put it in the list of frames we wish to return. This frame would be lost in such a case. The patch fixes this problem ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@254454 65c4cc65-6c06-0410-ace0-fbb531ad65f3		17 years ago
..
ael	When we call a gosub routine, the variables should be scoped to avoid contaminating the caller.	17 years ago
ais	…
snmp	Finish implementaton of astobj2 OBJ_MULTIPLE, and convert ast_channel_iterator to use it.	17 years ago
Makefile	Change per-file debug and verbose levels to be per-module, the way	17 years ago
res_adsi.c	More 32->64 bit codec conversions.	17 years ago
res_adsi.exports	…
res_ael_share.c	…
res_ael_share.exports	…
res_agi.c	handle_speechset has 4 arguments.	17 years ago
res_agi.exports	…
res_ais.c	…
res_calendar.c	Fix INTERNAL_OBJ error on stop when calendars.conf missing	17 years ago
res_calendar.exports	…
res_calendar_caldav.c	Fix crash on 32-bit for users not using https	17 years ago
res_calendar_exchange.c	Fix crash on 32-bit for users not using https	17 years ago
res_calendar_icalendar.c	Fix crash on 32-bit for users not using https	17 years ago
res_clialiases.c	Include an extra newline after "Aliased CLI command" to get back the prompt.	17 years ago
res_clioriginate.c	…
res_config_curl.c	…
res_config_ldap.c	Plug a memory leak in res_config_ldap.	17 years ago
res_config_odbc.c	…
res_config_pgsql.c	fixes pgsql double free of threadstorage	17 years ago
res_config_sqlite.c	…
res_convert.c	…
res_crypto.c	…
res_curl.c	…
res_fax.c	Improve handling of T.38 re-INVITEs that arrive before a T.38-capable	17 years ago
res_fax.exports	Merge res_fax and res_fax_spandsp.	17 years ago
res_fax_spandsp.c	Updated CHANGES file to mention res_fax and res_fax_spandsp.	17 years ago
res_features.exports	…
res_http_post.c	Don't prepend the URI prefix to the post directory	17 years ago
res_jabber.c	Prevent a crash when a buddy gets offline.	17 years ago
res_jabber.exports	…
res_limit.c	…
res_monitor.c	Merged revisions 254235 via svnmerge from	17 years ago
res_monitor.exports	…
res_musiconhold.c	Merged revisions 250786 via svnmerge from	17 years ago
res_mutestream.c	…
res_odbc.c	Recorded merge of revisions 222152 via svnmerge from	17 years ago
res_odbc.exports	…
res_phoneprov.c	Instead of crashing, allocate our header ast_str before we try to use it.	17 years ago
res_pktccops.c	Socket level option is SOL_SOCKET, not SO_SOCKET.	17 years ago
res_pktccops.exports	res_pktccops needs to be able to export a symbol for chan_mgcp	17 years ago
res_realtime.c	…
res_rtp_asterisk.c	Recorded merge of revisions 254452 via svnmerge from	17 years ago
res_rtp_multicast.c	Expand codec bitfield from 32 bits to 64 bits.	17 years ago
res_security_log.c	…
res_smdi.c	Convert a few places to use ast_calloc_with_stringfields where applicable.	17 years ago
res_smdi.exports	…
res_snmp.c	…
res_speech.c	Revert an errant part of a previous cleanup, to fix a memory corruption issue.	17 years ago
res_speech.exports	…
res_timing_dahdi.c	…
res_timing_pthread.c	…
res_timing_timerfd.c	Clarify error message in res_timing_timerfd.	17 years ago