You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Matthew Jordan e7d49d28ea Fix a performance problem CDRs ... There is a large performance price currently in the CDR engine. We currently perform two ao2_callback calls on a container that has an entry for every channel in the system. This is done to create matching pairs between channels in a bridge. As such, the portion of the CDR logic that this patch deals with is how we make pairings when a channel enters a mixing bridge. In general, when a channel enters such a bridge, we need to do two things: (1) Figure out if anyone in the bridge can be this channel's Party B. (2) Make pairings with every other channel in the bridge that is not already our Party B. This is a two step process. In the first step, we look through everyone in the bridge and see if they can be our Party B (single_state_process_bridge_enter). If they can - yay! We mark our CDR as having gotten a Party B. If not, we keep searching. If we don't find one, we wait until someone joins who can be our Party B. Step 2 is where we changed the logic (handle_bridge_pairings and bridge_candidate_process). Previously, we would first find candidates - those channels in the bridge with us - from the active_cdrs_by_channel container. Because a channel could be a candidate if it was Party B to an item in the container, the code implemented multiple ao2_container callbacks to get all the candidates. We also had to store them in another container with some other meta information. This was rather complex and costly, particularly if you have 300 Local channels (600 channels!) going at once. Luckily, none of it is needed: when a channel enters a bridge (which is when we're figuring all this stuff out), the bridge snapshot tells us the unique IDs of everyone already in the bridge. All we need to do is: For all channels in the bridge: If the channel is us or our Party B that we got in step 1, skip it Compare us and the candidate to figure out who is Party A (based on some specific rules) If we are Party A: Make a new CDR for us, append it to our chain, and set the candidate as Party B If they are Party A: If they don't have a Party B: Make a new CDR for them, append us to their chain, and us as Party B Otherwise: Copy us over as Party B on their existing CDR. This patch does that. Because we now use channel unique IDs to find the candidates during bridging, active_cdrs_by_channel now looks up things using uniqueid instead of channel name. This makes the more complex code simpler; it does, however, have the drawback that dialplan applications and functions will be slightly slower as they have to iterate through the container looking for the CDR by name. That's a small price to pay however as the bridging code will be called a lot more often. This patch also does two other minor changes: (1) It reduces the container size of the channels in a bridge snapshot to 1. In order to be predictable for multi-party bridges, the order of the channels in the container must be stable; that is, it must always devolve to a linked list. (2) CDRs and the multi-party test was updated to show the relationship between two dialed channels. You still want to know if they talked - previously, dialed channels were always ignored, which is wrong when they have managed to get a Party B. (closes issue ASTERISK-22488) Reported by: Richard Mudgett Review: https://reviewboard.asterisk.org/r/2861/ ........ Merged revisions 399666 from http://svn.asterisk.org/svn/asterisk/branches/12 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@399667 65c4cc65-6c06-0410-ace0-fbb531ad65f3		12 years ago
..
Makefile	Title update	13 years ago
test_abstract_jb.c	Doxygen comment tweaks.	12 years ago
test_acl.c	Silence a warning message from older versions of GCC.	13 years ago
test_ami_security_events.sh	Add an API for reporting security events, and a security event logging module.	16 years ago
test_amihooks.c	Merged revisions 338556 via svnmerge from	14 years ago
test_aoc.c	Merged revisions 332177 via svnmerge from	14 years ago
test_app.c	Change ast_hangup() to return void and be NULL safe.	12 years ago
test_ari.c	Rename everything Stasis-HTTP to ARI	12 years ago
test_ari_model.c	Fix module load errors for test_ari_model.so.	12 years ago
test_ast_format_str_reduce.c	Merged revisions 332177 via svnmerge from	14 years ago
test_astobj2.c	Merged revisions 376575 via svnmerge from	13 years ago
test_astobj2_thrash.c	Merged revisions 376341,376344-376345 via svnmerge from	13 years ago
test_bucket.c	Fix bucket unit tests	12 years ago
test_cdr.c	Fix a performance problem CDRs	12 years ago
test_cel.c	Restore Dial, Queue, and FollowMe 'I' option support.	12 years ago
test_config.c	Fix the config_options_test	12 years ago
test_db.c	app_queue: Support persisting and loading of long member lists.	13 years ago
test_devicestate.c	Split caching out from the stasis_caching_topic.	12 years ago
test_dlinklists.c	Merged revisions 338556 via svnmerge from	14 years ago
test_endpoints.c	Few more menuselect fixes missed in r392777	12 years ago
test_event.c	Refactor CEL to avoid using the event system core	12 years ago
test_expr.c	Merged revisions 332177 via svnmerge from	14 years ago
test_format_api.c	Audit of ao2_iterator_init() usage for v10.	14 years ago
test_func_file.c	Merged revisions 332177 via svnmerge from	14 years ago
test_gosub.c	Doxygen Updates Janitor Work	13 years ago
test_hashtab_thrash.c	Tweak comment for why usleep is used.	12 years ago
test_heap.c	Merged revisions 332177 via svnmerge from	14 years ago
test_jitterbuf.c	Doxygen comment tweaks.	12 years ago
test_json.c	Address JSON thread safety issues.	12 years ago
test_linkedlists.c	Clean up and ensure proper usage of alloca()	13 years ago
test_locale.c	Merged revisions 338556 via svnmerge from	14 years ago
test_logger.c	Merged revisions 338556 via svnmerge from	14 years ago
test_netsock2.c	Add a unit test for ast_sockaddr_split_hostport	14 years ago
test_optional_api.c	optional_api: Fix linking problems between modules that export global symbols	12 years ago
test_pbx.c	Merged revisions 337062 via svnmerge from	14 years ago
test_poll.c	Add leading and trailing backslashes	13 years ago
test_res_stasis.c	Update events to use Swagger 1.3 subtyping, and related aftermath	12 years ago
test_sched.c	Merged revisions 332177 via svnmerge from	14 years ago
test_scoped_lock.c	I forgot to add the unit tests for scoped locks earlier today.	13 years ago
test_security_events.c	Stasis: Update security events to use Stasis	12 years ago
test_skel.c	Merged revisions 332177 via svnmerge from	14 years ago
test_sorcery.c	Fix sorcery unit tests	12 years ago
test_sorcery_astdb.c	Fix sorcery unit tests	12 years ago
test_sorcery_realtime.c	Fix sorcery unit tests	12 years ago
test_stasis.c	Stasis: address refcount races; implementation comments	12 years ago
test_stasis_channels.c	Update events to use Swagger 1.3 subtyping, and related aftermath	12 years ago
test_stasis_endpoints.c	Split caching out from the stasis_caching_topic.	12 years ago
test_stringfields.c	Add aggregate operations for stuctures with string fields	12 years ago
test_strings.c	This patch adds a RESTful HTTP interface to Asterisk.	12 years ago
test_substitution.c	test_substitution: Fix failing test.	12 years ago
test_taskprocessor.c	Add a serializer interface to the threadpool	12 years ago
test_threadpool.c	Add a serializer interface to the threadpool	12 years ago
test_time.c	Merged revisions 332177 via svnmerge from	14 years ago
test_utils.c	ARI - channel recording support	12 years ago
test_uuid.c	Add uuid wrapper API call ast_uuid_generate_str().	12 years ago
test_voicemail_api.c	unit tests: test_voicemail_api leaks stringfields from snapshots	12 years ago
test_xml_escape.c	Merged revisions 378935 via svnmerge from	13 years ago