6380 Commits (eebc98fa44b1bc61d16ea5367236ffee3db5ac65)

Author	SHA1	Message	Date
Joshua Colp	4d8cd2efbe	manager: Use separate lock for session event notification. ... When notifying a manager session that new events were available the same lock was used that was also held when doing things within the session (such as sending events out). If the manager session blocked for a period of time this would cause a back up of messages in Stasis and would also block any other sessions from receiving events. This change adds a separate lock to the manager session which is strictly used for notifying it that new events are available. ASTERISK-28350 Change-Id: Ifbcac007faca9ad0231640f5e82a6ca9228f261b	7 years ago
Matthew Fredrickson	ce5bed44e4	main/taskprocessor: Increase max name length of taskprocessors ... Since the new names went in, the maximum taskprocessor name is too short. This patch increases the name field to a length to better handle the new names. Change-Id: I32f32d6926f25c8ef5a91303fd2988d2c2858877	7 years ago
Friendly Automation	c7d29cdcf2	Merge "sorcery.c: Sorcery enhancements for wizard management" into 16	7 years ago
George Joseph	7bdde83f2c	sorcery.c: Sorcery enhancements for wizard management ... Added ability to specifiy a wizard is read-only when applying it to a specific object type. This allows you to specify create, update and delete callbacks for the wizard but limit which object types can use them. Added the ability to allow an object type to have multiple wizards of the same type. This is indicated when a wizard is added to a specific object type. Added 3 new sorcery wizard functions: * ast_sorcery_object_type_insert_wizard which does the same thing as the existing ast_sorcery_insert_wizard_mapping function but accepts the new read-only and allot-duplicates flags and also returns the ast_sorcery_wizard structure used and it's internal data structure. This allows immediate use of the wizard's callbacks without having to register a "wizard mapped" observer. * ast_sorcery_object_type_apply_wizard which does the same thing as the existing ast_sorcery_apply_wizard_mapping function but has the added capabilities of ast_sorcery_object_type_insert_wizard. * ast_sorcery_object_type_remove_wizard which removes a wizard matching both its name and its original argument string. * The original logic in __ast_sorcery_insert_wizard_mapping was moved to __ast_sorcery_object_type_insert_wizard and enhanced for the new capabilities, then __ast_sorcery_insert_wizard_mapping was refactored to just call __ast_sorcery_insert_wizard_mapping. * Added a unit test to test_sorcery.c to test the read-only capability. Change-Id: I40f35840252e4313d99e11dbd80e270a3aa10605	7 years ago
George Joseph	aba1053a12	Merge "app.c: Remove deletion of pool topic on mwi state delete" into 16	7 years ago
Richard Mudgett	0426e0fede	taskprocessor.c: Fix printf type mismatch ... A size_t is not always an unsigned long. * Use the %zu format specifier in the ast_cli() printf format string since AST_VECTOR_SIZE() returns a size_t value. Change-Id: Ib102dd36bbe6c2a7a4ce6870ae9110d978dd7e98	7 years ago
George Joseph	f5f977baec	app.c: Remove deletion of pool topic on mwi state delete ... As part of an earlier voicemail refactor, ast_delete_mwi_state_full was modified to remove the pool topic for a mailbox when the state was deleted. This was an attempt to prevent stale topics from accumulating when app_voicemail was reloaded and a mailbox went away. Unfortunately because of the fact that when app_voicemail reloads, ALL mailboxes are deleted then only current ones recreated, topics were being removed from the pool that still had subscribers on them, then recreated as new topics of the same name. So now modules like res_pjsip_mwi are listening on a topic that will never receive any messages because app_voicemail is publishing on a different topic that happens to have the same name. The solutiuon to this is not easy and given that accumulating topics for deleted mailboxes is less evil that not sending NOTIFYs... * Removed the call to stasis_topic_pool_delete_topic in ast_delete_mwi_state_full. Also: * Fixed a topic reference leak in res_pjsip_mwi mwi_stasis_subscription_alloc. * Added some debugging to mwi_stasis_subscription_alloc, stasis_topic_create, and topic_dtor. * Fixed a topic reference leak in an error path in internal_stasis_subscribe. ASTERISK-28306 Reported-by: Jared Hull Change-Id: Id7da0990b3ac4be4b58491536b35f41291247b27	7 years ago
Joshua C. Colp	3e5dcc9dcf	Merge "stasis: Improve topic/subscription names and statistics." into 16	7 years ago
Joshua Colp	b886fef66e	stasis: Improve topic/subscription names and statistics. ... Topic names now follow: <subsystem>:<functionality>[/<object>] This ensures that they are all unique, and also provides better insight in to what each topic is for. Subscriber ids now also use the main topic name they are subscribed to and an incrementing integer as their identifier to make it easier to understand what the subscription is primarily responsible for. Both the CLI commands for listing topic and subscription statistics now sort to make it a bit easier to see what is going on. Subscriptions will now show all topics that they are receiving messages from, not just the main topic they were subscribed to. ASTERISK-28335 Change-Id: I484e971a38c3640f2bd156282e532eed84bf220d	7 years ago
Corey Farrell	641b6041c7	jansson: json_pack with new format to verify required runtime version. ... Add a json_pack at startup that will fail if runtime links against a library older than jansson-2.11. Change-Id: I101aebafe0f9407650206f7c552dad3d69377b5a	7 years ago
sungtae kim	0d7012044a	bridging: Add creation timestamps ... This small feature will help to checking the bridge's status to figure out which bridge is in old/zombie or not. Also added detail items for the 'bridge show *' cli to provide more detail info. And added creation item to the ARI as well. ASTERISK-28279 Change-Id: I460238c488eca4d216b9176576211cb03286e040	7 years ago
Joshua C. Colp	aefc501913	Merge "http.c: Support separated HTTP request" into 16	7 years ago
Joshua C. Colp	8b3579a7e5	Merge "taskprocessor: Enable subsystems and overload by subsystem" into 16	7 years ago
Sungtae Kim	a1391aa26b	http.c: Support separated HTTP request ... Currently, the Asterisk does not support seperated HTTP request. This patch make the Asterisk enables to wait lest part of HTTP request. Also increases acceptable HTTP body length to 40k to support more larger request. ASTERISK-28236 Change-Id: I48a401aa64a21c3b37bf3cb4e0486d64b7dd8aa1	7 years ago
Joshua C. Colp	4b6c60b362	stasis: Store subscriber uniqueids with topic statistics. ... This change provides an easier mechanism to determine which subscribers are subscribed to a topic. Using this you can inspect the specific subscribers for further details. Change-Id: I8deea21703cd5c5357b85593b46c3eaf24e18c0c	7 years ago
George Joseph	2f8def1453	taskprocessor: Enable subsystems and overload by subsystem ... To prevent one subsystem's taskprocessors from causing others to stall, new capabilities have been added to taskprocessors. * Any taskprocessor name that has a '/' will have the part before the '/' saved as its "subsystem". Examples: "sorcery/acl-0000006a" and "sorcery/aor-00000019" will be grouped to subsystem "sorcery". "pjsip/distributor-00000025" and "pjsip/distributor-00000026" will bn grouped to subsystem "pjsip". Taskprocessors with no '/' have an empty subsystem. * When a taskprocessor enters high-water alert status and it has a non-empty subsystem, the subsystem alert count will be incremented. * When a taskprocessor leaves high-water alert status and it has a non-empty subsystem, the subsystem alert count will be decremented. * A new api ast_taskprocessor_get_subsystem_alert() has been added that returns the number of taskprocessors in alert for the subsystem. * A new CLI command "core show taskprocessor alerted subsystems" has been added. * A new unit test was addded. REMINDER: The taskprocessor code itself doesn't take any action based on high-water alerts or overloading. It's up to taskprocessor users to check and take action themselves. Currently only the pjsip distributor does this. * A new pjsip/global option "taskprocessor_overload_trigger" has been added that allows the user to select the trigger mechanism the distributor uses to pause accepting new requests. "none": Don't pause on any overload condition. "global": Pause on ANY taskprocessor overload (the default and current behavior) "pjsip_only": Pause only on pjsip taskprocessor overloads. * The core pjsip pool was renamed from "SIP" to "pjsip" so it can be properly grouped into the "pjsip" subsystem. * stasis taskprocessor names were changed to "stasis" as the subsystem. * Sorcery core taskprocessor names were changed to "sorcery" to match the object taskprocessors. Change-Id: I8c19068bb2fc26610a9f0b8624bdf577a04fcd56	7 years ago
Kevin Harwell	e85f92f37a	json.c/strings.c - Add a couple of utility functions ... Added 'ast_json_object_string_get' to the JSON wrapper in order to make it a little easier to retrieve a string field from the JSON object. Also added an 'ast_strings_equal' function that safely checks (checks for NULLs) for equality between two strings. Change-Id: I26f0a16d61537505eb41b4b05ef2e6d67fc2541b	7 years ago
Chris Savinovich	b327b0bbda	Revert "Test_cel: Fails when DONT_OPTIMIZE is off" ... This reverts commit 05b79d16ab. Change-Id: I2e64fc22c33b10cfd592681732fc67ae0669a301	7 years ago
George Joseph	c0b7b60ba1	Merge "sounds: Sort 'core show sounds' output" into 16	8 years ago
George Joseph	7e366e4d4b	Merge "main/cdr: Fixed cdr start overwriting" into 16	8 years ago
Sungtae Kim	e3e3027092	main/cdr: Fixed cdr start overwriting ... The CDR was overwriting the start time when the call continued the dialplan from the ARI stasis or a Local channel was originated. This change fixes this by no longer reinitializing the CDR when transitioning out of the dialed pending state to the single state. ASTERISK-28181 Change-Id: I921bc04064b6cff1deb2eea56a94d86489561cdc	8 years ago
Giuseppe Sucameli	419db481d1	Fix deadlock handling subscribe req during res_parking reload ... Split destroy_hint method to separate hint removal and extension hint state changed callback, the latter now called via stasis. This avoids deadlock between res_parking reload that is removing the parking lot and the related hint and subscribe requests coming for the same parking lot. ASTERISK-28173 Change-Id: I5b03c3455b3b12b6f83cea4cc34f4b4b20444f7e	8 years ago
Sean Bright	f29da72969	sounds: Sort 'core show sounds' output ... Change-Id: Ib39052a745040f75eb635f15a042da15b20e22ab	8 years ago
George Joseph	603143bd5a	media_index.c: Refactored so it doesn't cache the index ... Testing revealed that the cache added no benefit but that it could consume excessive memory. Two new index related functions were created: ast_sounds_get_index_for_file() and ast_media_index_update_for_file() which restrict index updating to specific sound files. The original ast_sounds_get_index() and ast_media_index_update() calls are still available but since they no longer cache the results internally, developers should re-use an index they may already have instead of calling ast_sounds_get_index() repeatedly. If information for only a single file is needed, ast_sounds_get_index_for_file() should be called instead of ast_sounds_get_index(). The media_index directory scan code was elimininated in favor of using the existing ast_file_read_dirs() function. Since there's no more cache, ast_sounds_index_init now only registers the sounds cli commands instead of generating the initial index and subscribing to stasis format register/unregister messages. "sounds" is no longer a valid target for the "module reload" command. Both the sounds cli commands and the sounds ari resources were refactored to only call ast_sounds_get_index() once per invocation and to use ast_sounds_get_index_for_file() when a specific sound file is requested. Change-Id: I1cef327ba1b0648d85d218b70ce469ad07f4aa8d	8 years ago
Joshua C. Colp	a40fb7fa7f	Merge "Test_cel: Fails when DONT_OPTIMIZE is off" into 16	8 years ago
Joshua C. Colp	6640ecfd39	Merge "manager_channels: Fix throwing of HangupHandler manager events" into 16	8 years ago
Joshua C. Colp	7d1736b59b	Merge "stasis / manager / ari: Better filter messages." into 16	8 years ago
Gerald Schnabel	735bd4d185	manager_channels: Fix throwing of HangupHandler manager events ... The type value extracted from stasis message data in channel_hangup_handler_cb isn't compared against the valid values "run", "pop" and "push". Thus the manager events HangupHandlerPush, HangupHandlerPop and HangupHandlerRun are never thrown. This regression was introduced by ASTERISK_21462. ASTERISK-28252 Change-Id: I9956e35e18da1873113644df1ddc3c7cd37bf524	8 years ago
Chris-Savinovich	05b79d16ab	Test_cel: Fails when DONT_OPTIMIZE is off ... A bug in GCC causes TEST_CEL to return failure under the following conditions: 1. TEST_FRAMEWORK on 2. DONT_OPTIMIZE off 3. Fedora and Ubuntu 4. GCC 8.2.1 5. Test name: test_cel_dial_pickup 6. There must exist a certain combination of multithreading. The bug affects arithmetic calculations when the optimization level is bigger than O1 and the -fpartial-inline flag is on. Provided these conditions, function ast_str_to_lower() fails to convert to lower case due to said function being of type force_inline. The solution is to remove the "force_inline" type declaration from function ast_str_to_lower() Change-Id: Ied32e0071f12ed9d5f3b4cdd878b2532a1c769d7	8 years ago
Valentin Vidic	6506c5b1d4	channel.c: Fix segfault with Monitor(wav,file,i) ... If the Monitor is started with the i option the read_stream will be NULL. One code path in channel.c checks if write_stream is set but than uses read_stream instead causing a segfault. ASTERISK-28249 Change-Id: I1bae9126537be54895c7fea2d08dd9488d8cc525	8 years ago
Joshua C. Colp	fcd07c34fb	stasis / manager / ari: Better filter messages. ... Previously both AMI and ARI used a default route on their stasis message router to handle some of the messages for publishing out their respective connection. This caused messages to be given to their subscription that could not be formatted into AMI or JSON. This change adds an API call to the stasis message router which allows a default route to be set as well as formatters that the default route is expecting. This allows both AMI and ARI to specify that their default route only wants messages of their given formatter. By doing so stasis can more intelligently filter at publishing time so that they do not receive messages which will not be turned into AMI or JSON. ASTERISK-28244 Change-Id: I65272819a53ce99f869181d1d370da559a7d1703	8 years ago
Sean Bright	011e46d5a6	sched: Make sched_settime() return void because it cannot fail ... Change-Id: I66b8b2b2778f186919d73ae9bf592104b8fb1cd5	8 years ago
mohitdhiman	4b24da607e	stasis/endpoint: Fix memory leak of channel_ids in ast_endpoint structure. ... During Bridging of two channels if masquerade operation is performed on a channel (clone channel) which was created with endpoint details (ast_channel_alloc_with_endpoint()) and the original channel which is created without endpoint details (ast_channel_alloc()) then both the channels must exchange their endpoint details or else after masquerade when clone channel is being destroyed the endpoint cleanup callbacks will be destroyed too and after call completion unique_id of original channel will still be there in ast_endpoint structure's channel_ids container. ASTERISK-28197 Change-Id: Ied0451f378a3f2a36acc8c0984959a69895efa17	8 years ago
Friendly Automation	140ed330ac	Merge "stasis: Fix ABI between DEVMODE and non-DEVMODE." into 16	8 years ago
Richard Mudgett	f196078705	stasic.c: Fix printf format type mismatches with arguments. ... An int64_t is not likely the same size as a long. * Changed the int64_t values in the statistics structs to longs so casting is not necessary when generating the formatted CLI output. The offending members did not need to be int64_t anyway as they were only set by an int type variable which was already truncating bits. * Reordered the statistics structs to reduce potential padding bytes. Change-Id: Ic090a070e9dc4ca650ebdb9c01ed50a581289962	8 years ago
George Joseph	4ff64bfc2c	Merge "backtrace.c: Fix casting pointer to/from integral type." into 16	8 years ago
Corey Farrell	44a7faca21	stasis: Fix ABI between DEVMODE and non-DEVMODE. ... Create compatibility stubs for maximum ABI compatibility. ASTERISK-28212 #close Change-Id: I872c04842ab6b61e9dd6d37e4166bc619aa20626	8 years ago
George Joseph	ff2ed4eeee	Revert "stasis_cache: Stop caching stasis subscription change messages" ... This commit caused issues with polling when combined with the revert commit "Revert "app_voicemail: Remove need to subscribe to stasis" This reverts commit 17d6d9e1e7. ASTERISK-28222 Reported by: abelbeck Change-Id: Ib6a16cbe2c0b74c76c64264f525ab647959c1483	8 years ago
Richard Mudgett	59717b5e85	backtrace.c: Fix casting pointer to/from integral type. ... The backtrace library bfd.h include file does not get the sizes of pointers and ints right on some platforms. On my old test box the size of bfd_vma is 8 while the size of a pointer is 4. gcc on the box complains of the integer casting to/from pointers size mismatch. * uintptr_t to the rescue by doing an appropriate two stage cast. Change-Id: Icb2621583f50c8728de08a3c824d95fe53cc45d0	8 years ago
Joshua C. Colp	84d693a689	Merge "utils: Don't set or clear flags that don't need setting or clearing" into 16	8 years ago
Friendly Automation	67e91d012b	Merge "stasis: Add statistics gathering in developer mode." into 16	8 years ago
Joshua C. Colp	36db878adc	Merge "Use non-blocking socket() and pipe() wrappers" into 16	8 years ago
Joshua C. Colp	68ec7d93e8	stasis: Add statistics gathering in developer mode. ... This change adds statistics gathering to Stasis topics, subscriptions, and message types. These can be viewed using CLI commands and provide insight into how Stasis is used and how long certain operations take to execute. These are only available when Asterisk is compiled in developer mode and do not have any impact under normal operation. ASTERISK-28117 Change-Id: I94411b53767f89ee01714daaecf0c2f1666e863f	8 years ago
Friendly Automation	ff147bcf92	Merge "stasis: Allow filtering by formatter" into 16	8 years ago
Sean Bright	9febdba05b	Use non-blocking socket() and pipe() wrappers ... Change-Id: I050ceffe5a133d5add2dab46687209813d58f597	8 years ago
Sean Bright	16ae8330d2	utils: Don't set or clear flags that don't need setting or clearing ... Change-Id: I0e7fb507ac09b15e45e1ff8501ecfca67afa5217	8 years ago
Sean Bright	8a18fb81c1	utils: Wrap socket() and pipe() to reduce syscalls ... Some platforms provide an implementation of socket() and pipe2() that allow the caller to specify that the resulting file descriptors should be non-blocking. Using these allows us to potentially elide 3 calls into 1 by avoiding extraneous calls to fcntl() to set the O_NONBLOCK flag afterwards. In passing, change ast_alertpipe_init() to use pipe2() directly instead of the wrapper if it is available. Change-Id: I3ebe654fb549587537161506c6c950f4ab298bb0	8 years ago
George Joseph	79899db740	stasis: Allow filtering by formatter ... A subscriber can now indicate that it only wants messages that have formatters of a specific type. For instance, manager can indicate that it only wants messages that have a "to_ami" formatter. You can combine this with the existing filter for message type to get only messages with specific formatters or messages of specific types. ASTERISK-28186 Change-Id: Ifdb7a222a73b6b56c6bb9e4ee93dc8a394a5494c	8 years ago
Sean Bright	27806fd04d	core: Add some documentation to the malloc_trim code ... This adds documentation to handle_cli_malloc_trim() indicating how it can be useful when debugging OOM conditions. Change-Id: I1936185e78035bf123cd5e097b793a55eeebdc78	8 years ago
Chris-Savinovich	1f09c61804	core: Merge malloc_trim patch ... We've had multiple opportunities where Richard Mudgett's malloc_trim patch has been useful. Let's get it pushed up to gerrit and merged. Since malloc_trim is only available in libc, an entry is added to configure.ac to create a definition for HAVE_MALLOC_TRIM. Change-Id: Ia38308c550149d9d6eae4ca414a649957de9700c	8 years ago