asterisk

Commit Graph

Author	SHA1	Message	Date
Terry Wilson	44f7d9e631	Merged revisions 169510 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r169510 \| twilson \| 2009-01-20 13:22:24 -0600 (Tue, 20 Jan 2009) \| 7 lines Make a proper builtin attended transfer to parking work This is an ugly hack from 1.4 that allows the timeout callback from a parked call to use the right channel name for the callback when the park is done with a builtin attended transfer (that isn't completed early). This hasn't ever worked in trunk and no one has complained yet, so eh. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@169554 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Terry Wilson	18c4a532b4	Merged revisions 169486 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r169486 \| twilson \| 2009-01-20 12:48:14 -0600 (Tue, 20 Jan 2009) \| 13 lines Merged revisions 169485 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r169485 \| twilson \| 2009-01-20 12:40:56 -0600 (Tue, 20 Jan 2009) \| 6 lines Don't play audio to the channel if we've masqueraded (closes issue #14066) Reported by: bluefox Tested by: otherwiseguy, bluefox ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@169488 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	895e42e525	Merged revisions 169365 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r169365 \| tilghman \| 2009-01-19 14:05:52 -0600 (Mon, 19 Jan 2009) \| 11 lines Merged revisions 169364 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r169364 \| tilghman \| 2009-01-19 13:49:25 -0600 (Mon, 19 Jan 2009) \| 4 lines Truncate userevents at the end of a line, when the command exceeds the buffer. (closes issue #14278) Reported by: fnordian ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@169368 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Terry Wilson	80bcb37636	Merged revisions 169080 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r169080 \| twilson \| 2009-01-16 19:56:36 -0600 (Fri, 16 Jan 2009) \| 8 lines Fix qualify for TCP peer (closes issue #14192) Reported by: pabelanger Patches: asterisk-bug14192.diff.txt uploaded by jamesgolovich (license 176) Tested by: jamesgolovich ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@169082 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Terry Wilson	1739c1e13b	Merged revisions 168941 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r168941 \| twilson \| 2009-01-16 16:16:23 -0600 (Fri, 16 Jan 2009) \| 19 lines Merged revisions 168716 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168716 \| twilson \| 2009-01-15 12:22:49 -0600 (Thu, 15 Jan 2009) \| 12 lines Convert call to park_call_full to masq_park_call_announce Since we removed the AST_PBX_KEEPALIVE return value, we need to use masqueraded parking, otherwise we will try to call ast_hangup() in __pbx_run() and in do_parking_thread() and then promptly crash. (closes issue #14215) Reported by: waverly360 Tested by: otherwiseguy (closes issue #14228) Reported by: kobaz Tested by: otherwiseguy ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@168981 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	5b50a09ef2	Merged revisions 168832 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r168832 \| tilghman \| 2009-01-16 12:49:09 -0600 (Fri, 16 Jan 2009) \| 13 lines Merged revisions 168828 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168828 \| tilghman \| 2009-01-16 12:41:35 -0600 (Fri, 16 Jan 2009) \| 6 lines Fix the conjugation of Russian and Ukrainian languages. (related to issue #12475) Reported by: chappell Patches: vm_multilang.patch uploaded by chappell (license 8) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@168836 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	6ecb12a2ed	Merged revisions 168737 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r168737 \| murf \| 2009-01-15 13:54:59 -0700 (Thu, 15 Jan 2009) \| 16 lines This patch allows null args in ast_expr2 func calls, and fixes commas being converted to pipes, which was 1.4 type stuff. If the user says count=ENUMLOOKUP(${EXTEN},ALL,c,,enum.mydomain.tld); then it won't complain about the empty arg (c,,...) and fabled's patch won't let it swap the commas for pipes. Ran it thru my dialplan and no complaints. (closes issue #14169) Reported by: fabled Patches: function-argument-separator-fix.diff uploaded by fabled (license 448) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@168739 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	f55f994661	Merged revisions 168604 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r168604 \| tilghman \| 2009-01-14 13:11:14 -0600 (Wed, 14 Jan 2009) \| 14 lines Merged revisions 168603 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168603 \| tilghman \| 2009-01-14 13:02:55 -0600 (Wed, 14 Jan 2009) \| 7 lines Don't read into a buffer without first checking if a value is beyond the end. (closes issue #13600) Reported by: atis Patches: 20090106__bug13600.diff.txt uploaded by Corydon76 (license 14) Tested by: atis ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@168606 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	a29672060a	Merged revisions 168562 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r168562 \| russell \| 2009-01-13 13:22:13 -0600 (Tue, 13 Jan 2009) \| 10 lines Merged revisions 168561 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168561 \| russell \| 2009-01-13 13:13:05 -0600 (Tue, 13 Jan 2009) \| 2 lines Revert unnecessary indications API change from rev 122314 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@168565 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	84d982cb36	Merged revisions 168523 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r168523 \| mmichelson \| 2009-01-12 17:12:30 -0600 (Mon, 12 Jan 2009) \| 11 lines bump the verbosity of a message in srv.c up by one. It used to be at this level prior to a large patch merge which converted ast_verbose calls to ast_verb (closes issue #14221) Reported by: jcovert Patches: srv.c.patch uploaded by jcovert (license 551) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@168524 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Matthew Nicholson	1f9def253b	Merged revisions 168014 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r168014 \| mnicholson \| 2009-01-09 10:32:34 -0600 (Fri, 09 Jan 2009) \| 5 lines Use ast_safe_system() in logger.c instead of system() (closes issue #14194) Reported by: pabelanger ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@168015 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	424dc6af48	Merged revisions 167569 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r167569 \| russell \| 2009-01-07 16:36:34 -0600 (Wed, 07 Jan 2009) \| 10 lines Merged revisions 167566 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r167566 \| russell \| 2009-01-07 16:35:36 -0600 (Wed, 07 Jan 2009) \| 2 lines Fix the last couple of places where free() was improperly used directly. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@167573 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	e0d2263f33	Merged revisions 167555 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r167555 \| russell \| 2009-01-07 16:27:23 -0600 (Wed, 07 Jan 2009) \| 10 lines Merged revisions 167554 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r167554 \| russell \| 2009-01-07 16:26:42 -0600 (Wed, 07 Jan 2009) \| 2 lines Don't fclose() the file early, the filestream destructor will handle it. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@167558 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	fcca2ae242	Merged revisions 167546 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r167546 \| russell \| 2009-01-07 16:20:31 -0600 (Wed, 07 Jan 2009) \| 10 lines Merged revisions 167545 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r167545 \| russell \| 2009-01-07 16:19:47 -0600 (Wed, 07 Jan 2009) \| 2 lines Only try to close the file if one was actually opened ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@167550 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	e09314f28c	Merged revisions 167542 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r167542 \| russell \| 2009-01-07 16:05:29 -0600 (Wed, 07 Jan 2009) \| 12 lines Merged revisions 167541 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r167541 \| russell \| 2009-01-07 16:03:59 -0600 (Wed, 07 Jan 2009) \| 4 lines Don't use free() directly. This caused a crash since ast_filestream is now an ao2 object. Reported by JunK-Y on IRC, #asterisk-dev ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@167544 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	b7d3a078c3	Merged revisions 167442 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r167442 \| russell \| 2009-01-07 11:35:39 -0600 (Wed, 07 Jan 2009) \| 12 lines Merged revisions 167432 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r167432 \| russell \| 2009-01-07 11:29:53 -0600 (Wed, 07 Jan 2009) \| 4 lines Treat an empty string the same way as a NULL country argument. In passing, simplify the handling of returning a default tone zone. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@167456 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	ee8553caa6	Merged revisions 167301 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r167301 \| mmichelson \| 2009-01-06 15:36:44 -0600 (Tue, 06 Jan 2009) \| 16 lines Merged revisions 167299 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r167299 \| mmichelson \| 2009-01-06 15:35:57 -0600 (Tue, 06 Jan 2009) \| 8 lines Use the correct variable when creating the format string (closes issue #14177) Reported by: nic_bellamy Patches: asterisk-trunk-svn-r167242-ast_db_gettree.patch uploaded by nic (license 299) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@167306 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	a7aeaf341b	Merged revisions 166665 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk This merged from trunk with no conflicts. I tested mostly the 'tired' cases, and for the most part ignored the tests for reconnecting and dialing in to fetch a parked call, after the first case. ................ r166665 \| murf \| 2008-12-23 11:13:49 -0700 (Tue, 23 Dec 2008) \| 153 lines Merged revisions 166093 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 In order to merge this 1.4 patch into trunk, I had to resolve some conflicts and wait for Russell to make some changes to res_agi. I re-ran all the tests; 39 calls in all, and made fairly careful notes and comparisons: I don't want this to blow up some aspect of asterisk; I completely removed the KEEPALIVE from the pbx.h decls. The first 3 scenarios involving feature park; feature xfer to 700; hookflash park to Park() app call all behave the same, don't appear to leave hung channels, and no crashes. ........ r166093 \| murf \| 2008-12-19 15:30:32 -0700 (Fri, 19 Dec 2008) \| 131 lines This merges the masqpark branch into 1.4 These changes eliminate the need for (and use of) the KEEPALIVE return code in res_features.c; There are other places that use this result code for similar purposes at a higher level, these appear to be left alone in 1.4, but attacked in trunk. The reason these changes are being made in 1.4, is that parking ends a channel's life, in some situations, and the code in the bridge (and some other places), was not checking the result code properly, and dereferencing the channel pointer, which could lead to memory corruption and crashes. Calling the masq_park function eliminates this danger in higher levels. A series of previous commits have replaced some parking calls with masq_park, but this patch puts them ALL to rest, (except one, purposely left alone because a masquerade is done anyway), and gets rid of the code that tests the KEEPALIVE result, and the NOHANGUP_PEER result codes. While bug 13820 inspired this work, this patch does not solve all the problems mentioned there. I have tested this patch (again) to make sure I have not introduced regressions. Crashes that occurred when a parked party hung up while the parking party was listening to the numbers of the parking stall being assigned, is eliminated. These are the cases where parking code may be activated: 1. Feature one touch (eg. *3) 2. Feature blind xfer to parking lot (eg ##700) 3. Run Park() app from dialplan (eg sip xfer to 700) (eg. dahdi hookflash xfer to 700) 4. Run Park via manager. The interesting testing cases for parking are: I. A calls B, A parks B a. B hangs up while A is getting the numbers announced. b. B hangs up after A gets the announcement, but before the parking time expires c. B waits, time expires, A is redialed, A answers, B and A are connected, after which, B hangs up. d. C picks up B while still in parking lot. II. A calls B, B parks A a. A hangs up while B is getting the numbers announced. b. A hangs up after B gets the announcement, but before the parking time expires c. A waits, time expires, B is redialed, B answers, A and B are connected, after which, A hangs up. d. C picks up A while still in parking lot. Testing this throroughly involves acting all the permutations of I and II, in situations 1,2,3, and 4. Since I added a few more changes (ALL references to KEEPALIVE in the bridge code eliimated (I missed one earlier), I retested most of the above cases, and no crashes. H-extension weirdness. Current h-extension execution is not completely correct for several of the cases. For the case where A calls B, and A parks B, the 'h' exten is run on A's channel as soon as the park is accomplished. This is expected behavior. But when A calls B, and B parks A, this will be current behavior: After B parks A, B is hung up by the system, and the 'h' (hangup) exten gets run, but the channel mentioned will be a derivative of A's... Thus, if A is DAHDI/1, and B is DAHDI/2, the h-extension will be run on channel Parked/DAHDI/1-1<ZOMBIE>, and the start/answer/end info will be those relating to Channel A. And, in the case where A is reconnected to B after the park time expires, when both parties hang up after the joyful reunion, no h-exten will be run at all. In the case where C picks up A from the parking lot, when either A or C hang up, the h-exten will be run for the C channel. CDR's are a separate issue, and not addressed here. As to WHY this strange behavior occurs, the answer lies in the procedure followed to accomplish handing over the channel to the parking manager thread. This procedure is called masquerading. In the process, a duplicate copy of the channel is created, and most of the active data is given to the new copy. The original channel gets its name changed to XXX<ZOMBIE> and keeps the PBX information for the sake of the original thread (preserving its role as a call originator, if it had this role to begin with), while the new channel is without this info and becomes a call target (a "peer"). In this case, the parking lot manager thread is handed the new (masqueraded) channel. It will not run an h-exten on the channel if it hangs up while in the parking lot. The h exten will be run on the original channel instead, in the original thread, after the bridge completes. See bug 13820 for our intentions as to how to clean up the h exten behavior. Review: http://reviewboard.digium.com/r/29/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166730 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	827f655dac	Merged revisions 166696 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r166696 \| tilghman \| 2008-12-23 14:47:08 -0600 (Tue, 23 Dec 2008) \| 7 lines Allow semicolons and extended characters in user-specified SIP headers. (closes issue #14110) Reported by: gork Patches: 20081222__bug14110__2.diff.txt uploaded by Corydon76 (license 14) Tested by: gork, putnopvut ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166698 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	63f2d52453	Merged revisions 166569 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r166569 \| mmichelson \| 2008-12-23 09:17:54 -0600 (Tue, 23 Dec 2008) \| 20 lines Merged revisions 166568 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r166568 \| mmichelson \| 2008-12-23 09:16:26 -0600 (Tue, 23 Dec 2008) \| 12 lines Fix a crash resulting from a datastore with inheritance but no duplicate callback The fix for this is to simply set the newly created datastore's data pointer to NULL if it is inherited but has no duplicate callback. (closes issue #14113) Reported by: francesco_r Patches: 14113.patch uploaded by putnopvut (license 60) Tested by: francesco_r ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166571 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	9981739dd1	Merged revisions 166533 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r166533 \| tilghman \| 2008-12-22 22:32:15 -0600 (Mon, 22 Dec 2008) \| 11 lines Merged revisions 166509 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r166509 \| tilghman \| 2008-12-22 22:05:25 -0600 (Mon, 22 Dec 2008) \| 4 lines Use the integer form of condition for integer comparisons. (closes issue #14127) Reported by: andrew ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166535 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	511692bc3d	Merged revisions 166342 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r166342 \| russell \| 2008-12-22 11:44:23 -0600 (Mon, 22 Dec 2008) \| 2 lines Remove some error messages. This is the default handler that is valid to use. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166343 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	3d6899f584	Merged revisions 166317 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r166317 \| russell \| 2008-12-22 11:29:10 -0600 (Mon, 22 Dec 2008) \| 10 lines Merged revisions 166297 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r166297 \| russell \| 2008-12-22 11:22:56 -0600 (Mon, 22 Dec 2008) \| 2 lines Fix up timeout handling in ast_carefulwrite(). ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166326 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	3db74e5bd7	Merged revisions 166282 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r166282 \| russell \| 2008-12-22 11:09:36 -0600 (Mon, 22 Dec 2008) \| 12 lines Introduce ast_careful_fwrite() and use in AMI to prevent partial writes. This patch introduces a function to do careful writes on a file stream which will handle timeouts and partial writes. It is currently used in AMI to address the issue that has been reported. However, there are probably a few other places where this could be used. (closes issue #13546) Reported by: srt Tested by: russell http://reviewboard.digium.com/r/104/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166284 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	198eedad1f	Merged revisions 166267 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r166267 \| mmichelson \| 2008-12-22 10:07:59 -0600 (Mon, 22 Dec 2008) \| 17 lines Fix a file playback crash and explicitly initialize values in func_timeout.c A crash was brought up on the bugtracker. The first run through valgrind was full of legitimate complaints of uninitialized values in func_timeout when setting a response timeout. These were fixed but the crash persisted. A second run through showed the real problem. The reference counting used for filestreams was incorrect because there were some missing increments when a frame was read from a format module. (closes issue #14118) Reported by: blitzrage Patches: 14118v2.patch uploaded by putnopvut (license 60) Tested by: blitzrage ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166275 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	69c484879f	Merged revisions 166268 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r166268 \| file \| 2008-12-22 12:08:13 -0400 (Mon, 22 Dec 2008) \| 7 lines Record the previous port in the temporary address structure so that the comparison does not treat the host as having changed even if it did not. This would have been uninitialized before and would have led to a baddddd port. (closes issue #13628) Reported by: pananix Patches: bug13628.patch uploaded by jpeeler (license 325) Tested by: file, blitzrage ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166272 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	732fd97b6b	Merged revisions 166162 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r166162 \| mmichelson \| 2008-12-19 17:45:00 -0600 (Fri, 19 Dec 2008) \| 6 lines Get rid of an extra space. I don't know how this crept back in when I had already fixed it earlier ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166164 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	7ed70a7a3f	Merged revisions 166092,166095 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r166092 \| mmichelson \| 2008-12-19 16:26:16 -0600 (Fri, 19 Dec 2008) \| 28 lines Adding a new dialplan function AUDIOHOOK_INHERIT This function is being added as a method to allow for an audiohook to move to a new channel during a channel masquerade. The most obvious use for such a facility is for MixMonitor when a transfer is performed. Prior to the addition of this functionality, if a channel running MixMonitor was transferred by another party, then the recording would stop once the transfer had completed. By using AUDIOHOOK_INHERIT, you can make MixMonitor continue recording the call even after the transfer has completed. It has also been determined that since this is seen by most as a bug fix and is not an invasive change, this functionality will also be backported to 1.4 and merged into the 1.6.0 branches, even though they are feature-frozen. (closes issue #13538) Reported by: mbit Patches: 13538.patch uploaded by putnopvut (license 60) Tested by: putnopvut Review: http://reviewboard.digium.com/r/102/ ........ r166095 \| mmichelson \| 2008-12-19 16:40:57 -0600 (Fri, 19 Dec 2008) \| 5 lines Remove the verbatim tag from the author line I could have sworn I already did that before, though... ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166098 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	c871ef2aeb	Merged revisions 165801 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r165801 \| russell \| 2008-12-18 15:44:47 -0600 (Thu, 18 Dec 2008) \| 19 lines Merged revisions 165796 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r165796 \| russell \| 2008-12-18 15:39:25 -0600 (Thu, 18 Dec 2008) \| 11 lines Make ast_carefulwrite() be more careful. This patch handles some additional cases that could result in partial writes to the file description. This was done to address complaints about partial writes on AMI. (issue #13546) (more changes needed to address potential problems in 1.6) Reported by: srt Tested by: russell Review: http://reviewboard.digium.com/r/99/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@165804 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	52f5e8fcfb	Merged revisions 165723 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r165723 \| russell \| 2008-12-18 13:33:42 -0600 (Thu, 18 Dec 2008) \| 14 lines Remove the need for AST_PBX_KEEPALIVE with the GoSub option from Dial. This is part of an effort to completely remove AST_PBX_KEEPALIVE and other similar return codes from the source. While this usage was perfectly safe, there are others that are problematic. Since we know ahead of time that we do not want to PBX to destroy the channel, the PBX API has been changed so that information can be provided as an argument, instead, thus removing the need for the KEEPALIVE return value. Further changes to get rid of KEEPALIVE and related code is being done by murf. There is a patch up for that on review 29. Review: http://reviewboard.digium.com/r/98/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@165728 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	e5a8f92ab1	Merged revisions 165599 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r165599 \| file \| 2008-12-18 13:13:32 -0400 (Thu, 18 Dec 2008) \| 11 lines Merged revisions 165591 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r165591 \| file \| 2008-12-18 13:11:42 -0400 (Thu, 18 Dec 2008) \| 4 lines Only care about a compatible codec for early bridging if we are actually bridging to another channel. If we are not we actually want to bring the audio back to us. (closes issue #13545) Reported by: davidw ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@165605 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	4468cd8d49	Merged revisions 164882 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r164882 \| russell \| 2008-12-16 15:39:15 -0600 (Tue, 16 Dec 2008) \| 17 lines Merged revisions 164881 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164881 \| russell \| 2008-12-16 15:38:29 -0600 (Tue, 16 Dec 2008) \| 9 lines Fix an issue where DEBUG_THREADS may erroneously report that a thread is exiting while holding a lock. If the last lock attempt was a trylock, and it failed, it will still be in the list of locks so that it can be reported. (closes issue #13219) Reported by: pj ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164884 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	43371e4cb1	Merged revisions 164807 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r164807 \| russell \| 2008-12-16 14:41:51 -0600 (Tue, 16 Dec 2008) \| 17 lines Merged revisions 164806 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164806 \| russell \| 2008-12-16 14:35:25 -0600 (Tue, 16 Dec 2008) \| 9 lines Add "restart gracefully" to the AMI blacklist of CLI commands. "module unload" was already identified as a command that can not be used from the AMI. "restart gracefully" effectively unloads all modules, and will run in to the same problems. (closes issue #13894) Reported by: kernelsensei ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164813 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	e3e5457dc4	Merged revisions 164801 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r164801 \| murf \| 2008-12-16 13:04:46 -0700 (Tue, 16 Dec 2008) \| 36 lines (closes issue #14076) Reported by: toc Tested by: murf OK, Well this issue has had its share of flip-flopping. I found the following: 1. the code in question, in ext_cmp1 in pbx.c, would not allow two extensions that vary only by any dashes contained within them, to be defined in the same context. 2. for input dialstrings, dashes are NOT ignored. So, skipping them when sorting patterns seemed a bit silly. Thus, you might declare ext 891 in a context, but if you try dialing 8-9-1, it will NOT match 891. So, I proposed to remove the code from ext_cmp1 to skip the spaces and dashes. Just kept us from declaring 891 and 8-9-1 in the same context, forcing users to generate otherwise uselessly obfuscated dialplan code to get the same effect. Then, I tried out 1.4, and found that: 1. you can declare 891 and 8-9-1 in the same context! 2. You can't define 891, and have 8-9-1 match it! Nor can you define 8-9-1, and have 891 match it! So, it appears that my proposal simply restores the pbx to behaving as it did in 1.4. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164805 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f39a711c49	Merged revisions 164737 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r164737 \| russell \| 2008-12-16 11:14:01 -0600 (Tue, 16 Dec 2008) \| 22 lines Merged revisions 164736 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164736 \| russell \| 2008-12-16 11:06:29 -0600 (Tue, 16 Dec 2008) \| 14 lines Fix memory leak and invalid reporting issues with DEBUG_THREADLOCALS. One issue was that the ast_mutex_* API was being used within the context of the thread local data destructors. We would go off and allocate more thread local data while the pthread lib was in the middle of destroying it all. This led to a memory leak. Another issue was an invalid argument being provided to the the object_add API call. (closes issue #13678) Reported by: ys Tested by: Russell ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164739 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	a13fe6807a	Merged revisions 164648 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r164648 \| murf \| 2008-12-16 08:31:54 -0700 (Tue, 16 Dec 2008) \| 13 lines Merged revisions 164634 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164634 \| murf \| 2008-12-16 08:15:58 -0700 (Tue, 16 Dec 2008) \| 5 lines I added a sentence to clarify why - and ' ' are ignored in patterns as per bug 14076. Leif says he'll put some stuff about it in the extensions.conf sample, etc. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164658 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f8dc9e9776	Merged revisions 164519 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r164519 \| russell \| 2008-12-15 15:53:30 -0600 (Mon, 15 Dec 2008) \| 7 lines Make sure we handle a uint32_t payload in ast_frdup() (closes issue #14080) Reported by: fnordian Patches: frame.patch uploaded by fnordian (license 110) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164521 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	2277054f17	Merged revisions 164312 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r164312 \| file \| 2008-12-15 13:24:28 -0400 (Mon, 15 Dec 2008) \| 4 lines Use ast_seekstream to return the file stream back to the beginning instead of directly seeking to zero. This is because some audio formats have headers at the front that need to be skipped, which will be done by the format module. (closes issue #14079) Reported by: elguero ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164314 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	e74bc96b7b	Merged revisions 164203 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r164203 \| russell \| 2008-12-15 08:40:24 -0600 (Mon, 15 Dec 2008) \| 39 lines Merged revisions 164201 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164201 \| russell \| 2008-12-15 08:31:37 -0600 (Mon, 15 Dec 2008) \| 31 lines Handle a case where a call can be bridged to a channel that is still ringing. The issue that was reported was about a case where a RINGING channel got redirected to an extension to pick up a call from parking. Once the parked call got taken out of parking, it heard silence until the other side answered. Ideally, the caller that was parked would get a ringing indication. This patch fixes this case so that the caller receives ringback once it comes out of parking until the other side answers. The fixes are: - Make sure we remember that a channel was an outgoing channel when doing a masquerade. This prevents an erroneous ast_answer() call on the channel, which causes a bogus 200 OK to be sent in the case of SIP. - Add some additional comments to explain related parts of code. - Update the handling of the ast_channel visible_indication field. Storing values that are not stateful is pointless. Control frames that are events or commands should be ignored. - When a bridge first starts, check to see if the peer channel needs to be given ringing indication because the calling side is still ringing. - Rework ast_indicate_data() a bit for the sake of readability. (closes issue #13747) Reported by: davidw Tested by: russell Review: http://reviewboard.digium.com/r/90/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164300 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	aef27a9372	Merged revisions 163762 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r163762 \| tilghman \| 2008-12-12 16:04:26 -0600 (Fri, 12 Dec 2008) \| 14 lines Merged revisions 163761 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163761 \| tilghman \| 2008-12-12 16:03:10 -0600 (Fri, 12 Dec 2008) \| 7 lines Simple fix for Ctrl-C not immediately exiting Asterisk, but also add a pointer inside editline to look back to asterisk.c, so others don't spend as much time as I did looking (in the wrong place) for the appropriate function. Reported by: ZX81, via the #asterisk-users channel Fixed by: me (license 14) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163764 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	7129aba1a5	Merged revisions 163670 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r163670 \| russell \| 2008-12-12 12:45:03 -0600 (Fri, 12 Dec 2008) \| 6 lines Rename a number of tcptls_session variables. There are no functional changes here. The name "ser" was used in a lot of places. However, it is a relic from when the struct was a server_instance, not a session_instance. It was renamed since it represents both a server or client connection. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163672 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	79d555f70c	Merged revisions 163579 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r163579 \| file \| 2008-12-12 12:55:15 -0400 (Fri, 12 Dec 2008) \| 4 lines Since chan_sip is callback devicestate driven do not pass in actual states, pass in unknown so we get asked. Additionally do not pass in an actual device state value in ast_setstate since the channel may be callback driven. (closes issue #13525) Reported by: pj ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163581 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	85ad905561	Merged revisions 163449 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r163449 \| russell \| 2008-12-12 07:55:30 -0600 (Fri, 12 Dec 2008) \| 34 lines Merged revisions 163448 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163448 \| russell \| 2008-12-12 07:44:08 -0600 (Fri, 12 Dec 2008) \| 26 lines Resolve issues that could cause DTMF to be processed out of order. These changes come from team/russell/issue_12658 1) Change autoservice to put digits on the head of the channel's frame readq instead of the tail. If there were frames on the readq that autoservice had not yet read, the previous code would have resulted in out of order processing. This required a new API call to queue a frame to the head of the queue instead of the tail. 2) Change up the processing of DTMF in ast_read(). Some of the problems were the result of having two sources of pending DTMF frames. There was the dtmfq and the more generic readq. Both were used for pending DTMF in various scenarios. Simplifying things to only use the frame readq avoids some of the problems. 3) Fix a bug where a DTMF END frame could get passed through when it shouldn't have. If code set END_DTMF_ONLY in the middle of digit emulation, and a digit arrived before emulation was complete, digits would get processed out of order. (closes issue #12658) Reported by: dimas Tested by: russell, file Review: http://reviewboard.digium.com/r/85/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163515 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	c4281ca1fa	Merged revisions 163384 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r163384 \| tilghman \| 2008-12-11 17:38:56 -0600 (Thu, 11 Dec 2008) \| 16 lines Merged revisions 163383 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163383 \| tilghman \| 2008-12-11 17:35:55 -0600 (Thu, 11 Dec 2008) \| 9 lines When a Ctrl-C or Ctrl-D ends a remote console, on certain shells, the terminal is messed up. By intercepting those events with a signal handler in the remote console, we can avoid those issues. (closes issue #13464) Reported by: tzafrir Patches: 20081110__bug13464.diff.txt uploaded by Corydon76 (license 14) Tested by: blitzrage ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163386 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	39a8f051b7	Merged revisions 163171 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r163171 \| russell \| 2008-12-11 14:07:47 -0600 (Thu, 11 Dec 2008) \| 16 lines Fix the "failed" extension for outgoing calls. The conversion to use ast_check_hangup() everywhere instead of checking the softhangup flag directly introduced this problem. The issue is that ast_check_hangup() checked for tech_pvt to be NULL. Unfortunately, this will be NULL is some valid circumstances, such as with a dummy channel. The fix is simple. Don't check tech_pvt. It's pointless, because the code path that sets this to NULL is when the channel hangup callback gets called. This happens inside of ast_hangup(), which is the same function responsible for freeing the channel. Any code calling ast_check_hangup() better not be calling it after that point, and if so, we have a bigger problem at hand. (closes issue #14035) Reported by: erogoza ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163173 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	221462c7a1	Merged revisions 163094 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r163094 \| russell \| 2008-12-11 11:06:16 -0600 (Thu, 11 Dec 2008) \| 19 lines Merged revisions 163092 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163092 \| russell \| 2008-12-11 10:54:51 -0600 (Thu, 11 Dec 2008) \| 11 lines Fix an issue that made it so you could only have a single caller executing a custom feature at a time. This was especially problematic when custom features ran for any appreciable amount of time. The fix turned out to be quite simple. The dynamic features are now stored in a read/write list instead of a list using a mutex. (closes issue #13478) Reported by: neutrino88 Fix suggested by file ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163100 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	704f4a7d5c	Merged revisions 162922,162930 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r162922 \| tilghman \| 2008-12-10 16:48:09 -0600 (Wed, 10 Dec 2008) \| 7 lines Checking global variables here actually overwrote the previous substitution by channel variables, and in any case, was redundant; pbx_substitute_variables_helper ALREADY does substitution for global variables. (closes issue #13327) Reported by: pj ........ r162930 \| tilghman \| 2008-12-10 17:01:14 -0600 (Wed, 10 Dec 2008) \| 2 lines Previously missing line, now the substitution works correctly ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@162949 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	ffc955adae	Merged revisions 162656 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r162656 \| file \| 2008-12-10 12:06:59 -0400 (Wed, 10 Dec 2008) \| 13 lines Merged revisions 162653 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r162653 \| file \| 2008-12-10 12:05:29 -0400 (Wed, 10 Dec 2008) \| 6 lines Increment the sequence number on the end packets for RFC2833. After reading the RFC some more and doing some testing I agree with this change. (closes issue #12983) Reported by: vt Patches: dtmf_inc_seqnum_on_end_pkts.diff uploaded by vt (license 520) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@162658 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	5964f2e0f1	Merged revisions 162414 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r162414 \| russell \| 2008-12-09 16:25:06 -0600 (Tue, 09 Dec 2008) \| 16 lines Merged revisions 162413 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r162413 \| russell \| 2008-12-09 16:17:39 -0600 (Tue, 09 Dec 2008) \| 8 lines Remove the test_for_thread_safety() function completely. The test is not valid. Besides, if we actually suspected that recursive mutexes were not working, we would get a ton of LOG_ERROR messages when DEBUG_THREADS is turned on. (inspired by a discussion on the asterisk-dev list) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@162416 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	b6b83bbe9c	Merged revisions 162266 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r162266 \| mmichelson \| 2008-12-09 14:30:07 -0600 (Tue, 09 Dec 2008) \| 14 lines Merged revisions 162265 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r162265 \| mmichelson \| 2008-12-09 14:28:44 -0600 (Tue, 09 Dec 2008) \| 6 lines If we fail to start a thread for the pbx to run in, we need to be sure to decrease the number of active calls on the system. This fix may relate to ABE-1713, but it is not certain yet. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@162269 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago

1 2 3 4 5 ...

1996 Commits (e2ce2d9fab4378bb20c2aa0941b4be01df92a91d)