5019 Commits (cd119ed4a2a3e5efcae005bb8fa105ffd658582c)

Author	SHA1	Message	Date
Alexander Traud	69e3d40ad7	translate: Avoid a warning message when doing FEC within Opus Codec. ... ASTERISK-25616 #close Change-Id: Ibe729aaf2e6e25506cff247cec5149ec1e589319	11 years ago
Jonathan Rose	072d94183c	Fix crash in audiohook translate to slin ... This patch fixes a crash which would occur when an audiohook was applied to a channel using an audio codec that could not be translated to signed linear (such as when using pass-through codecs like OPUS or when the codec translator module for the format in use is not loaded). ASTERISK-25498 #close Reported by: Ben Langfeld Change-Id: Ib6ea7373fcc22e537cad373996136636201f4384	11 years ago
Joshua Colp	3b1452b542	Merge "sched.c: Make not return a sched id of 0." into 13	11 years ago
Joshua Colp	53d4f77064	Merge topic 'ASTERISK-25476' into 13 ... * changes: Audit improper usage of scheduler exposed by 5c713fdf18. (v13 additions) Audit improper usage of scheduler exposed by 5c713fdf18.	11 years ago
Jonathan Rose	eadad24b59	Unset BRIDGEPEER when leaving a bridge ... Currently if a channel is transferred out of a bridge, the BRIDGEPEER variable (also BRIDGEPVTCALLID) remain set even once the channel is out of the bridge. This patch removes these variables when leaving the bridge. ASTERISK-25600 #close Reported by: Mark Michelson Change-Id: I753ead2fffbfc65427ed4e9244c7066610e546da	11 years ago
Richard Mudgett	e7c88e11aa	sched.c: Make not return a sched id of 0. ... According to the API doxygen a sched ID of 0 is valid. Unfortunately, 0 was never returned historically and several users incorrectly coded usage of the returned sched ID assuming that 0 was invalid. ASTERISK-25476 Change-Id: Ib19c7ebb44ec9fd393ef6646dea806d4f34e3a20	11 years ago
Richard Mudgett	6d9156d10f	Audit improper usage of scheduler exposed by 5c713fdf18. ... channels/chan_iax2.c: * Initialize struct chan_iax2_pvt scheduler ids earlier because of iax2_destroy_helper(). channels/chan_sip.c: channels/sip/config_parser.c: * Fix initialization of scheduler id struct members. Some off nominal paths had 0 as a scheduler id to be destroyed when it was never started. chan_skinny.c: * Fix some scheduler id comparisons that excluded the valid 0 id. channel.c: * Fix channel initialization of the video stream scheduler id. pbx_dundi.c: * Fix channel initialization of the packet retransmission scheduler id. ASTERISK-25476 Change-Id: I07a3449f728f671d326a22fcbd071f150ba2e8c8	11 years ago
Walter Doekes	b2787876d6	main: Slight refactor of main. Improve color situation. ... Several issues are addressed here: - main() is large, and half of it is only used if we're not rasterisk; fixed by spliting up the daemon part into a separate function. - Call ast_term_init from rasterisk as well. - Remove duplicate code reading/writing asterisk history file. - Attempt to tackle background color issues and color changes that occur. Tested by starting asterisk -c until the colors stopped changing at odd locations. ASTERISK-25585 #close Change-Id: Ib641a0964c59ef9fe6f59efa8ccb481a9580c52f	11 years ago
Joshua Colp	3f85a1be5a	Merge "translate: Provide translation modules the result of SDP negotiation." into 13	11 years ago
Matt Jordan	af288b2d96	main/cli: Use proper string methods to check existence of context/exten/app ... Because the context, extension, and application are stored in stringfields, checking for them being NULL doesn't work so well. This patch uses the appropriate string library call, ast_strlen_zero, to see if there is a value in the context/exten/app values. Change-Id: Ie09623bfdf35f5a8d3b23dd596647fe3c97b9a23	11 years ago
Alexander Traud	0b508789ab	translate: Provide translation modules the result of SDP negotiation. ... Previously, a trancoding module did not have access to the joint but cached format. Therefore, the module did not have access to the attributes negotiated via SDP (line fmtp). Now, a translation module receives the joint format. ASTERISK-25545 #close Change-Id: Id6878a989b50573298dab115d3371ea369e1a718	11 years ago
Matt Jordan	e3cb27d341	Merge "format: Register format-attribute module with cached formats." into 13	11 years ago
Joshua Colp	afd9a89e5a	hashtab: Add NULL check when destroying iterator. ... The hashtab API is pretty NULL tolerant which has resulted in remaining callers not doing much checks themselves. Unfortunately the function to destroy an iterator does not do a NULL check and will result in a crash if passed NULL. This change fixes that. ASTERISK-25552 #close Change-Id: Ic1bf8eec3639e5a440f1c941d3ae3893ac6ed619	11 years ago
Mark Michelson	4f43b85c92	Taskprocessors: Increase high-water mark ... In practical tests, we have seen certain taskprocessors, specifically Stasis subscription taskprocessors, cross the recently-added high-water mark and emit a warning. This high-water mark warning is only intended to be emitted when things have tanked on the system and things are heading south quickly. In the practical tests, the Stasis taskprocessors sometimes had a max depth of 180 tasks in them, and Asterisk wasn't in any danger at all. As such, this ups the high-water mark to 500 tasks instead. It also redefines the SIP threadpool request denial number to be a multiple of the taskprocessor high-water mark. Change-Id: Ic8d3e9497452fecd768ac427bb6f58aa616eebce	11 years ago
Alexander Traud	d8d3991390	format: Register format-attribute module with cached formats. ... In Asterisk 13, cached formats are created before their corresponding format- attribute module is registered. Cached formats are involved when a local extension is called. Therefore, ast_format_generate_sdp_fmtp did not work on local extensions. This change affects the Opus Codec, H.263 (Plus), H.264, and format-attribute modules provided externally. ASTERISK-25160 #close Change-Id: I1ea1f0483e5261e2a050112e4ebdfc22057d1354	11 years ago
Joshua Colp	cd51b0aeac	Merge "res_pjsip: Deny requests when threadpool queue is backed up." into 13	11 years ago
Mark Michelson	2f9cb7d62b	res_pjsip: Deny requests when threadpool queue is backed up. ... We have observed situations where the SIP threadpool may become deadlocked. However, because incoming traffic is still arriving, the SIP threadpool's queue can continue to grow, eventually running the system out of memory. This change makes it so that incoming traffic gets rejected with a 503 response if the queue is backed up too much. Change-Id: I4e736d48a2ba79fd1f8056c0dcd330e38e6a3816	11 years ago
Joshua Colp	4e5bf12b33	format_cap: Don't append the 'none' format when appending all. ... When appending all formats of a type all the codecs are iterated and added. This operation was incorrectly adding the ast_format_none format which is special in that it is supposed to be used when no format is present. It shouldn't be appended. ASTERISK-25535 Change-Id: I7b00f3bdf4a5f3022e483d6ece602b1e8b12827c	11 years ago
Joshua Colp	b818d70533	threadpool: Handle worker thread transitioning to dead when going active. ... This change adds handling of dead worker threads when moving them to be active. When this happens the worker thread is removed from both the active and idle threads container. If no threads are able to be moved to active then the pool grows as configured. A unit test has also been added which thrashes the idle timeout and thread activation to exploit any race conditions between the two. ASTERISK-25546 #close Change-Id: I6c455f9a40de60d9e86458d447b548fb52ba1143	11 years ago
Matt Jordan	dac0bf063c	Merge "rtp_engine: Init a format-attribute module to its RFC defaults." into 13	11 years ago
Matt Jordan	e098fb1813	Merge "ast_format_cap: Avoid format creation on module load, use cache instead." into 13	11 years ago
Matt Jordan	bd157b9ca8	Merge "xmldoc: Improve xmldoc wrapping of 'core show ...' output." into 13	11 years ago
Alexander Traud	4bf84459c7	rtp_engine: Init a format-attribute module to its RFC defaults. ... Previously, format-attribute modules relied on an existing fmtp line in SDP negotiation. However, fmtp is optional for several formats like the Opus Codec. Now, the format-attribute module is called with an empty fmtp, which allows the module to initialise itself to RFC defaults. Furthermore now, Asterisk is able to differentiate between internally and externally created formats. ASTERISK-25537 #close Change-Id: I28f680cef7fdf51c0969ff8da71548edad72ec52	11 years ago
Joshua Colp	18e61a6442	Merge "taskprocessor: Add high water mark warnings" into 13	11 years ago
Alexander Traud	1bff400df7	ast_format_cap_get_names: To display all formats, the buffer was increased. ... ASTERISK-25533 #close Change-Id: Ie1a9d1a6511b3f1a56b93d04475fbf8a4e40010a	11 years ago
Alexander Traud	f3ac4d8090	ast_format_cap: Avoid format creation on module load, use cache instead. ... Since Asterisk 13, formats are immutable and cached. However while loading a module like chan_sip, some formats were created instead using cached ones. ASTERISK-25535 #close Change-Id: I479cdc220d5617c840a98f3389b3bd91e91fbd9b	11 years ago
Walter Doekes	0d425f2eb4	xmldoc: Improve xmldoc wrapping of 'core show ...' output. ... Previously, the wrapping did both lookahead and lookback, which, together with color escape sequences, caused some lines to be wrapped way earlier than other lines. This led to inconsistent output. This simplifies the wrapping code and makes it more sane: if maxcolumns is hit, we simply jump back to the last space and wrap there. ASTERISK-25527 #close Change-Id: I56d01c6f9a812642b1b05535c98d4db48d17c957	11 years ago
Jonathan Rose	6ff48319d9	taskprocessor: Add high water mark warnings ... If a taskprocessor's queue grows large, this can indicate that there may be a problem with tasks not leaving the processor or else that the number of available task processors for a given type of task is too low. This patch makes it so that if a taskprocessor's task queue grows above 100 queued tasks that it will emit a warning message. Warning messages are emitted only once per task processor. ASTERISK-25518 #close Reported by: Jonathan Rose Change-Id: Ib1607c35d18c1d6a0575b3f0e3ff5d932fd6600c	11 years ago
Matt Jordan	506aea26e6	main/dial: Protect access to the format_cap structure of the requesting channel ... When a dial attempt is made that involves a requesting channel, we previously were not: a) Protecting access to the native format capabilities structure on the requesting channel. That is inherently unsafe. b) Reference bumping the lifetime of the format capabilities structure. In both cases, something else could sneak in, blow away the format capabilities, and we'd be holding onto an invalid format_cap structure. When the newly created channel attempts to construct its format capabilities, things go poorly. This patch: a) Ensures that we get a reference to the native format capabilities while the requesting channel is locked b) Holds a reference to the native format capabilities during the creation of the new channel. ASTERISK-25522 #close Change-Id: I0bfb7ba8b9711f4158cbeaae96edf9626e88a54f	11 years ago
Corey Farrell	d098d00424	Fix cli display of build options. ... A previous commit reduced the AST_BUILDOPTS compiler define to only include options that affected ABI. This included some options that were previously displayed by cli "core show settings". This change corrects the CLI display while still restricting buildopts.h to ABI effecting options only. ASTERISK-25434 #close Reported by: Rusty Newton Change-Id: Id07af6bedd1d7d325878023e403fbd9d3607e325	11 years ago
Matt Jordan	f0f190af08	main/stasis_endpoints: Fix ContactStatusChange JSON for roundtrip_usec field ... The JSON packing for the ContactStatusChange event forgot to include the roundtrip_usec field. As a result, the field never showed up in any event, even when the data was available. This patch corrects that error by properly packing the JSON blob with the data. Change-Id: I8df80da659a44010afbd48f645967518ff5daa17	11 years ago
Matt Jordan	7d1a2b0839	Merge "format: Update the maximum packetization time for iLBC 30." into 13	11 years ago
Joshua Colp	84f1068bab	Merge topic 'fix_oom_crash' into 13 ... * changes: strings.c: Fix __ast_str_helper() to always return a terminated string. Add missing failure checks to ast_str_set_va() callers.	11 years ago
Mark Michelson	ebe69dee0d	format_cap: Detect vector allocation failures. ... A crash was seen on a system that ran out of memory due to Asterisk not checking for vector allocation failures in format_cap.c. With this change, if either of the AST_VECTOR_INIT calls fail, we will return a value indicating failure. Change-Id: Ieb9c59f39dfde6d11797a92b45e0cf8ac5722bc8	11 years ago
Richard Mudgett	c8c65dfa41	strings.c: Fix __ast_str_helper() to always return a terminated string. ... Users of functions which call __ast_str_helper() such as the ones listed below are likely to not check the return value for failure so ensuring that the string is always nil terminated is a good safety measure. ast_str_set_va() ast_str_append_va() ast_str_set() ast_str_append() Change-Id: I36ab2d14bb6015868b49329dda8639d70fbcae07	11 years ago
Richard Mudgett	b271d4a28a	Add missing failure checks to ast_str_set_va() callers. ... Change-Id: I0c2cdcd53727bdc6634095c61294807255bd278f	11 years ago
Alexander Traud	84ff075d41	format: Update the maximum packetization time for iLBC 30. ... In September 2006, the maximum packetization time (ptime) were set to such a low value, packetization was disabled for many codecs actually. This was fixed for many codecs but not for iLBC 30. This enables packetization for iLBC which can be enabled for example via allow=ilbc:60,gsm,alaw,ulaw in the file sip.conf. ASTERISK-7803 Change-Id: I2ef90023d35efb7cb8fe96ed74f53f6846ffad12	11 years ago
Richard Mudgett	e14023ca35	config.c: Fix off-nominal memory leak. ... Change-Id: I06e346e9a5c63cc5071e7eda537310c4b43bffe0	11 years ago
Richard Mudgett	a99e821520	config.c: Fix potential memory corruption after [section](+). ... The memory corruption could happen if the [section](+) is the last section in the file with trailing comments. In this case process_text_line() has left *last_cat is set to newcat and newcat is destroyed. Change-Id: I0d1d999f553986f591becd000e7cc6ddfb978d93	11 years ago
Richard Mudgett	8d31d2526b	config.c: Fix #include after [section](+). ... An #include right after a [section](+) would associate any variable assignments before a new section in the #include with the wrong section. * Fix section association by setting the current section to the appended section. * Fix '+' and '!' section flag interaction corner case depending upon which flag came first. If the '!' came first then it would be ignored. If the '!' came after then it would affect the appended section. The '!' will now no longer be ignored. ASTERISK-25461 #close Reported by: Sean Pimental Change-Id: Ic9d3191c8758048e2cbce6432f854b32531731c3	11 years ago
Ivan Poddubny	74635b5638	manager: Fix GetConfigJSON returning invalid JSON ... When GetConfigJSON was introduced back in 1.6, it returned each section as an array of strings: ["key=value", "key2=value2"]. Afterwards, it was changed a few times and became ["key": "value", "key2": "value2"], which is not a correct JSON. This patch fixes that by constructing a JSON object {} instead of an array []. Also, the keys "istemplate" and "tempates" that are used to indicate templates and their inherited categories are now wrapped in quotes. ASTERISK-25391 #close Reported by: Bojan Nemčić Change-Id: Ibbe93c6a227dff14d4a54b0d152341857bcf6ad8	11 years ago
Richard Mudgett	ddebb217f0	sched.c: Add warning about negative time interval request. ... Change-Id: Ib91435fb45b7f5f7c0fc83d0eec20b88098707bc	11 years ago
Joshua Colp	771757e338	Merge "translate: Fix transcoding while different in frame size." into 13	11 years ago
Joshua Colp	41f856e5a2	Merge "logger: Prevent duplicate dynamic channels from being added." into 13	11 years ago
Mark Michelson	f050fa76eb	logger: Prevent duplicate dynamic channels from being added. ... There was a problem observed where the "logger add channel" CLI command would allow for a channel with the same name to be added multiple times. This would result in each message being written out to the same file multiple times. The problem was due to the difference in how logger channel filenames are stored versus the format they are allowed to be presented when they are added. For instance, if adding the logger channel "foo" through the CLI, the result would be a logger channel with the file name /var/log/asterisk/foo being stored. So when trying to add another "foo" channel, "foo" would not match "/var/log/asterisk/foo" so we'd happily add the duplicate channel. The fix presented here is to introduce two new methods in the logger code: * make_filename(): given a logger channel name, this creates the filename for that logger channel. * find_logchannel(): given a logger channel name, this calls make_filename() and then traverses the list of logchannels in order to find a match. This change has made use of make_filename() and find_logchannel() throughout to more consistently behave. ASTERISK-25305 #close Reported by Mark Michelson Change-Id: I892d52954d6007d8bc453c3cbdd9235dec9c4a36	11 years ago
Mark Michelson	629458d349	Do not swallow frames on channels leaving bridges. ... When leaving a bridge, indications on a channel could be swallowed by the internal indication logic because it appears that the channel is on its way to be hung up anyway. One such situation where this is detrimental is when channels on hold are redirected out of a bridge. The AST_CONTROL_UNHOLD indication from the bridging code is swallowed, leaving the channel in question to still appear to be on hold. The fix here is to modify the logic inside ast_indicate_data() to not drop the indication if the channel is simply leaving a bridge. This way, channels on hold redirected out of a bridge revert to their expected "in use" state after the redirection. ASTERISK-25418 #close Reported by Mark Michelson Change-Id: If6115204dfa0551c050974ee138fabd15f978949	11 years ago
Matt Jordan	0d95610ae2	Merge "ARI: Add events for Contact and Peer Status changes" into 13	11 years ago
Richard Mudgett	5f15cd93f0	app_page.c: Fix crash when forwarding with a predial handler. ... Page uses the async method of dialing with the dial API. When a call gets forwarded there is no calling channel available. If the predial handler was set then the calling channel could not be put into auto-service for the forwarded call because it doesn't exist. A crash is the result. * Moved the callee predial parameter string processing to before the string is passed to the dial API rather than having the dial API do it. There are a few benefits do doing this. The first is the predial parameter string processing doesn't need to be done for each channel called by the dial API. The second is in async mode and the forwarded channel is to have the predial handler executed on it then the non-existent calling channel does not need to be present to process the predial parameter string. * Don't start auto-service on a non-existent calling channel to execute the predial handler when the dial API is in async mode and forwarding a call. ASTERISK-25384 #close Reported by: Chet Stevens Change-Id: If53892b286d29f6cf955e2545b03dcffa2610981	11 years ago
Matt Jordan	b50e372394	ARI: Add events for Contact and Peer Status changes ... This patch adds support for receiving events regarding Peer status changes and Contact status changes. This is particularly useful in scenarios where we are subscribed to all endpoints and channels, where we often want to know more about the state of channel technology specific items than a single endpoint's state. ASTERISK-24870 Change-Id: I6137459cdc25ce27efc134ad58abf065653da4e9	11 years ago
Elazar Broad	ec514ad64d	core/logging: Fix logging to more than one syslog channel ... Currently, Asterisk will log to the last configured syslog channel in logger.conf. This is due to the fact that the final call to openlog() supersedes all of the previous calls. This commit removes the call to openlog() and passes the facility to ast_log_vsyslog(), along with utilizing the LOG_MAKEPRI macro to ensure that the message is routed to the correct facility and with the correct priority. ASTERISK-25407 #close Reported by: Elazar Broad Tested by: Elazar Broad Change-Id: Ie2a2416bc00cce1b04e99ef40917c2011953ddd2	11 years ago